Commit 69109ab1 authored by chang.shu@nokia.com's avatar chang.shu@nokia.com

2010-11-08 Chang Shu <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        Unskip test that is passing now.
        https://bugs.webkit.org/show_bug.cgi?id=49150

        * platform/gtk/Skipped:
2010-11-08  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        [GTK] Use Space to toggle arrow key handling for selection change or
        spatial navigation. Put the logic in common code to pass both Qt and
        GTK. Mac won't work because arrow keys trigger the popup.
        https://bugs.webkit.org/show_bug.cgi?id=49150

        Existing test: fast/events/spatial-navigation/snav-single-select.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::menuListDefaultEventHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent bc0712b6
2010-11-08 Chang Shu <chang.shu@nokia.com>
Reviewed by Antonio Gomes.
Unskip test that is passing now.
https://bugs.webkit.org/show_bug.cgi?id=49150
* platform/gtk/Skipped:
2010-11-08 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed. Rebaselines for r71589.
......@@ -5678,9 +5678,6 @@ mathml/presentation
# https://bugs.webkit.org/show_bug.cgi?id=49052
fast/canvas/pointInPath.html
# https://bugs.webkit.org/show_bug.cgi?id=49176
fast/events/spatial-navigation/snav-single-select.html
# https://bugs.webkit.org/show_bug.cgi?id=49177
fast/events/scroll-after-click-on-tab-index.html
......
2010-11-08 Chang Shu <chang.shu@nokia.com>
Reviewed by Antonio Gomes.
[GTK] Use Space to toggle arrow key handling for selection change or
spatial navigation. Put the logic in common code to pass both Qt and
GTK. Mac won't work because arrow keys trigger the popup.
https://bugs.webkit.org/show_bug.cgi?id=49150
Existing test: fast/events/spatial-navigation/snav-single-select.html
* dom/SelectElement.cpp:
(WebCore::SelectElement::menuListDefaultEventHandler):
2010-11-08 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Pavel Feldman.
......@@ -605,6 +605,13 @@ void SelectElement::menuListDefaultEventHandler(SelectElementData& data, Element
int keyCode = static_cast<KeyboardEvent*>(event)->keyCode();
bool handled = false;
if (keyCode == ' ' && isSpatialNavigationEnabled(element->document()->frame())) {
// Use space to toggle arrow key handling for selection change or spatial navigation.
data.setActiveSelectionState(!data.activeSelectionState());
event->setDefaultHandled();
return;
}
#if SPACE_OR_RETURN_POP_MENU
if (keyCode == ' ' || keyCode == '\r') {
element->focus();
......@@ -644,10 +651,6 @@ void SelectElement::menuListDefaultEventHandler(SelectElementData& data, Element
// listIndex should already be selected, but this will fire the onchange handler.
setSelectedIndex(data, element, listToOptionIndex(data, element, listIndex), true, true);
handled = true;
} else if (keyCode == ' ' && isSpatialNavigationEnabled(element->document()->frame())) {
// Use space to trigger arrow key handling for selection change or spatial navigation.
data.setActiveSelectionState(!data.activeSelectionState());
handled = true;
}
#endif
if (handled)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment