Commit 684b35c9 authored by betravis@adobe.com's avatar betravis@adobe.com

[css exclusions] Enable CSS Exclusions by default when CSS_EXCLUSIONS is set

https://bugs.webkit.org/show_bug.cgi?id=115919

Reviewed by Dean Jackson.

Source/WebCore:

Change the RuntimeEnabledFeatures::isCSSExclusionsEnabled boolean to default
to true. CSS Exclusions can still be enabled / disabled in platforms by
setting the CSS_EXCLUSIONS compile flag in one of the FeatureDefine files.

Test: fast/exclusions/css-exclusions-enabled.html

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):

LayoutTests:

Adding a test to make sure CSS Exclusions can be enabled, and are enabled by
default.

* fast/exclusions/css-exclusions-enabled-expected.txt: Added.
* fast/exclusions/css-exclusions-enabled.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 90c635e3
2013-05-13 Bear Travis <betravis@adobe.com>
[css exclusions] Enable CSS Exclusions by default when CSS_EXCLUSIONS is set
https://bugs.webkit.org/show_bug.cgi?id=115919
Reviewed by Dean Jackson.
Adding a test to make sure CSS Exclusions can be enabled, and are enabled by
default.
* fast/exclusions/css-exclusions-enabled-expected.txt: Added.
* fast/exclusions/css-exclusions-enabled.html: Added.
2013-05-13 Suchit Agrawal <a.suchit@samsung.com>
Cell heights are disproportional when a row-spanning cell contains a block element that determines the height of the rows
......
Test that parsing of css exclusions related properties is enabled by default.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS testInlineStyle("-webkit-wrap-flow", "both") is "both"
PASS testComputedStyle("-webkit-wrap-flow", "both") is "both"
PASS testInlineStyle("-webkit-shape-margin", "10px") is "10px"
PASS testComputedStyle("-webkit-shape-margin", "10px") is "10px"
PASS testInlineStyle("-webkit-shape-padding", "10px") is "10px"
PASS testComputedStyle("-webkit-shape-padding", "10px") is "10px"
PASS testInlineStyle("-webkit-wrap-through", "none") is "none"
PASS testComputedStyle("-webkit-wrap-through", "none") is "none"
PASS testInlineStyle("-webkit-shape-outside", "circle(10px, 10px, 10px)") is "circle(10px, 10px, 10px)"
PASS testComputedStyle("-webkit-shape-outside", "circle(10px, 10px, 10px)") is "circle(10px, 10px, 10px)"
PASS testInlineStyle("-webkit-shape-inside", "circle(10px, 10px, 10px)") is "circle(10px, 10px, 10px)"
PASS testComputedStyle("-webkit-shape-inside", "circle(10px, 10px, 10px)") is "circle(10px, 10px, 10px)"
PASS successfullyParsed is true
TEST COMPLETE
<!DOCTYPE html>
<html>
<body>
<script src="../js/resources/js-test-pre.js"></script>
<script>
description('Test that parsing of css exclusions related properties is enabled by default.');
function testInlineStyle(property, value) {
var div = document.createElement("div");
div.setAttribute("style", property + ": " + value);
return div.style.getPropertyValue(property);
}
function testComputedStyle(property, value) {
var div = document.createElement("div");
document.body.appendChild(div);
div.style.setProperty(property, value);
var computedValue = getComputedStyle(div).getPropertyValue(property);
document.body.removeChild(div);
return computedValue;
}
function testStyle(property, value, expected) {
shouldBeEqualToString('testInlineStyle("' + property + '", "' + value + '")', expected);
shouldBeEqualToString('testComputedStyle("' + property + '", "' + value + '")', expected);
}
testStyle("-webkit-wrap-flow", "both", "both");
testStyle("-webkit-shape-margin", "10px", "10px");
testStyle("-webkit-shape-padding", "10px", "10px");
testStyle("-webkit-wrap-through", "none", "none");
testStyle("-webkit-shape-outside", "circle(10px, 10px, 10px)", "circle(10px, 10px, 10px)");
testStyle("-webkit-shape-inside", "circle(10px, 10px, 10px)", "circle(10px, 10px, 10px)");
</script>
<script src="../js/resources/js-test-post.js"></script>
</body>
</html>
2013-05-13 Bear Travis <betravis@adobe.com>
[css exclusions] Enable CSS Exclusions by default when CSS_EXCLUSIONS is set
https://bugs.webkit.org/show_bug.cgi?id=115919
Reviewed by Dean Jackson.
Change the RuntimeEnabledFeatures::isCSSExclusionsEnabled boolean to default
to true. CSS Exclusions can still be enabled / disabled in platforms by
setting the CSS_EXCLUSIONS compile flag in one of the FeatureDefine files.
Test: fast/exclusions/css-exclusions-enabled.html
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
2013-05-13 Suchit Agrawal <a.suchit@samsung.com>
Cell heights are disproportional when a row-spanning cell contains a block element that determines the height of the rows
......
......@@ -55,7 +55,7 @@ bool RuntimeEnabledFeatures::isDeviceMotionEnabled = true;
bool RuntimeEnabledFeatures::isDeviceOrientationEnabled = true;
bool RuntimeEnabledFeatures::isSpeechInputEnabled = true;
bool RuntimeEnabledFeatures::isCanvasPathEnabled = false;
bool RuntimeEnabledFeatures::isCSSExclusionsEnabled = false;
bool RuntimeEnabledFeatures::isCSSExclusionsEnabled = true;
bool RuntimeEnabledFeatures::isCSSRegionsEnabled = false;
bool RuntimeEnabledFeatures::isCSSCompositingEnabled = false;
bool RuntimeEnabledFeatures::isLangAttributeAwareFormControlUIEnabled = false;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment