Commit 683ff4f1 authored by andreip@google.com's avatar andreip@google.com

2010-12-20 Andrei Popescu <andreip@google.com>

        Reviewed by Jeremy Orlow.

        [Chromium] v8/SerializedScriptValue::readUint32 treats incoming raw values as signed instead of unsigned
        https://bugs.webkit.org/show_bug.cgi?id=51338

        * fast/dom/Window/window-postmessage-args-expected.txt:
        * fast/dom/Window/window-postmessage-args.html:
        * platform/chromium-mac/fast/dom/Window/window-postmessage-args-expected.txt:
        * platform/chromium-win/fast/dom/Window/window-postmessage-args-expected.txt:
2010-12-20  Andrei Popescu  <andreip@google.com>

        Reviewed by Jeremy Orlow.

        [Chromium] v8/SerializedScriptValue::readUint32 treats incoming raw values as signed instead of unsigned
        https://bugs.webkit.org/show_bug.cgi?id=51338

        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::ZigZag::Reader::readUint32):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent ccde5ff3
2010-12-20 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[Chromium] v8/SerializedScriptValue::readUint32 treats incoming raw values as signed instead of unsigned
https://bugs.webkit.org/show_bug.cgi?id=51338
* fast/dom/Window/window-postmessage-args-expected.txt:
* fast/dom/Window/window-postmessage-args.html:
* platform/chromium-mac/fast/dom/Window/window-postmessage-args-expected.txt:
* platform/chromium-win/fast/dom/Window/window-postmessage-args-expected.txt:
2010-12-20 Beth Dakin <bdakin@apple.com>
Reviewed by Ada Chan.
......
......@@ -7,10 +7,12 @@ PASS: Posting message ('4', [object DOMWindow]) did not throw an exception
PASS: Posting message ('5', null) did not throw an exception
PASS: Posting message ('6', undefined) did not throw an exception
PASS: Posting message ('7', [object MessagePort],[object MessagePort]) did not throw an exception
PASS: Posting message ('2147483648', null) did not throw an exception
PASS: Posting message ('done', *) did not throw an exception
Received message '4'
Received message '5'
Received message '6'
Received message '7' with 2 ports.
Received message '2147483648'
Received message 'done'
......@@ -45,6 +45,7 @@ tryPostMessage('4', window, '*'); // Passes because window has a "length" attri
tryPostMessage('5', null, '*');
tryPostMessage('6', void 0, '*');
tryPostMessage('7', [channel.port1, channel.port2], '*');
tryPostMessage(2147483648, null, '*');
tryPostMessage('done', '*');
</script>
</body>
......
......@@ -7,10 +7,12 @@ PASS: Posting message ('4', [object DOMWindow]) did not throw an exception
PASS: Posting message ('5', null) did not throw an exception
PASS: Posting message ('6', undefined) did not throw an exception
PASS: Posting message ('7', [object MessagePort],[object MessagePort]) did not throw an exception
PASS: Posting message ('2147483648', null) did not throw an exception
PASS: Posting message ('done', *) did not throw an exception
Received message '4'
Received message '5'
Received message '6'
Received message '7' with 2 ports.
Received message '2147483648'
Received message 'done'
......@@ -7,10 +7,12 @@ PASS: Posting message ('4', [object DOMWindow]) did not throw an exception
PASS: Posting message ('5', null) did not throw an exception
PASS: Posting message ('6', undefined) did not throw an exception
PASS: Posting message ('7', [object MessagePort],[object MessagePort]) did not throw an exception
PASS: Posting message ('2147483648', null) did not throw an exception
PASS: Posting message ('done', *) did not throw an exception
Received message '4'
Received message '5'
Received message '6'
Received message '7' with 2 ports.
Received message '2147483648'
Received message 'done'
2010-12-20 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[Chromium] v8/SerializedScriptValue::readUint32 treats incoming raw values as signed instead of unsigned
https://bugs.webkit.org/show_bug.cgi?id=51338
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::ZigZag::Reader::readUint32):
2010-12-20 Beth Dakin <bdakin@apple.com>
Reviewed by Ada Chan.
......
......@@ -844,7 +844,7 @@ private:
uint32_t rawValue;
if (!doReadUint32(&rawValue))
return false;
*value = v8::Integer::New(rawValue);
*value = v8::Integer::NewFromUnsigned(rawValue);
return true;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment