Commit 65ff24c9 authored by darin@chromium.org's avatar darin@chromium.org

2008-10-23 Darin Fisher <darin@chromium.org>

        Reviewed by Eric Seidel.

        m_frame null checked but then dereferenced
        https://bugs.webkit.org/show_bug.cgi?id=21845

        This error was found using a static analysis tool, and so I do not know
        how to produce a null m_frame on entry to this method.  Hence, I have
        not included a regression test.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::allowDHTMLDrag): Add an early return.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent eb5dc783
2008-10-23 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
m_frame null checked but then dereferenced
https://bugs.webkit.org/show_bug.cgi?id=21845
This error was found using a static analysis tool, and so I do not know
how to produce a null m_frame on entry to this method. Hence, I have
not included a regression test.
* page/EventHandler.cpp:
(WebCore::EventHandler::allowDHTMLDrag): Add an early return.
2008-10-23 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig with no hesitation.
......
......@@ -677,6 +677,7 @@ void EventHandler::allowDHTMLDrag(bool& flagDHTML, bool& flagUA) const
if (!m_frame || !m_frame->document()) {
flagDHTML = false;
flagUA = false;
return;
}
unsigned mask = m_frame->page()->dragController()->delegateDragSourceAction(m_frame->view()->contentsToWindow(m_mouseDownPos));
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment