Commit 64d0d183 authored by tkent@chromium.org's avatar tkent@chromium.org
Browse files

Make HTMLProgressElement::isDeterminate private

https://bugs.webkit.org/show_bug.cgi?id=113299

Reviewed by Kentaro Hara.

The only callsite of isDeterminate outside of HTMLProgressElement
is in StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes,
and we can replace it with Element::shouldAppearIndeterminate.

No new tests. Just a refactoring.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
Use Element::shouldAppearIndeterminate.
* html/HTMLProgressElement.h:
(HTMLProgressElement): Make isDeterminate private.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 0ad977c8
2013-03-26 Kent Tamura <tkent@chromium.org>
Make HTMLProgressElement::isDeterminate private
https://bugs.webkit.org/show_bug.cgi?id=113299
Reviewed by Kentaro Hara.
The only callsite of isDeterminate outside of HTMLProgressElement
is in StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes,
and we can replace it with Element::shouldAppearIndeterminate.
No new tests. Just a refactoring.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
Use Element::shouldAppearIndeterminate.
* html/HTMLProgressElement.h:
(HTMLProgressElement): Make isDeterminate private.
2013-03-26 David Grogan <dgrogan@chromium.org>
 
IndexedDB: Histogram cause of LevelDB write errors
......@@ -613,7 +613,7 @@ bool StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes(StyledE
#if ENABLE(PROGRESS_ELEMENT)
if (state.element()->hasTagName(progressTag)) {
if (static_cast<HTMLProgressElement*>(state.element())->isDeterminate() != static_cast<HTMLProgressElement*>(sharingCandidate)->isDeterminate())
if (state.element()->shouldAppearIndeterminate() != sharingCandidate->shouldAppearIndeterminate())
return false;
}
#endif
......
......@@ -44,8 +44,6 @@ public:
double position() const;
bool isDeterminate() const;
virtual bool canContainRangeEndPoint() const { return false; }
private:
......@@ -66,6 +64,7 @@ private:
void didElementStateChange();
virtual void didAddUserAgentShadowRoot(ShadowRoot*) OVERRIDE;
bool isDeterminate() const;
ProgressValueElement* m_value;
};
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment