Commit 644e6bdf authored by jer.noble@apple.com's avatar jer.noble@apple.com
Browse files

HTML5 Video Full Screen button broken (looks like white square)

https://bugs.webkit.org/show_bug.cgi?id=84101

Reviewed by Dan Bernstein.

Source/WebCore:

No new tests; updated platform results which were previously rebaselined.

Use the correct CSS keyword for the -webkit-appearance of the full screen button.

* css/mediaControls.css:
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):

LayoutTests:

* platform/mac/media/controls-after-reload-expected.png:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-strict-expected.png:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/video-controls-rendering-expected.png:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.png:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-no-audio-expected.png:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-playing-and-pause-expected.png:
* platform/mac/media/video-playing-and-pause-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent dd763df5
2012-04-17 Jer Noble <jer.noble@apple.com>
HTML5 Video Full Screen button broken (looks like white square)
https://bugs.webkit.org/show_bug.cgi?id=84101
Reviewed by Dan Bernstein.
* platform/mac/media/controls-after-reload-expected.png:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-strict-expected.png:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/video-controls-rendering-expected.png:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.png:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-no-audio-expected.png:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-playing-and-pause-expected.png:
* platform/mac/media/video-playing-and-pause-expected.txt:
2012-04-17 Stephen Chenney <schenney@chromium.org>
 
SVG should support transform-origin and relative values
......@@ -29,7 +29,7 @@ layer at (8,257) size 320x25
RenderBlock (anonymous) at (7,0) size 31x11
RenderText {#text} at (0,0) size 31x11
text run at (0,0) width 31: "-00:06"
RenderButton {INPUT} at (297,3) size 16x18
RenderButton {INPUT} at (297,4) size 16x16
RenderButton {INPUT} at (267,6) size 14x12
layer at (102,266) size 10x8
RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
......@@ -29,7 +29,7 @@ layer at (8,265) size 320x25
RenderBlock (anonymous) at (7,0) size 31x11
RenderText {#text} at (0,0) size 31x11
text run at (0,0) width 31: "-00:06"
RenderButton {INPUT} at (297,3) size 16x18
RenderButton {INPUT} at (297,4) size 16x16
RenderButton {INPUT} at (267,6) size 14x12
layer at (102,274) size 10x8
RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
......@@ -34,7 +34,7 @@ layer at (8,257) size 320x25
RenderBlock (anonymous) at (7,0) size 31x11
RenderText {#text} at (0,0) size 31x11
text run at (0,0) width 31: "-00:06"
RenderButton {INPUT} at (297,3) size 16x18
RenderButton {INPUT} at (297,4) size 16x16
RenderButton {INPUT} at (267,6) size 14x12
layer at (102,266) size 10x8
RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
......@@ -57,7 +57,7 @@ layer at (8,497) size 320x25
RenderBlock (anonymous) at (7,0) size 31x11
RenderText {#text} at (0,0) size 31x11
text run at (0,0) width 31: "-00:06"
RenderButton {INPUT} at (297,3) size 16x18
RenderButton {INPUT} at (297,4) size 16x16
RenderButton {INPUT} at (267,6) size 14x12
layer at (102,506) size 10x8
RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
......@@ -82,7 +82,7 @@ layer at (8,737) size 320x25
RenderBlock (anonymous) at (7,0) size 31x11
RenderText {#text} at (0,0) size 31x11
text run at (0,0) width 31: "-00:06"
RenderButton {INPUT} at (297,3) size 16x18
RenderButton {INPUT} at (297,4) size 16x16
RenderButton {INPUT} at (267,6) size 14x12
layer at (102,746) size 10x8
RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
......@@ -28,7 +28,7 @@ layer at (8,241) size 320x25
RenderBlock (anonymous) at (7,0) size 31x11
RenderText {#text} at (0,0) size 31x11
text run at (0,0) width 31: "-00:06"
RenderButton {INPUT} at (297,3) size 16x18
RenderButton {INPUT} at (297,4) size 16x16
RenderButton {INPUT} at (267,6) size 14x12
layer at (102,250) size 10x8
RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
......@@ -29,6 +29,6 @@ layer at (8,305) size 352x25
RenderBlock (anonymous) at (7,0) size 31x11
RenderText {#text} at (0,0) size 31x11
text run at (0,0) width 31: "-00:09"
RenderButton {INPUT} at (329,3) size 16x18
RenderButton {INPUT} at (329,4) size 16x16
layer at (102,314) size 10x8
RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
......@@ -30,7 +30,7 @@ layer at (8,283) size 320x25
RenderBlock (anonymous) at (7,0) size 31x11
RenderText {#text} at (0,0) size 31x11
text run at (0,0) width 31: "-00:06"
RenderButton {INPUT} at (297,3) size 16x18
RenderButton {INPUT} at (297,4) size 16x16
RenderButton {INPUT} at (267,6) size 14x12
layer at (102,292) size 10x8
RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
2012-04-17 Jer Noble <jer.noble@apple.com>
HTML5 Video Full Screen button broken (looks like white square)
https://bugs.webkit.org/show_bug.cgi?id=84101
Reviewed by Dan Bernstein.
No new tests; updated platform results which were previously rebaselined.
Use the correct CSS keyword for the -webkit-appearance of the full screen button.
* css/mediaControls.css:
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
2012-04-17 Tom Sepez <tsepez@chromium.org>
 
Framesniffing defense is too aggressive.
......@@ -150,7 +150,7 @@ audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls
}
audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button {
-webkit-appearance: media-fullscreen-button;
-webkit-appearance: media-enter-fullscreen-button;
display: -webkit-box;
width: 16px;
height: 16px;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment