[GTK] close the volume slider when the media control panel is hidden

https://bugs.webkit.org/show_bug.cgi?id=119062

Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2013-08-13
Reviewed by Gustavo Noronha Silva.

It's not obvious how to close the volume slider on webkitGtk.
The volume slider should close if the control panel is hidden.

* html/shadow/MediaControlsGtk.cpp:
(WebCore::MediaControlsGtk::makeTransparent):
* html/shadow/MediaControlsGtk.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent ba11246f
2013-08-13 Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk>
[GTK] close the volume slider when the media control panel is hidden
https://bugs.webkit.org/show_bug.cgi?id=119062
Reviewed by Gustavo Noronha Silva.
It's not obvious how to close the volume slider on webkitGtk.
The volume slider should close if the control panel is hidden.
* html/shadow/MediaControlsGtk.cpp:
(WebCore::MediaControlsGtk::makeTransparent):
* html/shadow/MediaControlsGtk.h:
2013-08-13 Commit Queue <commit-queue@webkit.org>
Unreviewed, rolling out r152563.
......@@ -201,6 +201,15 @@ void MediaControlsGtk::changedMute()
m_volumeSlider->setVolume(m_mediaController->volume());
}
void MediaControlsGtk::makeTransparent()
{
MediaControls::makeTransparent();
if (m_volumeSliderContainer)
m_volumeSliderContainer->hide();
}
void MediaControlsGtk::showVolumeSlider()
{
if (!m_mediaController->hasAudio())
......
......@@ -46,6 +46,7 @@ public:
void changedMute() OVERRIDE;
virtual void updateCurrentTimeDisplay() OVERRIDE;
virtual void showVolumeSlider() OVERRIDE;
virtual void makeTransparent() OVERRIDE;
#if ENABLE(VIDEO_TRACK)
void createTextTrackDisplay() OVERRIDE;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment