Commit 62681d7b authored by commit-queue@webkit.org's avatar commit-queue@webkit.org
Browse files

[EFL] Attempt to create a theme for 0 sized element leads to assertion hit

https://bugs.webkit.org/show_bug.cgi?id=96743

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
on that causing crash in debug mode.

Test: fast/forms/range/slider-zero-size-crash.html

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):

LayoutTests:

RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
on that causing crash in debug mode.

* fast/forms/range/slider-zero-size-crash-expected.txt: Added.
* fast/forms/range/slider-zero-size-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent bb5e6bef
2012-09-14 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
[EFL] Attempt to create a theme for 0 sized element leads to assertion hit
https://bugs.webkit.org/show_bug.cgi?id=96743
Reviewed by Kenneth Rohde Christiansen.
RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
on that causing crash in debug mode.
* fast/forms/range/slider-zero-size-crash-expected.txt: Added.
* fast/forms/range/slider-zero-size-crash.html: Added.
2012-09-14 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
 
[EFL] Gardening of failing tests
<!DOCTYPE html>
<html>
<head>
<title>A slider with '0' size does not lead to a crash</title>
<link rel="author" title="Mikhail Pozdnyakov" href="mailto:mikhail.pozdnyakov@intel.com" />
<script>
if (window.testRunner)
testRunner.dumpAsText();
</script>
</head>
<input type="range" id="slider"/>
<script>
document.getElementById("slider").style.height="0px"
document.getElementById("slider").style.width="0px";
</script>
<p>This test passes if it does not crash.</p>
</html>
2012-09-14 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
[EFL] Attempt to create a theme for 0 sized element leads to assertion hit
https://bugs.webkit.org/show_bug.cgi?id=96743
Reviewed by Kenneth Rohde Christiansen.
RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
on that causing crash in debug mode.
Test: fast/forms/range/slider-zero-size-crash.html
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
2012-09-14 Andrey Kosyakov <caseq@chromium.org>
 
Web Inspector: reuse WebInspector.ProgressIndicator in Audits panel
......@@ -196,9 +196,8 @@ static bool isFormElementTooLargeToDisplay(const IntSize& elementSize)
RenderThemeEfl::ThemePartCacheEntry* RenderThemeEfl::ThemePartCacheEntry::create(const String& themePath, FormType type, const IntSize& size)
{
ASSERT(!themePath.isEmpty());
ASSERT(!size.isEmpty());
if (isFormElementTooLargeToDisplay(size)) {
if (isFormElementTooLargeToDisplay(size) || size.isEmpty()) {
EINA_LOG_ERR("Cannot render an element of size %dx%d.", size.width(), size.height());
return 0;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment