Commit 620e8573 authored by timothy@apple.com's avatar timothy@apple.com

Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.

Also fix some URLs to not have extras slashes and add a page title.

https://bugs.webkit.org/show_bug.cgi?id=122192

Reviewed by Joseph Pecoraro.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot.prototype.buildLogURLForIteration):
(WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
(WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 203cdfa0
......@@ -56,18 +56,18 @@ BuildbotTesterQueueView.prototype = {
var limit = 2;
for (var i = 0; i < queue.iterations.length && limit > 0; ++i) {
var iteration = queue.iterations[i];
if (!iteration.finished)
if (!iteration.loaded || !iteration.finished)
continue;
--limit;
var messageLinkElement = this.revisionLinksForIteration(iteration);
var layoutTestResults = iteration.layoutTestResults;
var javascriptTestResults = iteration.javascriptTestResults;
var pythonTestResults = iteration.pythonTestResults;
var perlTestResults = iteration.perlTestResults;
var bindingTestResults = iteration.bindingTestResults;
var layoutTestResults = iteration.layoutTestResults || {};
var javascriptTestResults = iteration.javascriptTestResults || {};
var pythonTestResults = iteration.pythonTestResults || {};
var perlTestResults = iteration.perlTestResults || {};
var bindingTestResults = iteration.bindingTestResults || {};
if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && !bindingTestResults.failureCount) {
var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Good, "all tests passed");
......
......@@ -61,16 +61,16 @@ WebKitBuildbot.prototype = {
buildLogURLForIteration: function(iteration)
{
return this.baseURL + "/builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/compile-webkit/logs/stdio/text";
return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/compile-webkit/logs/stdio/text";
},
layoutTestResultsURLForIteration: function(iteration)
{
return this.baseURL + "/results/" + encodeURIComponent(iteration.queue.id) + "/" + encodeURIComponent("r" + iteration.openSourceRevision + " (" + iteration.id + ")") + "/results.html";
return this.baseURL + "results/" + encodeURIComponent(iteration.queue.id) + "/" + encodeURIComponent("r" + iteration.openSourceRevision + " (" + iteration.id + ")") + "/results.html";
},
javascriptTestResultsURLForIteration: function(iteration)
{
return this.baseURL + "/builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/jscore-test/logs/actual.html";
return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id + "/steps/jscore-test/logs/actual.html";
}
};
......@@ -25,6 +25,8 @@ THE POSSIBILITY OF SUCH DAMAGE.
<!DOCTYPE html>
<html>
<head>
<title>WebKit Buildbot Dashboard</title>
<link rel="stylesheet" href="Styles/Main.css"></link>
<link rel="stylesheet" href="Styles/BuildbotQueueView.css"></link>
<link rel="stylesheet" href="Styles/BuildbotBuilderQueueView.css"></link>
......
2013-10-01 Timothy Hatcher <timothy@apple.com>
Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
Also fix some URLs to not have extras slashes and add a page title.
https://bugs.webkit.org/show_bug.cgi?id=122192
Reviewed by Joseph Pecoraro.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot.prototype.buildLogURLForIteration):
(WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
(WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2013-10-01 Alexey Proskuryakov <ap@apple.com>
[Mac] Set NSApplication current event while sending events directly to views
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment