Commit 619d38aa authored by chang.shu@nokia.com's avatar chang.shu@nokia.com
Browse files

2011-01-19 Chang Shu <chang.shu@nokia.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=52056
        1. Fixed test cases in the above bug;
        2. Partially fixed test cases in other contentEditable bugs;
        3. Updated expected result for fast/dom/element-attribute-js-null.html.
           However, the test itself should be fixed later in bug 52057.

        * editing/editability/attr-invalid-string-expected.txt:
        * editing/editability/attr-invalid-string.html:
        * editing/editability/attr-missing-ancestor-false-expected.txt:
        * editing/editability/attr-missing-ancestor-false.html:
        * editing/editability/attr-missing-ancestor-true-expected.txt:
        * editing/editability/attr-missing-ancestor-true.html:
        * editing/editability/attr-missing-parent-ancestor-missing-expected.txt:
        * editing/editability/attr-missing-parent-ancestor-missing.html:
        * editing/editability/attr-missing-parent-false-expected.txt:
        * editing/editability/attr-missing-parent-false.html:
        * editing/editability/attr-missing-parent-true-expected.txt:
        * editing/editability/attr-missing-parent-true.html:
        * editing/editability/set-false-expected.txt:
        * editing/editability/set-inherit-parent-false-expected.txt:
        * editing/editability/set-inherit-parent-true-expected.txt:
        * editing/editability/set-invalid-value-expected.txt:
        * editing/editability/set-true-expected.txt:
        * editing/editability/set-value-caseinsensitive-expected.txt:
        * fast/dom/element-attribute-js-null-expected.txt:
2011-01-19  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Darin Adler.

        The return value of contentEditable() function should depend on the DOM attribute
        instead of render style userModify. The code change fixed test cases in the bug
        and partially fixed test cases in other contentEditable bugs;

        https://bugs.webkit.org/show_bug.cgi?id=52056

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::contentEditable):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 7b201aad
2011-01-19 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=52056
1. Fixed test cases in the above bug;
2. Partially fixed test cases in other contentEditable bugs;
3. Updated expected result for fast/dom/element-attribute-js-null.html.
However, the test itself should be fixed later in bug 52057.
* editing/editability/attr-invalid-string-expected.txt:
* editing/editability/attr-invalid-string.html:
* editing/editability/attr-missing-ancestor-false-expected.txt:
* editing/editability/attr-missing-ancestor-false.html:
* editing/editability/attr-missing-ancestor-true-expected.txt:
* editing/editability/attr-missing-ancestor-true.html:
* editing/editability/attr-missing-parent-ancestor-missing-expected.txt:
* editing/editability/attr-missing-parent-ancestor-missing.html:
* editing/editability/attr-missing-parent-false-expected.txt:
* editing/editability/attr-missing-parent-false.html:
* editing/editability/attr-missing-parent-true-expected.txt:
* editing/editability/attr-missing-parent-true.html:
* editing/editability/set-false-expected.txt:
* editing/editability/set-inherit-parent-false-expected.txt:
* editing/editability/set-inherit-parent-true-expected.txt:
* editing/editability/set-invalid-value-expected.txt:
* editing/editability/set-true-expected.txt:
* editing/editability/set-value-caseinsensitive-expected.txt:
* fast/dom/element-attribute-js-null-expected.txt:
2011-01-19 Levi Weintraub <leviw@chromium.org>
 
Reviewed by Darin Adler.
......
......@@ -7,8 +7,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
PASS document.getElementById("div").getAttribute("contentEditable") is "abc"
FAIL document.getElementById("div").contentEditable should be inherit. Was false.
FIXME: contentEditable attribute fails to take invalid value. https://bugs.webkit.org/show_bug.cgi?id=50636
PASS document.getElementById("div").contentEditable is "inherit"
PASS document.getElementById("div").isContentEditable is false
PASS window.getComputedStyle(div, "").getPropertyValue("-webkit-user-modify") is "read-only"
......
......@@ -13,7 +13,6 @@ description('When contentEditable attribute is invalid string, element.contentEd
shouldBe('document.getElementById("div").getAttribute("contentEditable")','"abc"');
shouldBe('document.getElementById("div").contentEditable', '"inherit"');
debug("FIXME: contentEditable attribute fails to take invalid value. https://bugs.webkit.org/show_bug.cgi?id=50636");
shouldBe('document.getElementById("div").isContentEditable', 'false');
shouldBe('window.getComputedStyle(div, "").getPropertyValue("-webkit-user-modify")', '"read-only"');
......
......@@ -7,8 +7,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
PASS document.getElementById("p").hasAttribute("contentEditable") is false
FAIL document.getElementById("p").contentEditable should be inherit. Was false.
FIXME: contentEditable attribute should be inherit if missing. https://bugs.webkit.org/show_bug.cgi?id=52056
PASS document.getElementById("p").contentEditable is "inherit"
PASS document.getElementById("p").isContentEditable is false
PASS window.getComputedStyle(p, "").getPropertyValue("-webkit-user-modify") is "read-only"
......
......@@ -19,7 +19,6 @@ description('When contentEditable is missing, it maps to "inherit" state and the
shouldBe('document.getElementById("p").hasAttribute("contentEditable")', 'false');
shouldBe('document.getElementById("p").contentEditable', '"inherit"');
debug("FIXME: contentEditable attribute should be inherit if missing. https://bugs.webkit.org/show_bug.cgi?id=52056");
shouldBe('document.getElementById("p").isContentEditable', 'false');
shouldBe('window.getComputedStyle(p, "").getPropertyValue("-webkit-user-modify")', '"read-only"');
......
......@@ -7,8 +7,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
PASS document.getElementById("p").hasAttribute("contentEditable") is false
FAIL document.getElementById("p").contentEditable should be inherit. Was true.
FIXME: contentEditable attribute should be inherit if missing. https://bugs.webkit.org/show_bug.cgi?id=52056
PASS document.getElementById("p").contentEditable is "inherit"
PASS document.getElementById("p").isContentEditable is true
PASS window.getComputedStyle(p, "").getPropertyValue("-webkit-user-modify") is "read-write"
PASS successfullyParsed is true
......
......@@ -20,7 +20,6 @@ description('When contentEditable is missing, it maps to "inherit" state and the
shouldBe('document.getElementById("p").hasAttribute("contentEditable")','false');
shouldBe('document.getElementById("p").contentEditable', '"inherit"');
debug("FIXME: contentEditable attribute should be inherit if missing. https://bugs.webkit.org/show_bug.cgi?id=52056");
shouldBe('document.getElementById("p").isContentEditable', 'true');
shouldBe('window.getComputedStyle(p, "").getPropertyValue("-webkit-user-modify")', '"read-write"');
......
......@@ -7,8 +7,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
PASS document.getElementById("p").hasAttribute("contentEditable") is false
FAIL document.getElementById("p").contentEditable should be inherit. Was false.
FIXME: contentEditable attribute should be inherit if missing. https://bugs.webkit.org/show_bug.cgi?id=52056
PASS document.getElementById("p").contentEditable is "inherit"
PASS document.getElementById("p").isContentEditable is false
PASS window.getComputedStyle(p, "").getPropertyValue("-webkit-user-modify") is "read-only"
......
......@@ -19,7 +19,6 @@ description('When contentEditable is missing, it maps to "inherit" state and the
shouldBe('document.getElementById("p").hasAttribute("contentEditable")','false');
shouldBe('document.getElementById("p").contentEditable', '"inherit"');
debug("FIXME: contentEditable attribute should be inherit if missing. https://bugs.webkit.org/show_bug.cgi?id=52056");
shouldBe('document.getElementById("p").isContentEditable', 'false');
shouldBe('window.getComputedStyle(p, "").getPropertyValue("-webkit-user-modify")', '"read-only"');
......
......@@ -7,8 +7,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
PASS document.getElementById("p").hasAttribute("contentEditable") is false
FAIL document.getElementById("p").contentEditable should be inherit. Was false.
FIXME: contentEditable attribute should be inherit if missing. https://bugs.webkit.org/show_bug.cgi?id=52056
PASS document.getElementById("p").contentEditable is "inherit"
PASS document.getElementById("p").isContentEditable is false
PASS window.getComputedStyle(p, "").getPropertyValue("-webkit-user-modify") is "read-only"
......
......@@ -15,7 +15,6 @@ description('When contentEditable is missing, it maps to "inherit" state and the
shouldBe('document.getElementById("p").hasAttribute("contentEditable")','false');
shouldBe('document.getElementById("p").contentEditable', '"inherit"');
debug("FIXME: contentEditable attribute should be inherit if missing. https://bugs.webkit.org/show_bug.cgi?id=52056");
shouldBe('document.getElementById("p").isContentEditable', 'false');
shouldBe('window.getComputedStyle(p, "").getPropertyValue("-webkit-user-modify")', '"read-only"');
......
......@@ -7,8 +7,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
PASS document.getElementById("p").hasAttribute("contentEditable") is false
FAIL document.getElementById("p").contentEditable should be inherit. Was true.
FIXME: contentEditable attribute should be inherit if missing. https://bugs.webkit.org/show_bug.cgi?id=52056
PASS document.getElementById("p").contentEditable is "inherit"
PASS document.getElementById("p").isContentEditable is true
PASS window.getComputedStyle(p, "").getPropertyValue("-webkit-user-modify") is "read-write"
......
......@@ -15,7 +15,6 @@ description('When contentEditable is missing, it maps to "inherit" state and the
shouldBe('document.getElementById("p").hasAttribute("contentEditable")','false');
shouldBe('document.getElementById("p").contentEditable', '"inherit"');
debug("FIXME: contentEditable attribute should be inherit if missing. https://bugs.webkit.org/show_bug.cgi?id=52056");
shouldBe('document.getElementById("p").isContentEditable', 'true');
shouldBe('window.getComputedStyle(p, "").getPropertyValue("-webkit-user-modify")', '"read-write"');
......
......@@ -8,7 +8,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
PASS document.getElementById("div1").getAttribute("contentEditable") is "false"
FAIL document.getElementById("div1").contentEditable should be false. Was true.
PASS document.getElementById("div1").contentEditable is "false"
FAIL document.getElementById("div1").isContentEditable should be false. Was true.
FIXME: setContentEditable with true/false/inherit string is not working properly. https://bugs.webkit.org/show_bug.cgi?id=52058
PASS window.getComputedStyle(div1, "").getPropertyValue("-webkit-user-modify") is "read-only"
......
......@@ -7,7 +7,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
PASS document.getElementById("p").hasAttribute("contentEditable") is false
FAIL document.getElementById("p").contentEditable should be inherit. Was true.
PASS document.getElementById("p").contentEditable is "inherit"
FAIL document.getElementById("p").isContentEditable should be false. Was true.
FIXME: setContentEditable with true/false/inherit string is not working properly. https://bugs.webkit.org/show_bug.cgi?id=52058
PASS window.getComputedStyle(p, "").getPropertyValue("-webkit-user-modify") is "read-only"
......
......@@ -7,7 +7,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
PASS document.getElementById("p").hasAttribute("contentEditable") is false
FAIL document.getElementById("p").contentEditable should be inherit. Was false.
PASS document.getElementById("p").contentEditable is "inherit"
FAIL document.getElementById("p").isContentEditable should be true. Was false.
FIXME: setContentEditable with true/false/inherit string is not working properly. https://bugs.webkit.org/show_bug.cgi?id=52058
PASS window.getComputedStyle(p, "").getPropertyValue("-webkit-user-modify") is "read-write"
......
......@@ -9,7 +9,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
FAIL exceptionThrown should be true. Was false.
FIXME: setContentEditable with invalid string should throw exception. https://bugs.webkit.org/show_bug.cgi?id=52057
PASS document.getElementById("div").getAttribute("contentEditable") is "abc"
PASS document.getElementById("div").contentEditable is "true"
FAIL document.getElementById("div").contentEditable should be true. Was inherit.
PASS document.getElementById("div").isContentEditable is true
FAIL window.getComputedStyle(div, "").getPropertyValue("-webkit-user-modify") should be read-write. Was read-only.
......
......@@ -8,7 +8,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
PASS document.getElementById("div1").getAttribute("contentEditable") is "true"
FAIL document.getElementById("div1").contentEditable should be true. Was false.
PASS document.getElementById("div1").contentEditable is "true"
FAIL document.getElementById("div1").isContentEditable should be true. Was false.
FIXME: setContentEditable with true/false/inherit string is not working properly. https://bugs.webkit.org/show_bug.cgi?id=52058
PASS window.getComputedStyle(div1, "").getPropertyValue("-webkit-user-modify") is "read-write"
......
......@@ -9,7 +9,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
PASS document.getElementById("div1").getAttribute("contentEditable") is "TRue"
FAIL document.getElementById("div1").contentEditable should be true. Was false.
PASS document.getElementById("div1").contentEditable is "true"
FAIL document.getElementById("div1").isContentEditable should be true. Was false.
PASS window.getComputedStyle(div1, "").getPropertyValue("-webkit-user-modify") is "read-write"
PASS document.getElementById("p1").getAttribute("contentEditable") is "faLSE"
......@@ -17,7 +17,7 @@ PASS document.getElementById("p1").contentEditable is "false"
PASS document.getElementById("p1").isContentEditable is false
PASS window.getComputedStyle(p1, "").getPropertyValue("-webkit-user-modify") is "read-only"
FAIL document.getElementById("p2").hasAttribute("contentEditable") should be false. Was true.
FAIL document.getElementById("p2").contentEditable should be inherit. Was false.
PASS document.getElementById("p2").contentEditable is "inherit"
FAIL document.getElementById("p2").isContentEditable should be true. Was false.
FAIL window.getComputedStyle(p2, "").getPropertyValue("-webkit-user-modify") should be read-write. Was read-only.
FIXME: setContentEditable should be case insensitive. https://bugs.webkit.org/show_bug.cgi?id=52059
......
......@@ -11,7 +11,7 @@ TEST SUCCEEDED: The value was the empty string. [tested HTMLElement.dir]
TEST SUCCEEDED: The value was the empty string. [tested HTMLElement.className]
TEST SUCCEEDED: The value was the empty string. [tested HTMLElement.innerHTML]
TEST SUCCEEDED: The value was the empty string. [tested HTMLElement.innerText]
TEST SUCCEEDED: The value was the string 'false'. [tested HTMLElement.contentEditable]
TEST FAILED: The value should have been the string 'false' but was the string 'true'. [tested HTMLElement.contentEditable]
TEST SUCCEEDED: The value was the empty string. [tested HTMLAnchorElement.accessKey]
TEST SUCCEEDED: The value was the empty string. [tested HTMLAnchorElement.charset]
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment