Commit 60a29804 authored by commit-queue@webkit.org's avatar commit-queue@webkit.org
Browse files

[BlackBerry] Remove unused parameters from notifyAnimationStarted() and paintContents()

https://bugs.webkit.org/show_bug.cgi?id=114022

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05
Reviewed by Carlos Garcia Campos.

Naming the 'time' and 'inClip' unused parameters only produces
compiler warnings.

* Api/WebOverlay_p.h:
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
(WebOverlayPrivateWebKitThread):
* Api/WebPage_p.h:
(BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted):
(BlackBerry::WebKit::WebPagePrivate::paintContents):
* WebKitSupport/DefaultTapHighlight.h:
(BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):
* WebKitSupport/InspectorOverlayBlackBerry.cpp:
(BlackBerry::WebKit::InspectorOverlay::paintContents):
* WebKitSupport/InspectorOverlayBlackBerry.h:
(BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
(InspectorOverlay):
* WebKitSupport/SelectionOverlay.h:
(BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent d9a17e16
...@@ -166,9 +166,9 @@ public: ...@@ -166,9 +166,9 @@ public:
virtual WebCore::GraphicsLayer* graphicsLayer() const { return m_layer.get(); } virtual WebCore::GraphicsLayer* graphicsLayer() const { return m_layer.get(); }
// GraphicsLayerClient // GraphicsLayerClient
virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { } virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) { }
virtual void notifyFlushRequired(const WebCore::GraphicsLayer*); virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip); virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&);
private: private:
OwnPtr<WebCore::GraphicsLayer> m_layer; OwnPtr<WebCore::GraphicsLayer> m_layer;
......
...@@ -401,9 +401,9 @@ public: ...@@ -401,9 +401,9 @@ public:
WebCore::GraphicsLayer* overlayLayer(); WebCore::GraphicsLayer* overlayLayer();
// Fallback GraphicsLayerClient implementation, used for various overlay layers. // Fallback GraphicsLayerClient implementation, used for various overlay layers.
virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { } virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) { }
virtual void notifyFlushRequired(const WebCore::GraphicsLayer*); virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip) { } virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&) { }
// WebKit thread, plumbed through from ChromeClientBlackBerry. // WebKit thread, plumbed through from ChromeClientBlackBerry.
void setRootLayerWebKitThread(WebCore::Frame*, WebCore::LayerWebKitThread*); void setRootLayerWebKitThread(WebCore::Frame*, WebCore::LayerWebKitThread*);
......
2013-04-05 Alberto Garcia <agarcia@igalia.com>
[BlackBerry] Remove unused parameters from notifyAnimationStarted() and paintContents()
https://bugs.webkit.org/show_bug.cgi?id=114022
Reviewed by Carlos Garcia Campos.
Naming the 'time' and 'inClip' unused parameters only produces
compiler warnings.
* Api/WebOverlay_p.h:
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
(WebOverlayPrivateWebKitThread):
* Api/WebPage_p.h:
(BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted):
(BlackBerry::WebKit::WebPagePrivate::paintContents):
* WebKitSupport/DefaultTapHighlight.h:
(BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):
* WebKitSupport/InspectorOverlayBlackBerry.cpp:
(BlackBerry::WebKit::InspectorOverlay::paintContents):
* WebKitSupport/InspectorOverlayBlackBerry.h:
(BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
(InspectorOverlay):
* WebKitSupport/SelectionOverlay.h:
(BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):
2013-04-05 Alberto Garcia <agarcia@igalia.com> 2013-04-05 Alberto Garcia <agarcia@igalia.com>
   
[BlackBerry] WebOverlay: fix access to m_client [BlackBerry] WebOverlay: fix access to m_client
......
...@@ -54,7 +54,7 @@ public: ...@@ -54,7 +54,7 @@ public:
virtual bool shouldHideAfterScroll() const { return m_shouldHideAfterScroll; } virtual bool shouldHideAfterScroll() const { return m_shouldHideAfterScroll; }
// GraphicsLayerClient // GraphicsLayerClient
virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { } virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) { }
virtual void notifyFlushRequired(const WebCore::GraphicsLayer*); virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip); virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip);
......
...@@ -47,7 +47,7 @@ void InspectorOverlay::notifyFlushRequired(const WebCore::GraphicsLayer* layer) ...@@ -47,7 +47,7 @@ void InspectorOverlay::notifyFlushRequired(const WebCore::GraphicsLayer* layer)
m_webPage->notifyFlushRequired(layer); m_webPage->notifyFlushRequired(layer);
} }
void InspectorOverlay::paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext& context, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip) void InspectorOverlay::paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext& context, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&)
{ {
context.save(); context.save();
WebCore::IntPoint scrollPosition = m_webPage->focusedOrMainFrame()->view()->scrollPosition(); WebCore::IntPoint scrollPosition = m_webPage->focusedOrMainFrame()->view()->scrollPosition();
......
...@@ -51,9 +51,9 @@ public: ...@@ -51,9 +51,9 @@ public:
void paintWebFrame(WebCore::GraphicsContext&); void paintWebFrame(WebCore::GraphicsContext&);
#if USE(ACCELERATED_COMPOSITING) #if USE(ACCELERATED_COMPOSITING)
virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { } virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) { }
virtual void notifyFlushRequired(const WebCore::GraphicsLayer*); virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect& inClip); virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&);
#endif #endif
private: private:
......
...@@ -54,7 +54,7 @@ public: ...@@ -54,7 +54,7 @@ public:
void hide(); void hide();
// GraphicsLayerClient // GraphicsLayerClient
virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time) { } virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double) { }
virtual void notifyFlushRequired(const WebCore::GraphicsLayer*); virtual void notifyFlushRequired(const WebCore::GraphicsLayer*);
virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&); virtual void paintContents(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&, WebCore::GraphicsLayerPaintingPhase, const WebCore::IntRect&);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment