Commit 5fb5bb12 authored by podivilov@chromium.org's avatar podivilov@chromium.org
Browse files

2011-01-27 Pavel Podivilov <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
        https://bugs.webkit.org/show_bug.cgi?id=53234

        * inspector/debugger-expand-scope.html:
        * inspector/debugger-proto-property.html:
2011-01-27  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
        https://bugs.webkit.org/show_bug.cgi?id=53234

        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane):
        (WebInspector.ScopeChainSidebarPane.prototype.update):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent e2b7e653
2011-01-27 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
https://bugs.webkit.org/show_bug.cgi?id=53234
* inspector/debugger-expand-scope.html:
* inspector/debugger-proto-property.html:
2011-01-27 Philippe Normand <pnormand@igalia.com> 2011-01-27 Philippe Normand <pnormand@igalia.com>
   
Unreviewed, fix typo introduced in r76783. Unreviewed, fix typo introduced in r76783.
...@@ -35,7 +35,7 @@ function test() ...@@ -35,7 +35,7 @@ function test()
{ {
// Expand all but global scopes. Expanding global scope takes for too long // Expand all but global scopes. Expanding global scope takes for too long
// so we keep it collapsed. // so we keep it collapsed.
var sections = WebInspector.currentPanel.sidebarPanes.scopechain.sections; var sections = WebInspector.currentPanel.sidebarPanes.scopechain._sections;
// global scope is always the last one. // global scope is always the last one.
for (var i = 0; i < sections.length - 1; i++) for (var i = 0; i < sections.length - 1; i++)
sections[i].expand(); sections[i].expand();
...@@ -44,7 +44,7 @@ function test() ...@@ -44,7 +44,7 @@ function test()
function step3() function step3()
{ {
var sections = WebInspector.currentPanel.sidebarPanes.scopechain.sections; var sections = WebInspector.currentPanel.sidebarPanes.scopechain._sections;
InspectorTest.addResult(""); InspectorTest.addResult("");
InspectorTest.addResult("Dump scope sections:"); InspectorTest.addResult("Dump scope sections:");
for (var i = 0; i < sections.length; i++) { for (var i = 0; i < sections.length; i++) {
......
...@@ -30,7 +30,7 @@ var test = function() ...@@ -30,7 +30,7 @@ var test = function()
function step2(callFrames) function step2(callFrames)
{ {
var sections = WebInspector.currentPanel.sidebarPanes.scopechain.sections; var sections = WebInspector.currentPanel.sidebarPanes.scopechain._sections;
var localScope = sections[0].propertiesTreeOutline; var localScope = sections[0].propertiesTreeOutline;
var properties = [ var properties = [
localScope, ["o", "__proto__", "__proto__"], localScope, ["o", "__proto__", "__proto__"],
......
2011-01-27 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
https://bugs.webkit.org/show_bug.cgi?id=53234
* inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane):
(WebInspector.ScopeChainSidebarPane.prototype.update):
2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com> 2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>
   
Unreviewed, rolling out r76789. Unreviewed, rolling out r76789.
...@@ -26,6 +26,8 @@ ...@@ -26,6 +26,8 @@
WebInspector.ScopeChainSidebarPane = function() WebInspector.ScopeChainSidebarPane = function()
{ {
WebInspector.SidebarPane.call(this, WebInspector.UIString("Scope Variables")); WebInspector.SidebarPane.call(this, WebInspector.UIString("Scope Variables"));
this._sections = [];
this._expandedSections = {};
this._expandedProperties = []; this._expandedProperties = [];
} }
...@@ -34,9 +36,6 @@ WebInspector.ScopeChainSidebarPane.prototype = { ...@@ -34,9 +36,6 @@ WebInspector.ScopeChainSidebarPane.prototype = {
{ {
this.bodyElement.removeChildren(); this.bodyElement.removeChildren();
this.sections = [];
this.callFrame = callFrame;
if (!callFrame) { if (!callFrame) {
var infoElement = document.createElement("div"); var infoElement = document.createElement("div");
infoElement.className = "info"; infoElement.className = "info";
...@@ -45,6 +44,18 @@ WebInspector.ScopeChainSidebarPane.prototype = { ...@@ -45,6 +44,18 @@ WebInspector.ScopeChainSidebarPane.prototype = {
return; return;
} }
for (var i = 0; i < this._sections.length; ++i) {
var section = this._sections[i];
if (!section.title)
continue;
if (section.expanded)
this._expandedSections[section.title] = true;
else
delete this._expandedSections[section.title];
}
this._sections = [];
var foundLocalScope = false; var foundLocalScope = false;
var scopeChain = callFrame.scopeChain; var scopeChain = callFrame.scopeChain;
for (var i = 0; i < scopeChain.length; ++i) { for (var i = 0; i < scopeChain.length; ++i) {
...@@ -81,10 +92,10 @@ WebInspector.ScopeChainSidebarPane.prototype = { ...@@ -81,10 +92,10 @@ WebInspector.ScopeChainSidebarPane.prototype = {
section.editInSelectedCallFrameWhenPaused = true; section.editInSelectedCallFrameWhenPaused = true;
section.pane = this; section.pane = this;
if (!foundLocalScope || scopeObjectProxy.isLocal) if (!foundLocalScope || scopeObjectProxy.isLocal || title in this._expandedSections)
section.expanded = true; section.expanded = true;
this.sections.push(section); this._sections.push(section);
this.bodyElement.appendChild(section.element); this.bodyElement.appendChild(section.element);
} }
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment