Commit 5ee8b596 authored by hyatt's avatar hyatt
Browse files

Fix spinner.com mislayout on the PLT. Make sure

	<input type=image> honors the width attribute and
	make sure that its render object calls updateFromElement.

        * khtml/html/html_formimpl.cpp:
        (HTMLInputElementImpl::parseAttribute):
        (HTMLInputElementImpl::attach):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent d4a14ac7
2002-11-14 David Hyatt <hyatt@apple.com>
Fix spinner.com mislayout on the PLT. Make sure
<input type=image> honors the width attribute and
make sure that its render object calls updateFromElement.
* khtml/html/html_formimpl.cpp:
(HTMLInputElementImpl::parseAttribute):
(HTMLInputElementImpl::attach):
2002-11-14 David Hyatt <hyatt@apple.com>
 
Move text measurement and layout beyond onload. This
......
2002-11-14 David Hyatt <hyatt@apple.com>
Fix spinner.com mislayout on the PLT. Make sure
<input type=image> honors the width attribute and
make sure that its render object calls updateFromElement.
* khtml/html/html_formimpl.cpp:
(HTMLInputElementImpl::parseAttribute):
(HTMLInputElementImpl::attach):
2002-11-14 David Hyatt <hyatt@apple.com>
 
Move text measurement and layout beyond onload. This
......
2002-11-14 David Hyatt <hyatt@apple.com>
Fix spinner.com mislayout on the PLT. Make sure
<input type=image> honors the width attribute and
make sure that its render object calls updateFromElement.
* khtml/html/html_formimpl.cpp:
(HTMLInputElementImpl::parseAttribute):
(HTMLInputElementImpl::attach):
2002-11-14 David Hyatt <hyatt@apple.com>
 
Move text measurement and layout beyond onload. This
......
......@@ -1003,7 +1003,8 @@ void HTMLInputElementImpl::parseAttribute(AttributeImpl *attr)
break;
case ATTR_WIDTH:
// ignore this attribute, do _not_ add
// a CSS_PROP_WIDTH here!
// a CSS_PROP_WIDTH here (we will honor this attribute for input type=image
// in the attach call)!
// webdesigner are stupid - and IE/NS behave the same ( Dirk )
break;
case ATTR_HEIGHT:
......@@ -1086,7 +1087,20 @@ void HTMLInputElementImpl::attach()
case CHECKBOX: m_render = new (arena) RenderCheckBox(this); break;
case RADIO: m_render = new (arena) RenderRadioButton(this); break;
case SUBMIT: m_render = new (arena) RenderSubmitButton(this); break;
case IMAGE: m_render = new (arena) RenderImageButton(this); break;
case IMAGE: {
DOMString width = getAttribute( ATTR_WIDTH );
if (!width.isEmpty()) {
printf("Added prop.\n");
addCSSLength(CSS_PROP_WIDTH, width);
}
m_render = new (arena) RenderImageButton(this);
m_render->setStyle(getDocument()->styleSelector()->styleForElement(this));
parentNode()->renderer()->addChild(m_render, nextRenderer());
m_render->updateFromElement();
NodeBaseImpl::attach();
_style->deref();
return;
}
case RESET: m_render = new (arena) RenderResetButton(this); break;
case FILE: m_render = new (arena) RenderFileButton(this); break;
case BUTTON: m_render = new (arena) RenderPushButton(this);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment