Commit 5ddfb04e authored by jamesr@google.com's avatar jamesr@google.com
Browse files

2011-01-20 James Robinson <jamesr@chromium.org>

        Reviewed by Eric Seidel.

        RenderTableSection's setNeedsCellRecalc needs to null check table()
        https://bugs.webkit.org/show_bug.cgi?id=52770

        Tests ::-webkit-scrollbar-corner inside a table.

        * fast/css-generated-content/table-with-scrollbar-corner-expected.txt: Added.
        * fast/css-generated-content/table-with-scrollbar-corner.html: Added.
2011-01-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Eric "Baller" Seidel.

        RenderTableSection's setNeedsCellRecalc needs to null check table()
        https://bugs.webkit.org/show_bug.cgi?id=52770

        Null checks table() before deferencing it in RenderTableSection::setNeedsCellRecalc.
        This can be null during detach().  Test constructed by Eric Seidel.

        Test: fast/css-generated-content/table-with-scrollbar-corner.html

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::setNeedsCellRecalc):
        * rendering/RenderTableSection.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 633f239b
2011-01-20 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
RenderTableSection's setNeedsCellRecalc needs to null check table()
https://bugs.webkit.org/show_bug.cgi?id=52770
Tests ::-webkit-scrollbar-corner inside a table.
* fast/css-generated-content/table-with-scrollbar-corner-expected.txt: Added.
* fast/css-generated-content/table-with-scrollbar-corner.html: Added.
2011-01-20 Michael Saboff <msaboff@apple.com>
 
Reviewed by Oliver Hunt.
......
<!DOCTYPE html>
<style>
::-webkit-scrollbar-corner { zoom: reset; }
* {overflow:hidden}
</style>
<table><tr>
<script>
if (window.layoutTestController)
layoutTestController.dumpAsText();
document.body.innerHTML = "PASS, no crash";
</script>
2011-01-20 James Robinson <jamesr@chromium.org>
Reviewed by Eric "Baller" Seidel.
RenderTableSection's setNeedsCellRecalc needs to null check table()
https://bugs.webkit.org/show_bug.cgi?id=52770
Null checks table() before deferencing it in RenderTableSection::setNeedsCellRecalc.
This can be null during detach(). Test constructed by Eric Seidel.
Test: fast/css-generated-content/table-with-scrollbar-corner.html
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::setNeedsCellRecalc):
* rendering/RenderTableSection.h:
2011-01-20 Dirk Schulze <krit@webkit.org>
 
Reviewed by Rob Buis.
......@@ -1083,6 +1083,13 @@ void RenderTableSection::recalcCells()
setNeedsLayout(true);
}
void RenderTableSection::setNeedsCellRecalc()
{
m_needsCellRecalc = true;
if (RenderTable* t = table())
t->setNeedsSectionRecalc();
}
void RenderTableSection::clearGrid()
{
int rows = m_gridRows;
......
......@@ -114,11 +114,7 @@ public:
}
bool needsCellRecalc() const { return m_needsCellRecalc; }
void setNeedsCellRecalc()
{
m_needsCellRecalc = true;
table()->setNeedsSectionRecalc();
}
void setNeedsCellRecalc();
int getBaseline(int row) { return m_grid[row].baseline; }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment