From 5cbef674479c5c36689c9b8953ed1dddd5f4f714 Mon Sep 17 00:00:00 2001 From: "cwzwarich@webkit.org" Date: Sun, 15 Jun 2008 05:31:13 +0000 Subject: [PATCH] 2008-06-14 Cameron Zwarich Reviewed by Darin. Remove redundant uses of get(). * kjs/nodes.cpp: (KJS::BracketAccessorNode::emitCode): (KJS::AddNode::emitCode): (KJS::SubNode::emitCode): (KJS::ReadModifyResolveNode::emitCode): (KJS::AssignDotNode::emitCode): (KJS::ReadModifyDotNode::emitCode): (KJS::AssignBracketNode::emitCode): (KJS::ReadModifyBracketNode::emitCode): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34556 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- JavaScriptCore/ChangeLog | 16 ++++++++++++++++ JavaScriptCore/kjs/nodes.cpp | 20 ++++++++++---------- 2 files changed, 26 insertions(+), 10 deletions(-) diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog index f59b4a92ed8..0cf3731b801 100644 --- a/JavaScriptCore/ChangeLog +++ b/JavaScriptCore/ChangeLog @@ -1,3 +1,19 @@ +2008-06-14 Cameron Zwarich + + Reviewed by Darin. + + Remove redundant uses of get(). + + * kjs/nodes.cpp: + (KJS::BracketAccessorNode::emitCode): + (KJS::AddNode::emitCode): + (KJS::SubNode::emitCode): + (KJS::ReadModifyResolveNode::emitCode): + (KJS::AssignDotNode::emitCode): + (KJS::ReadModifyDotNode::emitCode): + (KJS::AssignBracketNode::emitCode): + (KJS::ReadModifyBracketNode::emitCode): + 2008-06-14 Cameron Zwarich Reviewed by Maciej. diff --git a/JavaScriptCore/kjs/nodes.cpp b/JavaScriptCore/kjs/nodes.cpp index 3729ecd0edd..57b10e90b00 100644 --- a/JavaScriptCore/kjs/nodes.cpp +++ b/JavaScriptCore/kjs/nodes.cpp @@ -407,7 +407,7 @@ RegisterID* PropertyListNode::emitCode(CodeGenerator& generator, RegisterID* dst RegisterID* BracketAccessorNode::emitCode(CodeGenerator& generator, RegisterID* dst) { - RefPtr base = generator.emitNodeForLeftHandSide(m_base.get(), m_subscriptHasAssignments, m_subscript.get()->isPure(generator)); + RefPtr base = generator.emitNodeForLeftHandSide(m_base.get(), m_subscriptHasAssignments, m_subscript->isPure(generator)); RegisterID* property = generator.emitNode(m_subscript.get()); return generator.emitGetByVal(generator.finalDestination(dst), base.get(), property); @@ -828,14 +828,14 @@ RegisterID* ModNode::emitCode(CodeGenerator& generator, RegisterID* dst) RegisterID* AddNode::emitCode(CodeGenerator& generator, RegisterID* dst) { - RefPtr src1 = generator.emitNodeForLeftHandSide(m_term1.get(), m_rightHasAssignments, m_term2.get()->isPure(generator)); + RefPtr src1 = generator.emitNodeForLeftHandSide(m_term1.get(), m_rightHasAssignments, m_term2->isPure(generator)); RegisterID* src2 = generator.emitNode(m_term2.get()); return generator.emitAdd(generator.finalDestination(dst, src1.get()), src1.get(), src2); } RegisterID* SubNode::emitCode(CodeGenerator& generator, RegisterID* dst) { - RefPtr src1 = generator.emitNodeForLeftHandSide(m_term1.get(), m_rightHasAssignments, m_term2.get()->isPure(generator)); + RefPtr src1 = generator.emitNodeForLeftHandSide(m_term1.get(), m_rightHasAssignments, m_term2->isPure(generator)); RegisterID* src2 = generator.emitNode(m_term2.get()); return generator.emitSub(generator.finalDestination(dst, src1.get()), src1.get(), src2); } @@ -1053,7 +1053,7 @@ RegisterID* ReadModifyResolveNode::emitCode(CodeGenerator& generator, RegisterID return emitReadModifyAssignment(generator, generator.finalDestination(dst), local, src2, m_operator); } - if (generator.leftHandSideNeedsCopy(m_rightHasAssignments, m_right.get()->isPure(generator))) { + if (generator.leftHandSideNeedsCopy(m_rightHasAssignments, m_right->isPure(generator))) { RefPtr result = generator.newTemporary(); generator.emitMove(result.get(), local); RegisterID* src2 = generator.emitNode(m_right.get()); @@ -1113,7 +1113,7 @@ RegisterID* AssignResolveNode::emitCode(CodeGenerator& generator, RegisterID* ds RegisterID* AssignDotNode::emitCode(CodeGenerator& generator, RegisterID* dst) { - RefPtr base = generator.emitNodeForLeftHandSide(m_base.get(), m_rightHasAssignments, m_right.get()->isPure(generator)); + RefPtr base = generator.emitNodeForLeftHandSide(m_base.get(), m_rightHasAssignments, m_right->isPure(generator)); RefPtr value = generator.destinationForAssignResult(dst); RegisterID* result = generator.emitNode(value.get(), m_right.get()); generator.emitPutById(base.get(), m_ident, result); @@ -1124,7 +1124,7 @@ RegisterID* AssignDotNode::emitCode(CodeGenerator& generator, RegisterID* dst) RegisterID* ReadModifyDotNode::emitCode(CodeGenerator& generator, RegisterID* dst) { - RefPtr base = generator.emitNodeForLeftHandSide(m_base.get(), m_rightHasAssignments, m_right.get()->isPure(generator)); + RefPtr base = generator.emitNodeForLeftHandSide(m_base.get(), m_rightHasAssignments, m_right->isPure(generator)); RefPtr value = generator.emitGetById(generator.tempDestination(dst), base.get(), m_ident); RegisterID* change = generator.emitNode(m_right.get()); RegisterID* updatedValue = emitReadModifyAssignment(generator, generator.finalDestination(dst, value.get()), value.get(), change, m_operator); @@ -1142,8 +1142,8 @@ RegisterID* AssignErrorNode::emitCode(CodeGenerator& generator, RegisterID*) RegisterID* AssignBracketNode::emitCode(CodeGenerator& generator, RegisterID* dst) { - RefPtr base = generator.emitNodeForLeftHandSide(m_base.get(), m_subscriptHasAssignments || m_rightHasAssignments, m_subscript.get()->isPure(generator) && m_right.get()->isPure(generator)); - RefPtr property = generator.emitNodeForLeftHandSide(m_subscript.get(), m_rightHasAssignments, m_right.get()->isPure(generator)); + RefPtr base = generator.emitNodeForLeftHandSide(m_base.get(), m_subscriptHasAssignments || m_rightHasAssignments, m_subscript->isPure(generator) && m_right->isPure(generator)); + RefPtr property = generator.emitNodeForLeftHandSide(m_subscript.get(), m_rightHasAssignments, m_right->isPure(generator)); RefPtr value = generator.destinationForAssignResult(dst); RegisterID* result = generator.emitNode(value.get(), m_right.get()); generator.emitPutByVal(base.get(), property.get(), result); @@ -1152,8 +1152,8 @@ RegisterID* AssignBracketNode::emitCode(CodeGenerator& generator, RegisterID* ds RegisterID* ReadModifyBracketNode::emitCode(CodeGenerator& generator, RegisterID* dst) { - RefPtr base = generator.emitNodeForLeftHandSide(m_base.get(), m_subscriptHasAssignments || m_rightHasAssignments, m_subscript.get()->isPure(generator) && m_right.get()->isPure(generator)); - RefPtr property = generator.emitNodeForLeftHandSide(m_subscript.get(), m_rightHasAssignments, m_right.get()->isPure(generator)); + RefPtr base = generator.emitNodeForLeftHandSide(m_base.get(), m_subscriptHasAssignments || m_rightHasAssignments, m_subscript->isPure(generator) && m_right->isPure(generator)); + RefPtr property = generator.emitNodeForLeftHandSide(m_subscript.get(), m_rightHasAssignments, m_right->isPure(generator)); RefPtr value = generator.emitGetByVal(generator.tempDestination(dst), base.get(), property.get()); RegisterID* change = generator.emitNode(m_right.get()); -- GitLab