Commit 5c7a4b23 authored by timothy@apple.com's avatar timothy@apple.com

Adds info text to panes and sections in the Inspector's sidebars

that would normally be empty. These help the user know why there
is nothing in these sections.

Reviewed by John Sullivan.

* English.lproj/localizedStrings.js: Add strings.
* page/inspector/BreakpointsSidebarPane.js: Adds "No Breakpoints".
* page/inspector/CallStackSidebarPane.js: Adds "Not Paused".
* page/inspector/ObjectPropertiesSection.js: Adds "No Properties".
* page/inspector/ScopeChainSidebarPane.js: Adds "Not Paused".
* page/inspector/inspector.css: Adds style rules for the info elements.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 55a36e48
2008-05-13 Timothy Hatcher <timothy@apple.com>
Adds info text to panes and sections in the Inspector's sidebars
that would normally be empty. These help the user know why there
is nothing in these sections.
Reviewed by John Sullivan.
* English.lproj/localizedStrings.js: Add strings.
* page/inspector/BreakpointsSidebarPane.js: Adds "No Breakpoints".
* page/inspector/CallStackSidebarPane.js: Adds "Not Paused".
* page/inspector/ObjectPropertiesSection.js: Adds "No Properties".
* page/inspector/ScopeChainSidebarPane.js: Adds "Not Paused".
* page/inspector/inspector.css: Adds style rules for the info elements.
2008-05-13 Timothy Hatcher <timothy@apple.com>
Implements the rest of the Scripts panel to get the debugger
Bvar localizedStrings = new Object;
......
......@@ -28,6 +28,12 @@ WebInspector.BreakpointsSidebarPane = function()
WebInspector.SidebarPane.call(this, WebInspector.UIString("Breakpoints"));
this.breakpoints = [];
this.emptyElement = document.createElement("div");
this.emptyElement.className = "info";
this.emptyElement.textContent = WebInspector.UIString("No Breakpoints");
this.bodyElement.appendChild(this.emptyElement);
}
WebInspector.BreakpointsSidebarPane.prototype = {
......
......@@ -36,8 +36,13 @@ WebInspector.CallStackSidebarPane.prototype = {
this.placards = [];
delete this._selectedCallFrame;
if (!callFrame)
if (!callFrame) {
var infoElement = document.createElement("div");
infoElement.className = "info";
infoElement.textContent = WebInspector.UIString("Not Paused");
this.bodyElement.appendChild(infoElement);
return;
}
do {
var title = callFrame.functionName;
......
......@@ -49,6 +49,12 @@ WebInspector.ObjectPropertiesSection.prototype = {
continue;
this.propertiesTreeOutline.appendChild(new WebInspector.ObjectPropertyTreeElement(this.object, propertyName));
}
if (!this.propertiesTreeOutline.children.length) {
var title = "<div class=\"info\">" + WebInspector.UIString("No Properties") + "</div>";
var infoElement = new TreeElement(title, null, false);
this.propertiesTreeOutline.appendChild(infoElement);
}
}
}
......
......@@ -35,8 +35,13 @@ WebInspector.ScopeChainSidebarPane.prototype = {
this.sections = [];
if (!callFrame)
if (!callFrame) {
var infoElement = document.createElement("div");
infoElement.className = "info";
infoElement.textContent = WebInspector.UIString("Not Paused");
this.bodyElement.appendChild(infoElement);
return;
}
var foundLocalScope = false;
var scopeChain = callFrame.scopeChain;
......
......@@ -1005,6 +1005,11 @@ body.inactive .placard.selected {
margin-top: 1px;
}
.section .properties li .info {
padding-top: 4px;
padding-bottom: 3px;
}
.editing {
-webkit-user-select: text;
-webkit-box-shadow: rgba(0, 0, 0, .5) 3px 3px 4px;
......@@ -1124,6 +1129,14 @@ body.inactive .placard.selected {
overflow-x: hidden;
}
.pane > .body .info {
text-align: center;
font-style: italic;
font-size: 10px;
padding: 6px;
color: gray;
}
.pane.expanded > .body, .pane.expanded > .growbar {
display: block;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment