Commit 5bffb145 authored by brettw@chromium.org's avatar brettw@chromium.org

2011-05-13 Brett Wilson <brettw@chromium.org>

        Reviewed by Adam Barth.

        Don't destroy a null FcPattern when failing to do a FontConfig match.
        This crashes, and there's nothing FcDestroy could do with a null
        pointer even if it didn't crash.
        https://bugs.webkit.org/show_bug.cgi?id=60777

        * src/gtk/WebFontInfo.cpp:
        (WebKit::WebFontInfo::renderStyleForStrike):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 0e9846f4
2011-05-13 Brett Wilson <brettw@chromium.org>
Reviewed by Adam Barth.
Don't destroy a null FcPattern when failing to do a FontConfig match.
This crashes, and there's nothing FcDestroy could do with a null
pointer even if it didn't crash.
https://bugs.webkit.org/show_bug.cgi?id=60777
* src/gtk/WebFontInfo.cpp:
(WebKit::WebFontInfo::renderStyleForStrike):
2011-05-11 Hans Wennborg <hans@chromium.org>
Reviewed by Tony Gentilcore.
......
......@@ -154,10 +154,8 @@ void WebFontInfo::renderStyleForStrike(const char* family, int sizeAndStyle, Web
out->setDefaults();
if (!match) {
FcPatternDestroy(match);
if (!match)
return;
}
FcBool b;
int i;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment