Commit 5af6e16d authored by mario@webkit.org's avatar mario@webkit.org
Browse files

2011-01-25 Mario Sanchez Prada <msanchez@igalia.com>

        Reviewed by Antonio Gomes.

        fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=53073

        Make the two steps in the flaky test to be executed sequentially.

        * fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:
        Fix flaky test by chaining its two steps up.
        * platform/gtk/Skipped: Unskip test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent dde95236
2011-01-25 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Antonio Gomes.
fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53073
Make the two steps in the flaky test to be executed sequentially.
* fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:
Fix flaky test by chaining its two steps up.
* platform/gtk/Skipped: Unskip test.
2011-01-25 Dirk Schulze <krit@webkit.org>
 
Reviewed by Nikolas Zimmermann.
......
......@@ -31,7 +31,7 @@
var resultMap1 = [
["Down", "start"],
["", ""]
["DONE", "DONE"]
];
var resultMap2 = [
......@@ -52,7 +52,6 @@
document.getElementById("start").focus();
setTimeout(step1 , 0);
setTimeout(step2 , 50);
}
function step1()
......@@ -60,7 +59,7 @@
// Actions in 'resultMap1' should keep the focus in the currently
// focused element ('start') once the best candidate ('end') is not
// visible in current viewport.
initTest(resultMap1);
initTest(resultMap1, step1Completed);
}
function step2()
......@@ -72,10 +71,15 @@
eventSender.keyDown("end");
// And 'resultMap2' re-tries to move focus down.
initTest(resultMap2, testCompleted);
initTest(resultMap2, step2Completed);
}
function step1Completed()
{
setTimeout(step2 , 0);
}
function testCompleted()
function step2Completed()
{
if (window.layoutTestController)
layoutTestController.notifyDone();
......
......@@ -5270,9 +5270,6 @@ fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Con
# https://bugs.webkit.org/show_bug.cgi?id=38437
editing/pasteboard/5761530-1.html
# flaky test (see https://bugs.webkit.org/show_bug.cgi?id=53073)
fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html
# Speech input is not yet enabled.
fast/speech
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment