Commit 5ad13296 authored by philn@webkit.org's avatar philn@webkit.org

2010-12-08 Philippe Normand <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] media/fullscreen* failing on 64-bits Debug
        https://bugs.webkit.org/show_bug.cgi?id=50394

        Avoid emiting durationchanged in the case where the previous
        duration was 0 because that case is already handled by the
        HTMLMediaElement.

        Test: media/media-fullscreen*.html

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::durationChanged):

LayoutTests:

        Reviewed by Gustavo Noronha Silva.

        [GTK] media/fullscreen* failing on 64-bits Debug
        https://bugs.webkit.org/show_bug.cgi?id=50394

        * platform/gtk/Skipped: Unskip now passing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent e5324133
2010-12-08 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] media/fullscreen* failing on 64-bits Debug
https://bugs.webkit.org/show_bug.cgi?id=50394
* platform/gtk/Skipped: Unskip now passing tests.
2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Remove WIN prefix for inspector's tests expectations.
......
......@@ -5140,10 +5140,6 @@ editing/selection/5354455-1.html
editing/selection/5354455-2.html
media/controls-right-click-on-timebar.html
# https://bugs.webkit.org/show_bug.cgi?id=50394
media/media-fullscreen-inline.html
media/media-fullscreen-not-in-document.html
# Gtk doesn't implement dumpResourceResponseMIMETypes which is required for the
# preloader tests.
fast/preloader
......
2010-12-08 Philippe Normand <pnormand@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] media/fullscreen* failing on 64-bits Debug
https://bugs.webkit.org/show_bug.cgi?id=50394
Avoid emiting durationchanged in the case where the previous
duration was 0 because that case is already handled by the
HTMLMediaElement.
Test: media/media-fullscreen*.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::durationChanged):
2010-12-07 Darin Adler <darin@apple.com>
Reviewed by Geoffrey Garen.
......
......@@ -1255,8 +1255,10 @@ void MediaPlayerPrivateGStreamer::durationChanged()
float previousDuration = m_mediaDuration;
cacheDuration();
if (m_mediaDuration != previousDuration)
// Avoid emiting durationchanged in the case where the previous
// duration was 0 because that case is already handled by the
// HTMLMediaElement.
if (previousDuration && m_mediaDuration != previousDuration)
m_player->durationChanged();
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment