Commit 5a0981dc authored by haraken@chromium.org's avatar haraken@chromium.org

Rename [JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor]

https://bugs.webkit.org/show_bug.cgi?id=78352

Reviewed by Adam Barth.

[JSCustomGetOwnPropertySlotDelegate] is used for "flexibly customizable"
named getter. It allows us to write custom code for getOwnPropertySlotDelegate()
and getOwnPropertyDescriptorDelegate(). To clarify that, we can rename
[JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):

* html/HTMLAppletElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLObjectElement.idl:
* page/History.idl:
* page/Location.idl:
* workers/WorkerContext.idl:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent ce6cdfcd
2012-02-10 Kentaro Hara <haraken@chromium.org>
Rename [JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor]
https://bugs.webkit.org/show_bug.cgi?id=78352
Reviewed by Adam Barth.
[JSCustomGetOwnPropertySlotDelegate] is used for "flexibly customizable"
named getter. It allows us to write custom code for getOwnPropertySlotDelegate()
and getOwnPropertyDescriptorDelegate(). To clarify that, we can rename
[JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor].
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
* html/HTMLAppletElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLObjectElement.idl:
* page/History.idl:
* page/Location.idl:
* workers/WorkerContext.idl:
2012-02-10 Anders Carlsson <andersca@apple.com>
Minor ScrollAnimatorMac cleanup
......@@ -469,7 +469,7 @@ sub GenerateGetOwnPropertySlotBody
&$manualLookupGetterGeneration();
}
if ($dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"}) {
if ($dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"}) {
push(@getOwnPropertySlotImpl, " if (thisObject->getOwnPropertySlotDelegate(exec, propertyName, slot))\n");
push(@getOwnPropertySlotImpl, " return true;\n");
}
......@@ -570,7 +570,7 @@ sub GenerateGetOwnPropertyDescriptorBody
&$manualLookupGetterGeneration();
}
if ($dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"}) {
if ($dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"}) {
push(@getOwnPropertyDescriptorImpl, " if (thisObject->getOwnPropertyDescriptorDelegate(exec, propertyName, descriptor))\n");
push(@getOwnPropertyDescriptorImpl, " return true;\n");
}
......@@ -758,7 +758,7 @@ sub GenerateHeader
|| $dataNode->extendedAttributes->{"IndexedGetter"}
|| $dataNode->extendedAttributes->{"NumericIndexedGetter"}
|| $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"}
|| $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"}
|| $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"}
|| $dataNode->extendedAttributes->{"NamedGetter"}
|| $dataNode->extendedAttributes->{"CustomNamedGetter"};
......@@ -767,8 +767,8 @@ sub GenerateHeader
push(@headerContent, " static bool getOwnPropertySlot(JSC::JSCell*, JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);\n");
push(@headerContent, " static bool getOwnPropertyDescriptor(JSC::JSObject*, JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertyDescriptor&);\n");
push(@headerContent, " static bool getOwnPropertySlotByIndex(JSC::JSCell*, JSC::ExecState*, unsigned propertyName, JSC::PropertySlot&);\n") if ($dataNode->extendedAttributes->{"IndexedGetter"} || $dataNode->extendedAttributes->{"NumericIndexedGetter"}) && !$dataNode->extendedAttributes->{"CustomNamedGetter"};
push(@headerContent, " bool getOwnPropertySlotDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);\n") if $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"};
push(@headerContent, " bool getOwnPropertyDescriptorDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertyDescriptor&);\n") if $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"};
push(@headerContent, " bool getOwnPropertySlotDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);\n") if $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"};
push(@headerContent, " bool getOwnPropertyDescriptorDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertyDescriptor&);\n") if $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"};
$structureFlags{"JSC::OverridesGetOwnPropertySlot"} = 1;
}
......@@ -1623,7 +1623,7 @@ sub GenerateImplementation
|| !$dataNode->extendedAttributes->{"OmitConstructor"}
|| $dataNode->extendedAttributes->{"IndexedGetter"}
|| $dataNode->extendedAttributes->{"NumericIndexedGetter"}
|| $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"}
|| $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"}
|| $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"}
|| $dataNode->extendedAttributes->{"NamedGetter"}
|| $dataNode->extendedAttributes->{"CustomNamedGetter"};
......
......@@ -22,7 +22,7 @@ module html {
interface [
CustomNamedSetter,
JSCustomGetOwnPropertySlotDelegate,
JSCustomGetOwnPropertySlotAndDescriptor,
CustomCall
] HTMLAppletElement : HTMLElement {
attribute [Reflect] DOMString align;
......
......@@ -22,7 +22,7 @@ module html {
interface [
CustomNamedSetter,
JSCustomGetOwnPropertySlotDelegate,
JSCustomGetOwnPropertySlotAndDescriptor,
CustomCall
] HTMLEmbedElement : HTMLElement {
attribute [Reflect] DOMString align;
......
......@@ -22,7 +22,7 @@ module html {
interface [
CustomNamedSetter,
JSCustomGetOwnPropertySlotDelegate,
JSCustomGetOwnPropertySlotAndDescriptor,
CustomCall
] HTMLObjectElement : HTMLElement {
readonly attribute HTMLFormElement form;
......
......@@ -29,7 +29,7 @@ module window {
#if defined(V8_BINDING) && V8_BINDING
CheckDomainSecurity,
#endif
JSCustomGetOwnPropertySlotDelegate,
JSCustomGetOwnPropertySlotAndDescriptor,
CustomNamedSetter,
JSGenerateIsReachable=ImplFrame,
CustomDeleteProperty,
......
......@@ -32,7 +32,7 @@ module window {
#if defined(V8_BINDING) && V8_BINDING
CheckDomainSecurity,
#endif
JSCustomGetOwnPropertySlotDelegate,
JSCustomGetOwnPropertySlotAndDescriptor,
CustomNamedSetter,
JSGenerateIsReachable=ImplFrame,
CustomDeleteProperty,
......
......@@ -29,7 +29,7 @@ module threads {
interface [
Conditional=WORKERS,
JSCustomMarkFunction,
JSCustomGetOwnPropertySlotDelegate,
JSCustomGetOwnPropertySlotAndDescriptor,
EventTarget,
ExtendsDOMGlobalObject,
IsWorkerContext,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment