Commit 585b903f authored by joepeck@webkit.org's avatar joepeck@webkit.org

Run clang-modernize and let it add a bunch of missing overrides in WebCore/inspector

https://bugs.webkit.org/show_bug.cgi?id=127206

Reviewed by Anders Carlsson.

Let clang-modernize add overrides.

* inspector/DOMEditor.cpp:
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorCSSAgent.h:
* inspector/InspectorCanvasAgent.h:
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMDebuggerAgent.h:
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.cpp:
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::getHeapSnapshot):
(WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
* inspector/InspectorHeapProfilerAgent.h:
* inspector/InspectorHistory.cpp:
* inspector/InspectorIndexedDBAgent.cpp:
* inspector/InspectorIndexedDBAgent.h:
* inspector/InspectorInputAgent.h:
* inspector/InspectorLayerTreeAgent.h:
* inspector/InspectorMemoryAgent.h:
* inspector/InspectorPageAgent.h:
* inspector/InspectorProfilerAgent.cpp:
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorResourceAgent.h:
* inspector/InspectorRuntimeAgent.h:
* inspector/InspectorStyleSheet.h:
* inspector/InspectorTimelineAgent.h:
* inspector/InspectorWorkerAgent.cpp:
* inspector/InspectorWorkerAgent.h:
* inspector/PageConsoleAgent.h:
* inspector/PageDebuggerAgent.h:
* inspector/PageRuntimeAgent.h:
* inspector/WorkerConsoleAgent.h:
* inspector/WorkerDebuggerAgent.cpp:
* inspector/WorkerInspectorController.cpp:
* inspector/WorkerRuntimeAgent.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 56c23bd4
2014-01-20 Joseph Pecoraro <pecoraro@apple.com>
Run clang-modernize and let it add a bunch of missing overrides in WebCore/inspector
https://bugs.webkit.org/show_bug.cgi?id=127206
Reviewed by Anders Carlsson.
Let clang-modernize add overrides.
* inspector/DOMEditor.cpp:
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorCSSAgent.h:
* inspector/InspectorCanvasAgent.h:
* inspector/InspectorConsoleAgent.h:
* inspector/InspectorDOMAgent.h:
* inspector/InspectorDOMDebuggerAgent.h:
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.cpp:
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::getHeapSnapshot):
(WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
* inspector/InspectorHeapProfilerAgent.h:
* inspector/InspectorHistory.cpp:
* inspector/InspectorIndexedDBAgent.cpp:
* inspector/InspectorIndexedDBAgent.h:
* inspector/InspectorInputAgent.h:
* inspector/InspectorLayerTreeAgent.h:
* inspector/InspectorMemoryAgent.h:
* inspector/InspectorPageAgent.h:
* inspector/InspectorProfilerAgent.cpp:
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorResourceAgent.h:
* inspector/InspectorRuntimeAgent.h:
* inspector/InspectorStyleSheet.h:
* inspector/InspectorTimelineAgent.h:
* inspector/InspectorWorkerAgent.cpp:
* inspector/InspectorWorkerAgent.h:
* inspector/PageConsoleAgent.h:
* inspector/PageDebuggerAgent.h:
* inspector/PageRuntimeAgent.h:
* inspector/WorkerConsoleAgent.h:
* inspector/WorkerDebuggerAgent.cpp:
* inspector/WorkerInspectorController.cpp:
* inspector/WorkerRuntimeAgent.h:
2014-01-20 Zan Dobersek <zdobersek@igalia.com>
Move WebAudio source code to std::unique_ptr
......@@ -56,18 +56,18 @@ public:
{
}
virtual bool perform(ExceptionCode& ec)
virtual bool perform(ExceptionCode& ec) override
{
m_anchorNode = m_node->nextSibling();
return redo(ec);
}
virtual bool undo(ExceptionCode& ec)
virtual bool undo(ExceptionCode& ec) override
{
return m_parentNode->insertBefore(m_node.get(), m_anchorNode.get(), ec);
}
virtual bool redo(ExceptionCode& ec)
virtual bool redo(ExceptionCode& ec) override
{
return m_parentNode->removeChild(m_node.get(), ec);
}
......@@ -89,7 +89,7 @@ public:
{
}
virtual bool perform(ExceptionCode& ec)
virtual bool perform(ExceptionCode& ec) override
{
if (m_node->parentNode()) {
m_removeChildAction = adoptPtr(new RemoveChildAction(m_node->parentNode(), m_node.get()));
......@@ -99,7 +99,7 @@ public:
return m_parentNode->insertBefore(m_node.get(), m_anchorNode.get(), ec);
}
virtual bool undo(ExceptionCode& ec)
virtual bool undo(ExceptionCode& ec) override
{
if (!m_parentNode->removeChild(m_node.get(), ec))
return false;
......@@ -108,7 +108,7 @@ public:
return true;
}
virtual bool redo(ExceptionCode& ec)
virtual bool redo(ExceptionCode& ec) override
{
if (m_removeChildAction && !m_removeChildAction->redo(ec))
return false;
......@@ -132,19 +132,19 @@ public:
{
}
virtual bool perform(ExceptionCode& ec)
virtual bool perform(ExceptionCode& ec) override
{
m_value = m_element->getAttribute(m_name);
return redo(ec);
}
virtual bool undo(ExceptionCode& ec)
virtual bool undo(ExceptionCode& ec) override
{
m_element->setAttribute(m_name, m_value, ec);
return true;
}
virtual bool redo(ExceptionCode&)
virtual bool redo(ExceptionCode&) override
{
m_element->removeAttribute(m_name);
return true;
......@@ -168,7 +168,7 @@ public:
{
}
virtual bool perform(ExceptionCode& ec)
virtual bool perform(ExceptionCode& ec) override
{
m_hadAttribute = m_element->hasAttribute(m_name);
if (m_hadAttribute)
......@@ -176,7 +176,7 @@ public:
return redo(ec);
}
virtual bool undo(ExceptionCode& ec)
virtual bool undo(ExceptionCode& ec) override
{
if (m_hadAttribute)
m_element->setAttribute(m_name, m_oldValue, ec);
......@@ -185,7 +185,7 @@ public:
return true;
}
virtual bool redo(ExceptionCode& ec)
virtual bool redo(ExceptionCode& ec) override
{
m_element->setAttribute(m_name, m_value, ec);
return true;
......@@ -213,7 +213,7 @@ public:
{
}
virtual bool perform(ExceptionCode& ec)
virtual bool perform(ExceptionCode& ec) override
{
m_oldHTML = createMarkup(m_node.get());
DOMPatchSupport domPatchSupport(m_domEditor.get(), &m_node->document());
......@@ -221,12 +221,12 @@ public:
return !ec;
}
virtual bool undo(ExceptionCode& ec)
virtual bool undo(ExceptionCode& ec) override
{
return m_history->undo(ec);
}
virtual bool redo(ExceptionCode& ec)
virtual bool redo(ExceptionCode& ec) override
{
return m_history->redo(ec);
}
......@@ -256,19 +256,19 @@ public:
{
}
virtual bool perform(ExceptionCode& ec)
virtual bool perform(ExceptionCode& ec) override
{
m_oldText = m_textNode->wholeText();
return redo(ec);
}
virtual bool undo(ExceptionCode& ec)
virtual bool undo(ExceptionCode& ec) override
{
m_textNode->replaceWholeText(m_oldText, ec);
return true;
}
virtual bool redo(ExceptionCode& ec)
virtual bool redo(ExceptionCode& ec) override
{
m_textNode->replaceWholeText(m_text, ec);
return true;
......@@ -291,17 +291,17 @@ public:
{
}
virtual bool perform(ExceptionCode& ec)
virtual bool perform(ExceptionCode& ec) override
{
return redo(ec);
}
virtual bool undo(ExceptionCode& ec)
virtual bool undo(ExceptionCode& ec) override
{
return m_parentNode->replaceChild(m_oldNode, m_newNode.get(), ec);
}
virtual bool redo(ExceptionCode& ec)
virtual bool redo(ExceptionCode& ec) override
{
return m_parentNode->replaceChild(m_newNode, m_oldNode.get(), ec);
}
......@@ -322,19 +322,19 @@ public:
{
}
virtual bool perform(ExceptionCode& ec)
virtual bool perform(ExceptionCode& ec) override
{
m_oldValue = m_node->nodeValue();
return redo(ec);
}
virtual bool undo(ExceptionCode& ec)
virtual bool undo(ExceptionCode& ec) override
{
m_node->setNodeValue(m_oldValue, ec);
return !ec;
}
virtual bool redo(ExceptionCode& ec)
virtual bool redo(ExceptionCode& ec) override
{
m_node->setNodeValue(m_value, ec);
return !ec;
......
......@@ -62,10 +62,10 @@ public:
void updateApplicationCacheStatus(Frame*);
void networkStateChanged();
virtual void enable(ErrorString*);
virtual void getFramesWithManifests(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::ApplicationCache::FrameWithManifest>>& result);
virtual void getManifestForFrame(ErrorString*, const String& frameId, String* manifestURL);
virtual void getApplicationCacheForFrame(ErrorString*, const String& frameId, RefPtr<Inspector::TypeBuilder::ApplicationCache::ApplicationCache>&);
virtual void enable(ErrorString*) override;
virtual void getFramesWithManifests(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::ApplicationCache::FrameWithManifest>>& result) override;
virtual void getManifestForFrame(ErrorString*, const String& frameId, String* manifestURL) override;
virtual void getApplicationCacheForFrame(ErrorString*, const String& frameId, RefPtr<Inspector::TypeBuilder::ApplicationCache::ApplicationCache>&) override;
private:
PassRefPtr<Inspector::TypeBuilder::ApplicationCache::ApplicationCache> buildObjectForApplicationCache(const ApplicationCacheHost::ResourceInfoList&, const ApplicationCacheHost::CacheInfo&);
......
......@@ -97,9 +97,9 @@ public:
bool forcePseudoState(Element*, CSSSelector::PseudoType);
virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
virtual void willDestroyFrontendAndBackend() override;
virtual void discardAgent();
virtual void enable(ErrorString*);
virtual void disable(ErrorString*);
virtual void discardAgent() override;
virtual void enable(ErrorString*) override;
virtual void disable(ErrorString*) override;
void reset();
void mediaQueryResultChanged();
void didCreateNamedFlow(Document*, WebKitNamedFlow*);
......@@ -111,21 +111,21 @@ public:
void didRegisterNamedFlowContentElement(Document*, WebKitNamedFlow*, Node* contentElement, Node* nextContentElement = nullptr);
void didUnregisterNamedFlowContentElement(Document*, WebKitNamedFlow*, Node* contentElement);
virtual void getComputedStyleForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSComputedStyleProperty>>&);
virtual void getInlineStylesForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& inlineStyle, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& attributes);
virtual void getMatchedStylesForNode(ErrorString*, int nodeId, const bool* includePseudo, const bool* includeInherited, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::RuleMatch>>& matchedCSSRules, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::PseudoIdMatches>>& pseudoIdMatches, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::InheritedStyleEntry>>& inheritedEntries);
virtual void getAllStyleSheets(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSStyleSheetHeader>>& styleSheetInfos);
virtual void getStyleSheet(ErrorString*, const String& styleSheetId, RefPtr<Inspector::TypeBuilder::CSS::CSSStyleSheetBody>& result);
virtual void getStyleSheetText(ErrorString*, const String& styleSheetId, String* result);
virtual void setStyleSheetText(ErrorString*, const String& styleSheetId, const String& text);
virtual void setStyleText(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, const String& text, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result);
virtual void setPropertyText(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, int propertyIndex, const String& text, bool overwrite, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result);
virtual void toggleProperty(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, int propertyIndex, bool disable, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result);
virtual void setRuleSelector(ErrorString*, const RefPtr<Inspector::InspectorObject>& ruleId, const String& selector, RefPtr<Inspector::TypeBuilder::CSS::CSSRule>& result);
virtual void addRule(ErrorString*, int contextNodeId, const String& selector, RefPtr<Inspector::TypeBuilder::CSS::CSSRule>& result);
virtual void getSupportedCSSProperties(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSPropertyInfo>>& result);
virtual void forcePseudoState(ErrorString*, int nodeId, const RefPtr<Inspector::InspectorArray>& forcedPseudoClasses);
virtual void getNamedFlowCollection(ErrorString*, int documentNodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::NamedFlow>>& result);
virtual void getComputedStyleForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSComputedStyleProperty>>&) override;
virtual void getInlineStylesForNode(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& inlineStyle, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& attributes) override;
virtual void getMatchedStylesForNode(ErrorString*, int nodeId, const bool* includePseudo, const bool* includeInherited, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::RuleMatch>>& matchedCSSRules, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::PseudoIdMatches>>& pseudoIdMatches, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::InheritedStyleEntry>>& inheritedEntries) override;
virtual void getAllStyleSheets(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSStyleSheetHeader>>& styleSheetInfos) override;
virtual void getStyleSheet(ErrorString*, const String& styleSheetId, RefPtr<Inspector::TypeBuilder::CSS::CSSStyleSheetBody>& result) override;
virtual void getStyleSheetText(ErrorString*, const String& styleSheetId, String* result) override;
virtual void setStyleSheetText(ErrorString*, const String& styleSheetId, const String& text) override;
virtual void setStyleText(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, const String& text, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result) override;
virtual void setPropertyText(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, int propertyIndex, const String& text, bool overwrite, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result) override;
virtual void toggleProperty(ErrorString*, const RefPtr<Inspector::InspectorObject>& styleId, int propertyIndex, bool disable, RefPtr<Inspector::TypeBuilder::CSS::CSSStyle>& result) override;
virtual void setRuleSelector(ErrorString*, const RefPtr<Inspector::InspectorObject>& ruleId, const String& selector, RefPtr<Inspector::TypeBuilder::CSS::CSSRule>& result) override;
virtual void addRule(ErrorString*, int contextNodeId, const String& selector, RefPtr<Inspector::TypeBuilder::CSS::CSSRule>& result) override;
virtual void getSupportedCSSProperties(ErrorString*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::CSSPropertyInfo>>& result) override;
virtual void forcePseudoState(ErrorString*, int nodeId, const RefPtr<Inspector::InspectorArray>& forcedPseudoClasses) override;
virtual void getNamedFlowCollection(ErrorString*, int documentNodeId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::CSS::NamedFlow>>& result) override;
private:
class StyleSheetAction;
......@@ -162,12 +162,12 @@ private:
PassRefPtr<Inspector::TypeBuilder::CSS::NamedFlow> buildObjectForNamedFlow(ErrorString*, WebKitNamedFlow*, int documentNodeId);
// InspectorDOMAgent::DOMListener implementation
virtual void didRemoveDocument(Document*);
virtual void didRemoveDOMNode(Node*);
virtual void didModifyDOMAttr(Element*);
virtual void didRemoveDocument(Document*) override;
virtual void didRemoveDOMNode(Node*) override;
virtual void didModifyDOMAttr(Element*) override;
// InspectorCSSAgent::Listener implementation
virtual void styleSheetChanged(InspectorStyleSheet*);
virtual void styleSheetChanged(InspectorStyleSheet*) override;
void resetPseudoStates();
......
......@@ -79,17 +79,17 @@ public:
#endif
// Called from the front-end.
virtual void enable(ErrorString*);
virtual void disable(ErrorString*);
virtual void dropTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&);
virtual void hasUninstrumentedCanvases(ErrorString*, bool*);
virtual void captureFrame(ErrorString*, const Inspector::TypeBuilder::Network::FrameId*, Inspector::TypeBuilder::Canvas::TraceLogId*);
virtual void startCapturing(ErrorString*, const Inspector::TypeBuilder::Network::FrameId*, Inspector::TypeBuilder::Canvas::TraceLogId*);
virtual void stopCapturing(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&);
virtual void getTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, const int*, const int*, RefPtr<Inspector::TypeBuilder::Canvas::TraceLog>&);
virtual void replayTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, int, RefPtr<Inspector::TypeBuilder::Canvas::ResourceState>&);
virtual void getResourceInfo(ErrorString*, const Inspector::TypeBuilder::Canvas::ResourceId&, RefPtr<Inspector::TypeBuilder::Canvas::ResourceInfo>&);
virtual void getResourceState(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, const Inspector::TypeBuilder::Canvas::ResourceId&, RefPtr<Inspector::TypeBuilder::Canvas::ResourceState>&);
virtual void enable(ErrorString*) override;
virtual void disable(ErrorString*) override;
virtual void dropTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&) override;
virtual void hasUninstrumentedCanvases(ErrorString*, bool*) override;
virtual void captureFrame(ErrorString*, const Inspector::TypeBuilder::Network::FrameId*, Inspector::TypeBuilder::Canvas::TraceLogId*) override;
virtual void startCapturing(ErrorString*, const Inspector::TypeBuilder::Network::FrameId*, Inspector::TypeBuilder::Canvas::TraceLogId*) override;
virtual void stopCapturing(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&) override;
virtual void getTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, const int*, const int*, RefPtr<Inspector::TypeBuilder::Canvas::TraceLog>&) override;
virtual void replayTraceLog(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, int, RefPtr<Inspector::TypeBuilder::Canvas::ResourceState>&) override;
virtual void getResourceInfo(ErrorString*, const Inspector::TypeBuilder::Canvas::ResourceId&, RefPtr<Inspector::TypeBuilder::Canvas::ResourceInfo>&) override;
virtual void getResourceState(ErrorString*, const Inspector::TypeBuilder::Canvas::TraceLogId&, const Inspector::TypeBuilder::Canvas::ResourceId&, RefPtr<Inspector::TypeBuilder::Canvas::ResourceState>&) override;
private:
InjectedScriptCanvasModule injectedScriptCanvasModule(ErrorString*, JSC::ExecState*);
......
......@@ -59,9 +59,9 @@ public:
InspectorConsoleAgent(InstrumentingAgents*, PageInjectedScriptManager*);
virtual ~InspectorConsoleAgent();
virtual void enable(ErrorString*);
virtual void disable(ErrorString*);
virtual void clearMessages(ErrorString*);
virtual void enable(ErrorString*) override;
virtual void disable(ErrorString*) override;
virtual void clearMessages(ErrorString*) override;
bool enabled() const { return m_enabled; }
void reset();
......@@ -89,9 +89,9 @@ public:
void addProfileFinishedMessageToConsole(PassRefPtr<ScriptProfile>, unsigned lineNumber, unsigned columnNumber, const String& sourceURL);
void addStartProfilingMessageToConsole(const String& title, unsigned lineNumber, unsigned columnNumber, const String& sourceURL);
#endif
virtual void setMonitoringXHREnabled(ErrorString*, bool enabled);
virtual void setMonitoringXHREnabled(ErrorString*, bool enabled) override;
virtual void addInspectedNode(ErrorString*, int nodeId) = 0;
virtual void addInspectedHeapObject(ErrorString*, int inspectedHeapObjectId);
virtual void addInspectedHeapObject(ErrorString*, int inspectedHeapObjectId) override;
virtual bool isWorkerAgent() = 0;
......
......@@ -118,40 +118,40 @@ public:
void reset();
// Methods called from the frontend for DOM nodes inspection.
virtual void querySelector(ErrorString*, int nodeId, const String& selectors, int* elementId);
virtual void querySelectorAll(ErrorString*, int nodeId, const String& selectors, RefPtr<Inspector::TypeBuilder::Array<int>>& result);
virtual void getDocument(ErrorString*, RefPtr<Inspector::TypeBuilder::DOM::Node>& root);
virtual void requestChildNodes(ErrorString*, int nodeId, const int* depth);
virtual void setAttributeValue(ErrorString*, int elementId, const String& name, const String& value);
virtual void setAttributesAsText(ErrorString*, int elementId, const String& text, const String* name);
virtual void removeAttribute(ErrorString*, int elementId, const String& name);
virtual void removeNode(ErrorString*, int nodeId);
virtual void setNodeName(ErrorString*, int nodeId, const String& name, int* newId);
virtual void getOuterHTML(ErrorString*, int nodeId, WTF::String* outerHTML);
virtual void setOuterHTML(ErrorString*, int nodeId, const String& outerHTML);
virtual void setNodeValue(ErrorString*, int nodeId, const String& value);
virtual void getEventListenersForNode(ErrorString*, int nodeId, const WTF::String* objectGroup, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::DOM::EventListener>>& listenersArray);
virtual void performSearch(ErrorString*, const String& whitespaceTrimmedQuery, const RefPtr<Inspector::InspectorArray>* nodeIds, String* searchId, int* resultCount);
virtual void getSearchResults(ErrorString*, const String& searchId, int fromIndex, int toIndex, RefPtr<Inspector::TypeBuilder::Array<int>>&);
virtual void discardSearchResults(ErrorString*, const String& searchId);
virtual void resolveNode(ErrorString*, int nodeId, const String* objectGroup, RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result);
virtual void getAttributes(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<String>>& result);
virtual void setInspectModeEnabled(ErrorString*, bool enabled, const RefPtr<Inspector::InspectorObject>* highlightConfig);
virtual void requestNode(ErrorString*, const String& objectId, int* nodeId);
virtual void pushNodeByPathToFrontend(ErrorString*, const String& path, int* nodeId);
virtual void pushNodeByBackendIdToFrontend(ErrorString*, BackendNodeId, int* nodeId);
virtual void releaseBackendNodeIds(ErrorString*, const String& nodeGroup);
virtual void hideHighlight(ErrorString*);
virtual void highlightRect(ErrorString*, int x, int y, int width, int height, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor, const bool* usePageCoordinates);
virtual void highlightQuad(ErrorString*, const RefPtr<Inspector::InspectorArray>& quad, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor, const bool* usePageCoordinates);
virtual void highlightNode(ErrorString*, const RefPtr<Inspector::InspectorObject>& highlightConfig, const int* nodeId, const String* objectId);
virtual void highlightFrame(ErrorString*, const String& frameId, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor);
virtual void moveTo(ErrorString*, int nodeId, int targetNodeId, const int* anchorNodeId, int* newNodeId);
virtual void undo(ErrorString*);
virtual void redo(ErrorString*);
virtual void markUndoableState(ErrorString*);
virtual void focus(ErrorString*, int nodeId);
virtual void querySelector(ErrorString*, int nodeId, const String& selectors, int* elementId) override;
virtual void querySelectorAll(ErrorString*, int nodeId, const String& selectors, RefPtr<Inspector::TypeBuilder::Array<int>>& result) override;
virtual void getDocument(ErrorString*, RefPtr<Inspector::TypeBuilder::DOM::Node>& root) override;
virtual void requestChildNodes(ErrorString*, int nodeId, const int* depth) override;
virtual void setAttributeValue(ErrorString*, int elementId, const String& name, const String& value) override;
virtual void setAttributesAsText(ErrorString*, int elementId, const String& text, const String* name) override;
virtual void removeAttribute(ErrorString*, int elementId, const String& name) override;
virtual void removeNode(ErrorString*, int nodeId) override;
virtual void setNodeName(ErrorString*, int nodeId, const String& name, int* newId) override;
virtual void getOuterHTML(ErrorString*, int nodeId, WTF::String* outerHTML) override;
virtual void setOuterHTML(ErrorString*, int nodeId, const String& outerHTML) override;
virtual void setNodeValue(ErrorString*, int nodeId, const String& value) override;
virtual void getEventListenersForNode(ErrorString*, int nodeId, const WTF::String* objectGroup, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::DOM::EventListener>>& listenersArray) override;
virtual void performSearch(ErrorString*, const String& whitespaceTrimmedQuery, const RefPtr<Inspector::InspectorArray>* nodeIds, String* searchId, int* resultCount) override;
virtual void getSearchResults(ErrorString*, const String& searchId, int fromIndex, int toIndex, RefPtr<Inspector::TypeBuilder::Array<int>>&) override;
virtual void discardSearchResults(ErrorString*, const String& searchId) override;
virtual void resolveNode(ErrorString*, int nodeId, const String* objectGroup, RefPtr<Inspector::TypeBuilder::Runtime::RemoteObject>& result) override;
virtual void getAttributes(ErrorString*, int nodeId, RefPtr<Inspector::TypeBuilder::Array<String>>& result) override;
virtual void setInspectModeEnabled(ErrorString*, bool enabled, const RefPtr<Inspector::InspectorObject>* highlightConfig) override;
virtual void requestNode(ErrorString*, const String& objectId, int* nodeId) override;
virtual void pushNodeByPathToFrontend(ErrorString*, const String& path, int* nodeId) override;
virtual void pushNodeByBackendIdToFrontend(ErrorString*, BackendNodeId, int* nodeId) override;
virtual void releaseBackendNodeIds(ErrorString*, const String& nodeGroup) override;
virtual void hideHighlight(ErrorString*) override;
virtual void highlightRect(ErrorString*, int x, int y, int width, int height, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor, const bool* usePageCoordinates) override;
virtual void highlightQuad(ErrorString*, const RefPtr<Inspector::InspectorArray>& quad, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor, const bool* usePageCoordinates) override;
virtual void highlightNode(ErrorString*, const RefPtr<Inspector::InspectorObject>& highlightConfig, const int* nodeId, const String* objectId) override;
virtual void highlightFrame(ErrorString*, const String& frameId, const RefPtr<Inspector::InspectorObject>* color, const RefPtr<Inspector::InspectorObject>* outlineColor) override;
virtual void moveTo(ErrorString*, int nodeId, int targetNodeId, const int* anchorNodeId, int* newNodeId) override;
virtual void undo(ErrorString*) override;
virtual void redo(ErrorString*) override;
virtual void markUndoableState(ErrorString*) override;
virtual void focus(ErrorString*, int nodeId) override;
void getEventListeners(Node*, Vector<EventListenerInfo>& listenersArray, bool includeAncestors);
......
......@@ -62,14 +62,14 @@ public:
virtual ~InspectorDOMDebuggerAgent();
// DOMDebugger API
virtual void setXHRBreakpoint(ErrorString*, const String& url);
virtual void removeXHRBreakpoint(ErrorString*, const String& url);
virtual void setEventListenerBreakpoint(ErrorString*, const String& eventName);
virtual void removeEventListenerBreakpoint(ErrorString*, const String& eventName);
virtual void setInstrumentationBreakpoint(ErrorString*, const String& eventName);
virtual void removeInstrumentationBreakpoint(ErrorString*, const String& eventName);
virtual void setDOMBreakpoint(ErrorString*, int nodeId, const String& type);
virtual void removeDOMBreakpoint(ErrorString*, int nodeId, const String& type);
virtual void setXHRBreakpoint(ErrorString*, const String& url) override;
virtual void removeXHRBreakpoint(ErrorString*, const String& url) override;
virtual void setEventListenerBreakpoint(ErrorString*, const String& eventName) override;
virtual void removeEventListenerBreakpoint(ErrorString*, const String& eventName) override;
virtual void setInstrumentationBreakpoint(ErrorString*, const String& eventName) override;
virtual void removeInstrumentationBreakpoint(ErrorString*, const String& eventName) override;
virtual void setDOMBreakpoint(ErrorString*, int nodeId, const String& type) override;
virtual void removeDOMBreakpoint(ErrorString*, int nodeId, const String& type) override;
// InspectorInstrumentation API
void willInsertDOMNode(Node* parent);
......@@ -83,14 +83,14 @@ public:
virtual void didCreateFrontendAndBackend(Inspector::InspectorFrontendChannel*, Inspector::InspectorBackendDispatcher*) override;
virtual void willDestroyFrontendAndBackend() override;
virtual void discardAgent();
virtual void discardAgent() override;
private:
// InspectorDebuggerAgent::Listener implementation.
virtual void debuggerWasEnabled();
virtual void debuggerWasDisabled();
virtual void stepInto();
virtual void didPause();
virtual void debuggerWasEnabled() override;
virtual void debuggerWasDisabled() override;
virtual void stepInto() override;
virtual void didPause() override;
void disable();
void descriptionForDOMEvent(Node* target, int breakpointType, bool insertion, Inspector::InspectorObject* description);
......
......@@ -61,11 +61,11 @@ public:
virtual void willDestroyFrontendAndBackend() override;
// Called from the front-end.
virtual void enable(ErrorString*);
virtual void disable(ErrorString*);
virtual void getDOMStorageItems(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Array<String>>>& items);
virtual void setDOMStorageItem(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, const String& key, const String& value);
virtual void removeDOMStorageItem(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, const String& key);
virtual void enable(ErrorString*) override;
virtual void disable(ErrorString*) override;
virtual void getDOMStorageItems(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Array<String>>>& items) override;
virtual void setDOMStorageItem(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, const String& key, const String& value) override;
virtual void removeDOMStorageItem(ErrorString*, const RefPtr<Inspector::InspectorObject>& storageId, const String& key) override;
// Called from the injected script.
String storageId(Storage*);
......
......@@ -76,7 +76,7 @@ public:
virtual ~StatementCallback() { }
virtual bool handleEvent(SQLTransaction*, SQLResultSet* resultSet)
virtual bool handleEvent(SQLTransaction*, SQLResultSet* resultSet) override
{
SQLResultSetRowList* rowList = resultSet->rows();
......@@ -114,7 +114,7 @@ public:
virtual ~StatementErrorCallback() { }
virtual bool handleEvent(SQLTransaction*, SQLError* error)
virtual bool handleEvent(SQLTransaction*, SQLError* error) override
{
reportTransactionFailed(m_requestCallback.get(), error);
return true;
......@@ -135,7 +135,7 @@ public:
virtual ~TransactionCallback() { }
virtual bool handleEvent(SQLTransaction* transaction)
virtual bool handleEvent(SQLTransaction* transaction) override
{
if (!m_requestCallback->isActive())
return true;
......@@ -163,7 +163,7 @@ public:
virtual ~TransactionErrorCallback() { }
virtual bool handleEvent(SQLError* error)
virtual bool handleEvent(SQLError* error) override
{
reportTransactionFailed(m_requestCallback.get(), error);
return true;
......@@ -183,7 +183,7 @@ public:
virtual ~TransactionSuccessCallback() { }
virtual bool handleEvent() { return false; }
virtual bool handleEvent() override { return false; }
private:
TransactionSuccessCallback() { }
......
......@@ -61,10 +61,10 @@ public:
void clearResources();
// Called from the front-end.
virtual void enable(ErrorString*);
virtual void disable(ErrorString*);
virtual void getDatabaseTableNames(ErrorString*, const String& databaseId, RefPtr<Inspector::TypeBuilder::Array<String>>& names);
virtual void executeSQL(ErrorString*, const String& databaseId, const String& query, PassRefPtr<ExecuteSQLCallback>);
virtual void enable(ErrorString*) override;
virtual void disable(ErrorString*) override;
virtual void getDatabaseTableNames(ErrorString*, const String& databaseId, RefPtr<Inspector::TypeBuilder::Array<String>>& names) override;
virtual void executeSQL(ErrorString*, const String& databaseId, const String& query, PassRefPtr<ExecuteSQLCallback>) override;
// Called from the injected script.
String databaseId(Database*);
......
......@@ -77,24 +77,24 @@ public:
void addMessageToConsole(MessageSource, MessageType);
// Part of the protocol.
virtual void enable(ErrorString*);
virtual void disable(ErrorString*);
virtual void setBreakpointsActive(ErrorString*, bool active);
virtual void setBreakpointByUrl(ErrorString*, int lineNumber, const String* optionalURL, const String* optionalURLRegex, const int* optionalColumnNumber, const RefPtr<Inspector::InspectorObject>* options, Inspector::TypeBuilder::Debugger::BreakpointId*, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Debugger::Location>>& locations, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Debugger::BreakpointActionIdentifier>>& breakpointActionIdentifiers);
virtual void setBreakpoint(ErrorString*, const RefPtr<Inspector::InspectorObject>& location, const RefPtr<Inspector::InspectorObject>* options, Inspector::TypeBuilder::Debugger::BreakpointId*, RefPtr<Inspector::TypeBuilder::Debugger::Location>& actualLocation, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::Debugger::BreakpointActionIdentifier>>& breakpointActionIdentifiers);
virtual void removeBreakpoint(ErrorString*, const String& breakpointIdentifier);
virtual void continueToLocation(ErrorString*, const RefPtr<Inspector::InspectorObject>& location);
virtual void searchInContent(ErrorString*, const String& scriptID, const String& query, const bool* optionalCaseSensitive, const bool* optionalIsRegex, RefPtr<Inspector::TypeBuilder::Array<Inspector::TypeBuilder::GenericTypes::SearchMatch>>&);
virtual void getScriptSource(ErrorString*, const String& scriptID, String* scriptSource);
virtual void getFunctionDetails(ErrorString*, const String& functionId, RefPtr<Inspector::TypeBuilder::Debugger::FunctionDetails>&);
virtual void pause(ErrorString*);
virtual void resume(ErrorString*);
virtual void stepOver(ErrorString*);
virtual void stepInto(ErrorString*);
virtual void stepOut(ErrorString*);
virtual void setPauseOnExceptions(ErrorString*, const String& pauseState);
virtual void enable(ErrorString*) override;
virtual void disable(ErrorString*) override;
virtual void setBreakpointsActive(ErrorString*, bool active) override;
</