Commit 56377c9d authored by darin's avatar darin

LayoutTests:

        Reviewed and landed by Darin.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=13194
          REGRESSION: Selection rects are wrong for images in search results from images.google.com

        * fast/replaced/selection-rect-in-table-cell-expected.checksum: Added.
        * fast/replaced/selection-rect-in-table-cell-expected.png: Added.
        * fast/replaced/selection-rect-in-table-cell-expected.txt: Added.
        * fast/replaced/selection-rect-in-table-cell.html: Added.

WebCore:

        Reviewed and landed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13194
          <rdar://problem/5087738>
          REGRESSION: Selection rects are wrong for images in search results from images.google.com

        Test: fast/replaced/selection-rect-in-table-cell.html

        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::selectionRect):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 858f93a1
2007-03-26 Mitz Pettel <mitz@webkit.org>
Reviewed and landed by Darin.
- pixel test for http://bugs.webkit.org/show_bug.cgi?id=13194
REGRESSION: Selection rects are wrong for images in search results from images.google.com
* fast/replaced/selection-rect-in-table-cell-expected.checksum: Added.
* fast/replaced/selection-rect-in-table-cell-expected.png: Added.
* fast/replaced/selection-rect-in-table-cell-expected.txt: Added.
* fast/replaced/selection-rect-in-table-cell.html: Added.
2007-03-26 Antti Koivisto <antti@apple.com>
Reviewed by Adam.
d022929f7866f939ca166b73fd06131c
\ No newline at end of file
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderBlock {P} at (0,0) size 784x36
RenderText {#text} at (0,0) size 53x18
text run at (0,0) width 53: "Test for "
RenderInline {I} at (0,0) size 757x36
RenderInline {A} at (0,0) size 301x18 [color=#0000EE]
RenderText {#text} at (53,0) size 301x18
text run at (53,0) width 301: "http://bugs.webkit.org/show_bug.cgi?id=13194"
RenderText {#text} at (354,0) size 757x36
text run at (354,0) width 4: " "
text run at (358,0) width 399: "REGRESSION: Selection rects are wrong for images in search"
text run at (0,18) width 202: "results from images.google.com"
RenderText {#text} at (202,18) size 4x18
text run at (202,18) width 4: "."
RenderBlock {P} at (0,52) size 784x18
RenderText {#text} at (0,0) size 718x18
text run at (0,0) width 718: "Tests highlighting of replaced objects in table cells with extra height. You should see a dark green box and no red."
RenderTable {TABLE} at (0,86) size 56x104
RenderTableSection {TBODY} at (0,0) size 56x104
RenderTableRow {TR} at (0,2) size 56x100
RenderTableCell {TD} at (2,26) size 52x52 [r=0 c=0 rs=1 cs=1]
RenderImage {IMG} at (1,1) size 50x50 [bgcolor=#FF0000]
selection start: position 0 of child 0 {IMG} of child 0 {TD} of child 0 {TR} of child 1 {TBODY} of child 5 {TABLE} of child 1 {BODY} of child 0 {HTML} of document
selection end: position 1 of child 0 {IMG} of child 0 {TD} of child 0 {TR} of child 1 {TBODY} of child 5 {TABLE} of child 1 {BODY} of child 0 {HTML} of document
<html>
<head>
<title></title>
<style>
::selection { background: green; }
</style>
</head>
<body>
<p>
Test for <i><a href="http://bugs.webkit.org/show_bug.cgi?id=13194">http://bugs.webkit.org/show_bug.cgi?id=13194</a>
REGRESSION: Selection rects are wrong for images in search results from images.google.com</i>.
</p>
<p>
Tests highlighting of replaced objects in table cells with extra height. You should see a dark green box and no red.
</p>
<table>
<tr>
<td id="target" style="height: 100px;"><img width="50" height="50" style="background: red;"></td>
</tr>
</table>
<script>
var target = document.getElementById("target");
getSelection().setBaseAndExtent(target, 0, target, 1);
</script>
</body>
</html>
2007-03-26 Mitz Pettel <mitz@webkit.org>
Reviewed and landed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=13194
<rdar://problem/5087738>
REGRESSION: Selection rects are wrong for images in search results from images.google.com
Test: fast/replaced/selection-rect-in-table-cell.html
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::selectionRect):
2007-03-26 Geoffrey Garen <ggaren@apple.com>
Removed now-stale #includes of <assert.h>.
......
......@@ -165,7 +165,7 @@ IntRect RenderReplaced::selectionRect()
int selectionRight = xPos() + width();
int absx, absy;
cb->absolutePosition(absx, absy);
cb->absolutePositionForContent(absx, absy);
if (cb->hasOverflowClip())
cb->layer()->subtractScrollOffset(absx, absy);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment