Commit 53c40236 authored by ap@apple.com's avatar ap@apple.com
Browse files

Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=31659
        Connection must be closed in case of Web Socket handshake error

        The network connection was closed, but the close event wasn't dispatched.

        Tested by websocket/tests/handshake-error.html, which is un-skipped now.

        * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose):
        Call client didHandle() method. This looks strange in CFNetwork implementation, because
        it's the client that asked to close the stream, so it shouldn't need the callback. It makes
        more sense in cross-process implementation, because closing is async there.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent e1dd094e
2009-11-30 Alexey Proskuryakov <ap@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=31659
Connection must be closed in case of Web Socket handshake error
* platform/mac/Skipped: Un-skip websocket/tests/handshake-error.html.
2009-11-30 Eric Carlson <eric.carlson@apple.com>
 
Reviewed by Simon Fraser.
......@@ -108,6 +108,3 @@ plugins/reloadplugins-no-pages.html
# These test require Qt Widgets
plugins/qt-qwidget-plugin.html
# Skipped until https://bugs.webkit.org/show_bug.cgi?id=31659 is fixed.
websocket/tests/handshake-error.html
2009-11-24 Gavin Barraclough <barraclough@apple.com>
2009-11-30 Alexey Proskuryakov <ap@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=31659
Connection must be closed in case of Web Socket handshake error
The network connection was closed, but the close event wasn't dispatched.
Tested by websocket/tests/handshake-error.html, which is un-skipped now.
* platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose):
Call client didHandle() method. This looks strange in CFNetwork implementation, because
it's the client that asked to close the stream, so it shouldn't need the callback. It makes
more sense in cross-process implementation, because closing is async there.
2009-11-30 Gavin Barraclough <barraclough@apple.com>
 
Reviewed by Geoff Garen.
 
......@@ -614,6 +614,8 @@ void SocketStreamHandle::platformClose()
m_readStream = 0;
m_writeStream = 0;
m_client->didClose(this);
}
void SocketStreamHandle::receivedCredential(const AuthenticationChallenge&, const Credential&)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment