Fix IDL dependency generation correctly

https://bugs.webkit.org/show_bug.cgi?id=95730

Patch by Jonathan Liu <net147@gmail.com> on 2012-09-04
Reviewed by Csaba Osztrogonác.

IDL dependency generation is still not working after
https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces
added after the filename in an echo command end up being added to the
file which isn't handled correctly by preprocess-idls.pl. The problem
is fixed by removing the space after the filename.

* DerivedSources.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 61d00bd3
2012-09-04 Jonathan Liu <net147@gmail.com>
Fix IDL dependency generation correctly
https://bugs.webkit.org/show_bug.cgi?id=95730
Reviewed by Csaba Osztrogonác.
IDL dependency generation is still not working after
https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces
added after the filename in an echo command end up being added to the
file which isn't handled correctly by preprocess-idls.pl. The problem
is fixed by removing the space after the filename.
* DerivedSources.pri:
2012-09-04 Mario Sanchez Prada <msanchez@igalia.com>
[Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
......@@ -705,7 +705,8 @@ win_cmd_shell: preprocessIdls.commands = type nul > $$IDL_FILES_TMP $$EOC
else: preprocessIdls.commands = cat /dev/null > $$IDL_FILES_TMP $$EOC
for(binding, IDL_BINDINGS) {
# We need "$$binding" instead of "$$binding ", because Windows' echo writes trailing whitespaces. (http://wkb.ug/88304)
preprocessIdls.commands += echo $$binding>> $$IDL_FILES_TMP $$EOC
# A space is omitted between "$$IDL_FILES_TMP" and "$$EOC" to also avoid writing trailing whitespace. (http://wkb.ug/95730)
preprocessIdls.commands += echo $$binding>> $$IDL_FILES_TMP$$EOC
}
preprocessIdls.commands += perl -I$$PWD/bindings/scripts $$preprocessIdls.script \
--defines \"$${FEATURE_DEFINES_JAVASCRIPT}\" \
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment