Commit 515b98d6 authored by mjs's avatar mjs
Browse files

LayoutTests:

        Reviewed by Antti.
        
        - test case for <rdar://problem/4928675> REGRESSION: Crash in CGBlt_copyBytes under WebCore::Font::drawGlyphs (12083)
        http://bugs.webkit.org/show_bug.cgi?id=12083
        
        * fast/text/text-shadow-extreme-value.html: Added.
        * fast/text/text-shadow-extreme-value-expected.txt: Added.

WebCore:

        Reviewed by Antti.

        - fixed <rdar://problem/4928675> REGRESSION: Crash in CGBlt_copyBytes under WebCore::Font::drawGlyphs (12083)
        http://bugs.webkit.org/show_bug.cgi?id=12083
        
        Test: fast/text/text-shadow-extreme-value.html

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setShadow): Clamp shadow value to 1000px, anything more seems to 
        make CG unhappy.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent c878de73
2007-02-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti.
- test case for <rdar://problem/4928675> REGRESSION: Crash in CGBlt_copyBytes under WebCore::Font::drawGlyphs (12083)
http://bugs.webkit.org/show_bug.cgi?id=12083
* fast/text/text-shadow-extreme-value.html: Added.
* fast/text/text-shadow-extreme-value-expected.txt: Added.
2007-02-11 Maciej Stachowiak <mjs@apple.com>
 
Test case not reviewed; based on manual test by David Kilzer.
layer at (0,0) size 506742501x506742511
RenderView at (0,0) size 785x585
layer at (0,0) size 506742501x506742511
RenderBlock {HTML} at (0,0) size 785x585
RenderBody {BODY} at (8,8) size 769x561
RenderBlock {P} at (0,0) size 769x18
RenderText {#text} at (0,0) size 8x18
text run at (0,0) width 8: "p"
<html>
<head>
<title>Test HTML Page</title>
<script>
if (window.layoutTestController)
layoutTestController.dumpAsText();
</script>
<style type="text/css">
p { text-shadow: purple 0px 0px 38005685px; }
</style>
</head>
<body>
<p>Extreme text-shadow blur values should not crash.</p>
</body>
</html>
2007-02-12 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti.
- fixed <rdar://problem/4928675> REGRESSION: Crash in CGBlt_copyBytes under WebCore::Font::drawGlyphs (12083)
http://bugs.webkit.org/show_bug.cgi?id=12083
Test: fast/text/text-shadow-extreme-value.html
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setShadow): Clamp shadow value to 1000px, anything more seems to
make CG unhappy.
2007-02-11 Brady Eidson <beidson@apple.com>
 
Reviewed by Maciej
Reviewed by Maciej.
 
First in what will be a series of HistoryItem enhancements to help debugging
 
......
......@@ -595,6 +595,9 @@ void GraphicsContext::endTransparencyLayer()
void GraphicsContext::setShadow(const IntSize& size, int blur, const Color& color)
{
// Extreme "blur" values can make text drawing crash or take crazy long times, so clamp
blur = min(blur, 1000);
if (paintingDisabled())
return;
// Check for an invalid color, as this means that the color was not set for the shadow
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment