From 4fd3295af7fe5fabf97378f7c9d097bbab41c272 Mon Sep 17 00:00:00 2001 From: "dimich@chromium.org" Date: Fri, 12 Jun 2009 23:20:28 +0000 Subject: [PATCH] 2009-06-12 Dmitry Titov Reviewed by David Levin. https://bugs.webkit.org/show_bug.cgi?id=26359 [v8] Add XMLHttpRequest to WorkerContextExecutionProxy. * bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object): Add type == V8ClassIndex::XMLHTTPREQUEST to the convertable types. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): same. * bindings/v8/WorkerContextExecutionProxy.h: fix typo in the comment. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44635 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- WebCore/ChangeLog | 12 ++++++++++++ WebCore/bindings/v8/WorkerContextExecutionProxy.cpp | 6 +++++- WebCore/bindings/v8/WorkerContextExecutionProxy.h | 2 +- 3 files changed, 18 insertions(+), 2 deletions(-) diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog index 3772565e113..a884c43035e 100644 --- a/WebCore/ChangeLog +++ b/WebCore/ChangeLog @@ -1,3 +1,15 @@ +2009-06-12 Dmitry Titov + + Reviewed by David Levin. + + https://bugs.webkit.org/show_bug.cgi?id=26359 + [v8] Add XMLHttpRequest to WorkerContextExecutionProxy. + + * bindings/v8/WorkerContextExecutionProxy.cpp: + (WebCore::WorkerContextExecutionProxy::ToV8Object): Add type == V8ClassIndex::XMLHTTPREQUEST to the convertable types. + (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): same. + * bindings/v8/WorkerContextExecutionProxy.h: fix typo in the comment. + 2009-06-12 Peter Kasting Reviewed by Eric Seidel. diff --git a/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp b/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp index 7af953649dd..2cf043dc655 100644 --- a/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp +++ b/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp @@ -217,7 +217,7 @@ v8::Handle WorkerContextExecutionProxy::ToV8Object(V8ClassIndex::V8Wr if (type == V8ClassIndex::WORKERCONTEXT) return WorkerContextToV8Object(static_cast(impl)); - if (type == V8ClassIndex::WORKER) { + if (type == V8ClassIndex::WORKER || type == V8ClassIndex::XMLHTTPREQUEST) { v8::Persistent result = getActiveDOMObjectMap().get(impl); if (!result.IsEmpty()) return result; @@ -293,6 +293,10 @@ v8::Handle WorkerContextExecutionProxy::EventTargetToV8Object(EventTa if (worker) return ToV8Object(V8ClassIndex::WORKER, worker); + XMLHttpRequest* xhr = target->toXMLHttpRequest(); + if (xhr) + return ToV8Object(V8ClassIndex::XMLHTTPREQUEST, xhr); + ASSERT_NOT_REACHED(); return v8::Handle(); } diff --git a/WebCore/bindings/v8/WorkerContextExecutionProxy.h b/WebCore/bindings/v8/WorkerContextExecutionProxy.h index dad191c3e0d..21af0ef29a6 100644 --- a/WebCore/bindings/v8/WorkerContextExecutionProxy.h +++ b/WebCore/bindings/v8/WorkerContextExecutionProxy.h @@ -53,7 +53,7 @@ namespace WebCore { WorkerContextExecutionProxy(WorkerContext*); ~WorkerContextExecutionProxy(); - // FIXME: following function sshould have camelCased names once V8 code-generating script is migrated. + // FIXME: following function should have camelCased names once V8 code-generating script is migrated. v8::Local GetContext() { return v8::Local::New(m_context); } v8::Local GetConstructor(V8ClassIndex::V8WrapperType); void RemoveEventListener(V8EventListener*); -- GitLab