Commit 4fa18d43 authored by abarth@webkit.org's avatar abarth@webkit.org

2011-03-01 Adam Barth <abarth@webkit.org>

        Reviewed by Eric Seidel.

        JavaScriptCore GYP build should copy some headers into the target framework
        https://bugs.webkit.org/show_bug.cgi?id=55524

        After this patch, all the framework headers are exported as public
        headers.  We need to teach GYP how to handle private headers.

        I struggled to determine how to store the information about whether a
        header was public, private, or project (i.e., not exported).
        Generally, the GYPI should just list the files, but it seemed siliy to
        have an almost duplicated list of files in the GYP file itself.  If
        this design doesn't scale, we might have to revisit it in the future.

        * JavaScriptCore.gyp/JavaScriptCore.gyp:
        * JavaScriptCore.gypi:
        * gyp/JavaScriptCore.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent b4c4e6f2
2011-03-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
JavaScriptCore GYP build should copy some headers into the target framework
https://bugs.webkit.org/show_bug.cgi?id=55524
After this patch, all the framework headers are exported as public
headers. We need to teach GYP how to handle private headers.
I struggled to determine how to store the information about whether a
header was public, private, or project (i.e., not exported).
Generally, the GYPI should just list the files, but it seemed siliy to
have an almost duplicated list of files in the GYP file itself. If
this design doesn't scale, we might have to revisit it in the future.
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:
* gyp/JavaScriptCore.gyp:
2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r80079.
......
......@@ -106,6 +106,8 @@
'../wtf/unicode',
],
'sources': [
'<@(javascriptcore_publicheader_files)',
'<@(javascriptcore_privateheader_files)',
'<@(javascriptcore_files)',
],
'sources/': [
......
This diff is collapsed.
......@@ -33,12 +33,18 @@
],
'sources': [
'<@(javascriptcore_files)',
'<@(javascriptcore_publicheader_files)',
'<@(javascriptcore_privateheader_files)',
'$(SDKROOT)/System/Library/Frameworks/CoreFoundation.framework',
'$(SDKROOT)/System/Library/Frameworks/Foundation.framework',
'libedit.dylib',
'libicucore.dylib',
'libobjc.dylib',
],
'mac_framework_headers': [
'<@(javascriptcore_publicheader_files)',
'<@(javascriptcore_privateheader_files)', # FIXME: These should be private headers.
],
'xcode_config_file': '<(DEPTH)/JavaScriptCore/Configurations/JavaScriptCore.xcconfig',
'sources/': [
['exclude', 'qt'],
......@@ -49,6 +55,7 @@
['exclude', 'wtf/gtk'],
['exclude', 'wtf/qt'],
['exclude', 'wtf/haiku'],
['exclude', 'API/tests'],
['exclude', 'wtf/url'],
['exclude', 'wtf/wince'],
['exclude', 'wtf/wx'],
......@@ -57,7 +64,7 @@
['exclude', 'wtf/unicode/glib'],
['exclude', 'wtf/unicode/qt4'],
['exclude', '/(gtk|glib|gobject)/.*\\.(cpp|h)$'],
['exclude', '(Default|Gtk|Chromium|None|Qt|Win|Wx|Symbian)\\.(cpp|mm)$'],
['exclude', '(Default|Gtk|Chromium|None|Qt|Win|Wx|Symbian)\\.(cpp|mm|h)$'],
['exclude', 'GCActivityCallback\.cpp'],
['exclude', '.*BSTR.*$'],
['exclude', 'jsc.cpp$'],
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment