Commit 4eece7c8 authored by cfleizach@apple.com's avatar cfleizach@apple.com

VO reporting incorrect list count for http://www.macworld.com/news.html

https://bugs.webkit.org/show_bug.cgi?id=56064

Reviewed by Beth Dakin.

Source/WebCore: 

<li> tags should not be ignored, because they provide valuable information
to screen readers.

Test: platform/mac/accessibility/list-items-ignored.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

LayoutTests: 

* platform/mac/accessibility/list-items-ignored-expected.txt: Added.
* platform/mac/accessibility/list-items-ignored.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 745949b0
2011-03-09 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
VO reporting incorrect list count for http://www.macworld.com/news.html
https://bugs.webkit.org/show_bug.cgi?id=56064
* platform/mac/accessibility/list-items-ignored-expected.txt: Added.
* platform/mac/accessibility/list-items-ignored.html: Added.
2011-03-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
......
Mar 7
test
test
Mar 7
test
test
Mar 7
test
test
This tests that list items will not be ignored as children of a list.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS list.childrenCount is 3
PASS successfullyParsed is true
TEST COMPLETE
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
<link rel="stylesheet" href="../../../fast/js/resources/js-test-style.css">
<script>
var successfullyParsed = false;
</script>
<script src="../../../fast/js/resources/js-test-pre.js"></script>
</head>
<body id="body">
<ul tabindex="0" id="list">
<li><div class="image thumb2160"><img src></div>
<span><div class="date"><script></script>Mar 7</div>
<a href="/">test</a><p class="blurb">test</p></span><div class="spacer"></div>
</li>
<li><div class="image thumb2160"><img src></div>
<span><div class="date"><script></script>Mar 7</div>
<a href="/">test</a><p class="blurb">test</p></span><div class="spacer"></div>
</li>
<li><div class="image thumb2160"><img src></div>
<span><div class="date"><script></script>Mar 7</div>
<a href="/">test</a><p class="blurb">test</p></span><div class="spacer"></div>
</li>
</ul>
<p id="description"></p>
<div id="console"></div>
<script>
description("This tests that list items will not be ignored as children of a list.");
if (window.accessibilityController) {
document.getElementById("list").focus();
var list = accessibilityController.focusedElement;
shouldBe("list.childrenCount", "3");
}
successfullyParsed = true;
</script>
<script src="../../../fast/js/resources/js-test-post.js"></script>
</body>
</html>
2011-03-09 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
VO reporting incorrect list count for http://www.macworld.com/news.html
https://bugs.webkit.org/show_bug.cgi?id=56064
<li> tags should not be ignored, because they provide valuable information
to screen readers.
Test: platform/mac/accessibility/list-items-ignored.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2011-03-09 Dan Bernstein <mitz@apple.com>
Reviewed by Dave Hyatt.
......
......@@ -1838,6 +1838,10 @@ bool AccessibilityRenderObject::accessibilityIsIgnored() const
return false;
}
// List items play an important role in defining the structure of lists. They should not be ignored.
if (roleValue() == ListItemRole)
return false;
// if this element has aria attributes on it, it should not be ignored.
if (supportsARIAAttributes())
return false;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment