Commit 495c54a4 authored by ap@webkit.org's avatar ap@webkit.org

2008-05-15 Adele Peterson <adele@apple.com>

        Reviewed and landed by Alexey.

        Use TextIterator in +[NSAttributedString _web_attributedStringFromRange:].



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 9eb28ab6
2008-05-15 Alexey Proskuryakov <ap@webkit.org>
Use TextIterator in +[NSAttributedString _web_attributedStringFromRange:].
* platform/mac/fast/text/attributed-substring-from-range-001-expected.txt:
Newlines now get attributes, too.
* platform/mac/fast/text/attributed-substring-from-range-in-textfield-expected.txt:
Results changed from [FAIL] to [PASS].
2008-05-14 Dan Bernstein <mitz@apple.com>
Reviewed by Mark Rowe.
Testing text with br elements (<div><br></div>hello<br>)
(0, 0):
(0, 1): {}
(0, 2): {}h{ NSColor = NSCalibratedWhiteColorSpace 0 1; NSFont = "Times-Roman 16.00 pt. S [] (0xXXXXXXXX) fobj=0xXXXXXXXX, spc=4.00"; }
(0, 1): { NSColor = NSCalibratedWhiteColorSpace 0 1; NSFont = "Times-Roman 16.00 pt. S [] (0xXXXXXXXX) fobj=0xXXXXXXXX, spc=4.00"; }
(0, 2): h{ NSColor = NSCalibratedWhiteColorSpace 0 1; NSFont = "Times-Roman 16.00 pt. S [] (0xXXXXXXXX) fobj=0xXXXXXXXX, spc=4.00"; }
(1, 1): h{ NSColor = NSCalibratedWhiteColorSpace 0 1; NSFont = "Times-Roman 16.00 pt. S [] (0xXXXXXXXX) fobj=0xXXXXXXXX, spc=4.00"; }
(1, 5): hello{ NSColor = NSCalibratedWhiteColorSpace 0 1; NSFont = "Times-Roman 16.00 pt. S [] (0xXXXXXXXX) fobj=0xXXXXXXXX, spc=4.00"; }
(1, 6): hello{ NSColor = NSCalibratedWhiteColorSpace 0 1; NSFont = "Times-Roman 16.00 pt. S [] (0xXXXXXXXX) fobj=0xXXXXXXXX, spc=4.00"; } {}
(1, 100): hello{ NSColor = NSCalibratedWhiteColorSpace 0 1; NSFont = "Times-Roman 16.00 pt. S [] (0xXXXXXXXX) fobj=0xXXXXXXXX, spc=4.00"; } {}
(6, 1): {}
(1, 6): hello { NSColor = NSCalibratedWhiteColorSpace 0 1; NSFont = "Times-Roman 16.00 pt. S [] (0xXXXXXXXX) fobj=0xXXXXXXXX, spc=4.00"; }
(1, 100): hello { NSColor = NSCalibratedWhiteColorSpace 0 1; NSFont = "Times-Roman 16.00 pt. S [] (0xXXXXXXXX) fobj=0xXXXXXXXX, spc=4.00"; }
(6, 1): { NSColor = NSCalibratedWhiteColorSpace 0 1; NSFont = "Times-Roman 16.00 pt. S [] (0xXXXXXXXX) fobj=0xXXXXXXXX, spc=4.00"; }
(7, 1):
(100, 0): undefined
(100, 100): undefined
......@@ -10,19 +10,19 @@ The results for oversized requests are incorrect due to <rdar://problem/5400551>
(offset: 1 length: 1) [PASSED]: "b"
(offset: 1 length: 2) [PASSED]: "bc"
(offset: 1 length: 3) [PASSED]: "bcd"
(offset: 1 length: 4) [FAILED]: "bcd\n"
(offset: 1 length: 4) [PASSED]: "bcd"
(offset: 2 length: 0) [PASSED]: ""
(offset: 2 length: 1) [PASSED]: "c"
(offset: 2 length: 2) [PASSED]: "cd"
(offset: 2 length: 3) [FAILED]: "cd\n"
(offset: 2 length: 4) [FAILED]: "cd\n"
(offset: 2 length: 3) [PASSED]: "cd"
(offset: 2 length: 4) [PASSED]: "cd"
(offset: 3 length: 0) [PASSED]: ""
(offset: 3 length: 1) [PASSED]: "d"
(offset: 3 length: 2) [FAILED]: "d\n"
(offset: 3 length: 3) [FAILED]: "d\n"
(offset: 3 length: 4) [FAILED]: "d\n"
(offset: 3 length: 2) [PASSED]: "d"
(offset: 3 length: 3) [PASSED]: "d"
(offset: 3 length: 4) [PASSED]: "d"
(offset: 4 length: 0) [PASSED]: ""
(offset: 4 length: 1) [FAILED]: "\n"
(offset: 4 length: 2) [FAILED]: "\n"
(offset: 4 length: 3) [FAILED]: "\n"
(offset: 4 length: 4) [FAILED]: "\n"
(offset: 4 length: 1) [PASSED]: ""
(offset: 4 length: 2) [PASSED]: ""
(offset: 4 length: 3) [PASSED]: ""
(offset: 4 length: 4) [PASSED]: ""
2008-05-15 Adele Peterson <adele@apple.com>
Reviewed and landed by Alexey.
Use TextIterator in +[NSAttributedString _web_attributedStringFromRange:].
* WebCore.base.exp: Exported TextIterator methods.
2008-05-15 Simon Hausmann <hausmann@webkit.org>
Fix the Qt build by adding NetworkStateNotifier.cpp to the build.
This diff is collapsed.
2008-05-15 Adele Peterson <adele@apple.com>
Reviewed and landed by Alexey.
Use TextIterator in +[NSAttributedString _web_attributedStringFromRange:].
* Misc/WebNSAttributedStringExtras.mm:
(+[NSAttributedString _web_attributedStringFromRange:]):
2008-05-14 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment