Commit 3d818cc7 authored by vsevik@chromium.org's avatar vsevik@chromium.org
Browse files

Web Inspector: Follow-up to r146898: test that uiSourceCodes are not leaking in breakpoint manager.

https://bugs.webkit.org/show_bug.cgi?id=113368

Reviewed by Pavel Feldman.

Source/WebCore:

Added a missed line and a test.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._projectWillReset):

LayoutTests:

* inspector/debugger/breakpoint-manager.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent af160b53
2013-03-27 Vsevolod Vlasov <vsevik@chromium.org>
Web Inspector: Follow-up to r146898: test that uiSourceCodes are not leaking in breakpoint manager.
https://bugs.webkit.org/show_bug.cgi?id=113368
Reviewed by Pavel Feldman.
* inspector/debugger/breakpoint-manager.html:
2013-03-26 Takashi Sakamoto <tasak@google.com>
 
[shadow] styleForText should consider the case where parent node has no style
......@@ -373,6 +373,9 @@ function test()
addTemporaryUISourceCode(breakpointManager, "a.js")
var eventData = { breakpointId: "a.js:10", location: { scriptId: "a.js", lineNumber: 11, columnNumber: 5 }};
breakpointManager._debuggerModel.dispatchEventToListeners(WebInspector.DebuggerModel.Events.BreakpointResolved, eventData);
var breakpoints = breakpointManager._breakpoints.keys();
InspectorTest.assertEquals(breakpoints.length, 1, "Exactly one breakpoint should be registered in breakpoint manager.");
InspectorTest.assertTrue(!breakpoints[0]._primaryUILocation, "_primaryUILocation field should be cleared for provisional breapoint.");
resetBreakpointManager(breakpointManager, next);
}
]);
......
2013-03-27 Vsevolod Vlasov <vsevik@chromium.org>
Web Inspector: Follow-up to r146898: test that uiSourceCodes are not leaking in breakpoint manager.
https://bugs.webkit.org/show_bug.cgi?id=113368
Reviewed by Pavel Feldman.
Added a missed line and a test.
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._projectWillReset):
2013-03-27 Andrey Lushnikov <lushnikov@chromium.org>
 
Web Inspector: [CodeMirror] CodeMirrorTextEditor.highlightRange has bugs
......@@ -274,7 +274,8 @@ WebInspector.BreakpointManager.prototype = {
var breakpoints = this.breakpointsForUISourceCode(uiSourceCode);
for (var j = 0; j < breakpoints.length; ++j) {
this._breakpoints.remove(breakpoints[j]);
var breakpoint = breakpoints[j];
this._breakpoints.remove(breakpoint);
delete breakpoint._primaryUILocation;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment