Commit 3a8d2aea authored by hyatt@apple.com's avatar hyatt@apple.com
Browse files

Back out r72527 since it caused multiple rendering regressions. Details in bug.

WebCore: 

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):

LayoutTests: 

* fast/lists/outSideListMarkers-expected.txt: Removed.
* fast/lists/outSideListMarkers.html: Removed.
* platform/mac-leopard/css1/box_properties/margin_right-expected.checksum:
* platform/mac-leopard/css1/box_properties/margin_right-expected.png:
* platform/mac-leopard/css1/box_properties/padding_right-expected.checksum:
* platform/mac-leopard/css1/box_properties/padding_right-expected.png:
* platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
* platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
* platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum:
* platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
* platform/mac-leopard/fast/css/empty-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/empty-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/first-child-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/first-child-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/last-child-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/last-child-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/only-child-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/only-child-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.png:
* platform/mac-leopard/fast/doctypes/002-expected.checksum:
* platform/mac-leopard/fast/doctypes/002-expected.png:
* platform/mac-leopard/fast/lists/001-expected.checksum:
* platform/mac-leopard/fast/lists/001-expected.png:
* platform/mac-leopard/fast/lists/002-expected.checksum:
* platform/mac-leopard/fast/lists/002-expected.png:
* platform/mac-leopard/fast/lists/003-expected.checksum:
* platform/mac-leopard/fast/lists/003-expected.png:
* platform/mac/css1/box_properties/margin_right-expected.txt:
* platform/mac/css1/box_properties/padding_right-expected.txt:
* platform/mac/editing/pasteboard/merge-end-list-expected.txt:
* platform/mac/editing/selection/extend-by-word-002-expected.checksum:
* platform/mac/editing/selection/extend-by-word-002-expected.png:
* platform/mac/editing/selection/extend-by-word-002-expected.txt:
* platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
* platform/mac/fast/css/empty-pseudo-class-expected.txt:
* platform/mac/fast/css/first-child-pseudo-class-expected.txt:
* platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/last-child-pseudo-class-expected.txt:
* platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/only-child-pseudo-class-expected.txt:
* platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
* platform/mac/fast/doctypes/002-expected.txt:
* platform/mac/fast/lists/001-expected.txt:
* platform/mac/fast/lists/001-vertical-expected.checksum:
* platform/mac/fast/lists/001-vertical-expected.png:
* platform/mac/fast/lists/001-vertical-expected.txt:
* platform/mac/fast/lists/002-expected.txt:
* platform/mac/fast/lists/002-vertical-expected.checksum:
* platform/mac/fast/lists/002-vertical-expected.png:
* platform/mac/fast/lists/002-vertical-expected.txt:
* platform/mac/fast/lists/003-expected.txt:
* platform/mac/fast/lists/003-vertical-expected.checksum:
* platform/mac/fast/lists/003-vertical-expected.png:
* platform/mac/fast/lists/003-vertical-expected.txt:
* platform/mac/fast/lists/007-vertical-expected.checksum:
* platform/mac/fast/lists/007-vertical-expected.png:
* platform/mac/fast/lists/007-vertical-expected.txt:
* platform/mac/fast/lists/008-vertical-expected.checksum:
* platform/mac/fast/lists/008-vertical-expected.png:
* platform/mac/fast/lists/008-vertical-expected.txt:
* platform/mac/fast/lists/outSideListMarkers-expected.checksum: Removed.
* platform/mac/fast/lists/outSideListMarkers-expected.png: Removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 1eb6bc1e
2010-11-22 David Hyatt <hyatt@apple.com>
Back out r72527 since it caused multiple rendering regressions. Details in bug.
* fast/lists/outSideListMarkers-expected.txt: Removed.
* fast/lists/outSideListMarkers.html: Removed.
* platform/mac-leopard/css1/box_properties/margin_right-expected.checksum:
* platform/mac-leopard/css1/box_properties/margin_right-expected.png:
* platform/mac-leopard/css1/box_properties/padding_right-expected.checksum:
* platform/mac-leopard/css1/box_properties/padding_right-expected.png:
* platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
* platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
* platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum:
* platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
* platform/mac-leopard/fast/css/empty-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/empty-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/first-child-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/first-child-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/last-child-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/last-child-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/only-child-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/only-child-pseudo-class-expected.png:
* platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.checksum:
* platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.png:
* platform/mac-leopard/fast/doctypes/002-expected.checksum:
* platform/mac-leopard/fast/doctypes/002-expected.png:
* platform/mac-leopard/fast/lists/001-expected.checksum:
* platform/mac-leopard/fast/lists/001-expected.png:
* platform/mac-leopard/fast/lists/002-expected.checksum:
* platform/mac-leopard/fast/lists/002-expected.png:
* platform/mac-leopard/fast/lists/003-expected.checksum:
* platform/mac-leopard/fast/lists/003-expected.png:
* platform/mac/css1/box_properties/margin_right-expected.txt:
* platform/mac/css1/box_properties/padding_right-expected.txt:
* platform/mac/editing/pasteboard/merge-end-list-expected.txt:
* platform/mac/editing/selection/extend-by-word-002-expected.checksum:
* platform/mac/editing/selection/extend-by-word-002-expected.png:
* platform/mac/editing/selection/extend-by-word-002-expected.txt:
* platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
* platform/mac/fast/css/empty-pseudo-class-expected.txt:
* platform/mac/fast/css/first-child-pseudo-class-expected.txt:
* platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/last-child-pseudo-class-expected.txt:
* platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/only-child-pseudo-class-expected.txt:
* platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
* platform/mac/fast/doctypes/002-expected.txt:
* platform/mac/fast/lists/001-expected.txt:
* platform/mac/fast/lists/001-vertical-expected.checksum:
* platform/mac/fast/lists/001-vertical-expected.png:
* platform/mac/fast/lists/001-vertical-expected.txt:
* platform/mac/fast/lists/002-expected.txt:
* platform/mac/fast/lists/002-vertical-expected.checksum:
* platform/mac/fast/lists/002-vertical-expected.png:
* platform/mac/fast/lists/002-vertical-expected.txt:
* platform/mac/fast/lists/003-expected.txt:
* platform/mac/fast/lists/003-vertical-expected.checksum:
* platform/mac/fast/lists/003-vertical-expected.png:
* platform/mac/fast/lists/003-vertical-expected.txt:
* platform/mac/fast/lists/007-vertical-expected.checksum:
* platform/mac/fast/lists/007-vertical-expected.png:
* platform/mac/fast/lists/007-vertical-expected.txt:
* platform/mac/fast/lists/008-vertical-expected.checksum:
* platform/mac/fast/lists/008-vertical-expected.png:
* platform/mac/fast/lists/008-vertical-expected.txt:
* platform/mac/fast/lists/outSideListMarkers-expected.checksum: Removed.
* platform/mac/fast/lists/outSideListMarkers-expected.png: Removed.
2010-11-22 Andreas Kling <kling@webkit.org>
 
Reviewed by Ariya Hidayat.
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x576
RenderBlock {H2} at (0,0) size 784x28
RenderText {#text} at (0,0) size 509x28
text run at (0,0) width 509: "The following lists have list-style-position: outside"
RenderBlock {P} at (0,47) size 784x18
RenderInline {U} at (0,0) size 105x18
RenderText {#text} at (0,0) size 105x18
text run at (0,0) width 105: "text-align: center"
RenderBlock {UL} at (0,81) size 784x54
RenderListItem {LI} at (40,0) size 744x18
RenderListMarker at (253,0) size 7x18: bullet
RenderText {#text} at (270,0) size 203x18
text run at (270,0) width 203: "Earl Grey Tea - A fine black tea"
RenderListItem {LI} at (40,18) size 744x18
RenderListMarker at (220,0) size 7x18: bullet
RenderText {#text} at (237,0) size 270x18
text run at (237,0) width 270: "Jasmine Tea - A fabulous \"all purpose\" tea"
RenderListItem {LI} at (40,36) size 744x18
RenderListMarker at (219,0) size 7x18: bullet
RenderText {#text} at (236,0) size 271x18
text run at (236,0) width 271: "Honeybush Tea - A super fruity delight tea"
RenderBlock (anonymous) at (0,151) size 784x18
RenderBR {BR} at (0,0) size 0x18
RenderBlock {P} at (0,185) size 784x18
RenderInline {U} at (0,0) size 96x18
RenderText {#text} at (0,0) size 96x18
text run at (0,0) width 96: "text-align: right"
RenderBlock {UL} at (0,219) size 784x54
RenderListItem {LI} at (40,0) size 744x18
RenderListMarker at (524,0) size 7x18: bullet
RenderText {#text} at (541,0) size 203x18
text run at (541,0) width 203: "Earl Grey Tea - A fine black tea"
RenderListItem {LI} at (40,18) size 744x18
RenderListMarker at (457,0) size 7x18: bullet
RenderText {#text} at (474,0) size 270x18
text run at (474,0) width 270: "Jasmine Tea - A fabulous \"all purpose\" tea"
RenderListItem {LI} at (40,36) size 744x18
RenderListMarker at (456,0) size 7x18: bullet
RenderText {#text} at (473,0) size 271x18
text run at (473,0) width 271: "Honeybush Tea - A super fruity delight tea"
RenderBlock {H2} at (0,292) size 784x28
RenderText {#text} at (0,0) size 509x28
text run at (0,0) width 509: "The following lists have list-style-position: outside"
RenderBlock {P} at (0,339) size 784x18
RenderInline {U} at (0,0) size 105x18
RenderText {#text} at (0,0) size 105x18
text run at (0,0) width 105: "text-align: center"
RenderBlock {UL} at (0,373) size 784x54
RenderListItem {LI} at (40,0) size 744x18
RenderListMarker at (253,0) size 7x18: bullet
RenderText {#text} at (270,0) size 203x18
text run at (270,0) width 203: "Earl Grey Tea - A fine black tea"
RenderListItem {LI} at (40,18) size 744x18
RenderListMarker at (220,0) size 7x18: bullet
RenderText {#text} at (237,0) size 270x18
text run at (237,0) width 270: "Jasmine Tea - A fabulous \"all purpose\" tea"
RenderListItem {LI} at (40,36) size 744x18
RenderListMarker at (219,0) size 7x18: bullet
RenderText {#text} at (236,0) size 271x18
text run at (236,0) width 271: "Honeybush Tea - A super fruity delight tea"
RenderBlock (anonymous) at (0,443) size 784x18
RenderBR {BR} at (0,0) size 0x18
RenderBlock {P} at (0,477) size 784x18
RenderInline {U} at (0,0) size 96x18
RenderText {#text} at (0,0) size 96x18
text run at (0,0) width 96: "text-align: right"
RenderBlock {UL} at (0,511) size 784x54
RenderListItem {LI} at (40,0) size 744x18
RenderListMarker at (524,0) size 7x18: bullet
RenderText {#text} at (541,0) size 203x18
text run at (541,0) width 203: "Earl Grey Tea - A fine black tea"
RenderListItem {LI} at (40,18) size 744x18
RenderListMarker at (457,0) size 7x18: bullet
RenderText {#text} at (474,0) size 270x18
text run at (474,0) width 270: "Jasmine Tea - A fabulous \"all purpose\" tea"
RenderListItem {LI} at (40,36) size 744x18
RenderListMarker at (456,0) size 7x18: bullet
RenderText {#text} at (473,0) size 271x18
text run at (473,0) width 271: "Honeybush Tea - A super fruity delight tea"
<html>
<head>
<style type="text/css">
ul.a {list-style-position:outside; text-align: center;}
ul.b {list-style-position:outside; text-align: right;}
</style>
</head>
<body>
<h2>The following lists have list-style-position: outside </h2>
<p><u>text-align: center</u></p>
<ul class="a">
<li>Earl Grey Tea - A fine black tea</li>
<li>Jasmine Tea - A fabulous "all purpose" tea</li>
<li>Honeybush Tea - A super fruity delight tea</li>
</ul> <br>
<p><u>text-align: right</u></p>
<ul class="b">
<li>Earl Grey Tea - A fine black tea</li>
<li>Jasmine Tea - A fabulous "all purpose" tea</li>
<li>Honeybush Tea - A super fruity delight tea</li>
</ul>
</body>
</html>
<html>
<head>
<style type="text/css">
ul.a {list-style-position:outside; text-align: center;}
ul.b {list-style-position:outside; text-align: right;}
</style>
</head>
<body>
<h2>The following lists have list-style-position: outside </h2>
<p><u>text-align: center</u></p>
<ul class="a">
<li>Earl Grey Tea - A fine black tea</li>
<li>Jasmine Tea - A fabulous "all purpose" tea</li>
<li>Honeybush Tea - A super fruity delight tea</li>
</ul> <br>
<p><u>text-align: right</u></p>
<ul class="b">
<li>Earl Grey Tea - A fine black tea</li>
<li>Jasmine Tea - A fabulous "all purpose" tea</li>
<li>Honeybush Tea - A super fruity delight tea</li>
</ul>
</body>
</html>
\ No newline at end of file
55d672967e8ddbf87246a11f92c9c729
\ No newline at end of file
535d07180f66e0a374faafc4b54b8962
\ No newline at end of file
fdd2eaba37bae8295f9aec88acefcb78
\ No newline at end of file
8fb1e154e79643ac7bbe9205dea3d03b
\ No newline at end of file
60d707dab81ad84c1f511fdfc375a655
\ No newline at end of file
d012e6bdb5ad2f5b2e533bedcbbc6789
\ No newline at end of file
bb6c3f97d3127b0e75e47ce1f426302a
\ No newline at end of file
870fc7a4b6d7194a482d5d782ed12201
\ No newline at end of file
74690022d6e9696f8a57d7fac76ef9f5
\ No newline at end of file
26b8e5f280430642b910f5238dc1c23f
\ No newline at end of file
cecb5833db1b0399f740243dfa067554
\ No newline at end of file
5ccd68b5eda1a8a6fdc3a2c3ad642323
\ No newline at end of file
d1ac2a47cf24b1fa807281fd778ec6e2
\ No newline at end of file
c3536f4b6e48b311bff7d09886204332
\ No newline at end of file
e45354862040a03e31b2190fb43f6979
\ No newline at end of file
d2b02cccba673c34576738f4fc873ad0
\ No newline at end of file
f36f002bef42315364af485a1f0d8113
\ No newline at end of file
3f7d246c4306b7b150771e8bbc17b769
\ No newline at end of file
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment