Clobbering window.console is not cool

https://bugs.webkit.org/show_bug.cgi?id=119364

Reviewed by Tim Horton.

full-screen-test.js overrides window.console, which is hella
confusing if you're trying to use console.log to debug a fullscreen test.

* fullscreen/full-screen-test.js:
(logConsole):
* fullscreen/resources/not-allowed.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 3c2e86d2
2013-07-31 Simon Fraser <simon.fraser@apple.com>
Clobbering window.console is not cool
https://bugs.webkit.org/show_bug.cgi?id=119364
Reviewed by Tim Horton.
full-screen-test.js overrides window.console, which is hella
confusing if you're trying to use console.log to debug a fullscreen test.
* fullscreen/full-screen-test.js:
(logConsole):
* fullscreen/resources/not-allowed.html:
2013-07-31 Mark Lam <mark.lam@apple.com>
Gardening: changing expectation for fast/forms/color/input-color-onchange-event.html
var console = null;
var consoleDiv = null;
var printFullTestDetails = true; // This is optionaly switched of by test whose tested values can differ. (see disableFullTestDetailsPrinting())
var runPixelTests;
......@@ -31,11 +31,11 @@ function runWithKeyDown(fn)
function logConsole()
{
if (!console && document.body) {
console = document.createElement('div');
document.body.appendChild(console);
if (!consoleDiv && document.body) {
consoleDiv = document.createElement('div');
document.body.appendChild(consoleDiv);
}
return console;
return consoleDiv;
}
function testAndEnd(testFuncString)
......
......@@ -3,5 +3,5 @@ Do not allow fullscreen from within a &lt;frame&gt; element, even with the <i>we
<p>To test manually, click the "Go full screen" button - the page should not enter full screen mode.</p>
<div id="console"></div>
<script>
top.console = document.getElementById('console');
top.consoleDiv = document.getElementById('console');
</script>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment