Commit 37773add authored by mitz@apple.com's avatar mitz@apple.com

Changing unicode-bidi doesn’t force layout

https://bugs.webkit.org/show_bug.cgi?id=53311

Reviewed by Anders Carlsson.

Source/WebCore: 

Test: fast/dynamic/unicode-bidi.html

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff): Return a layout difference if unicode-bidi values differ.

LayoutTests: 

* fast/dynamic/unicode-bidi-expected.checksum: Added.
* fast/dynamic/unicode-bidi-expected.png: Added.
* fast/dynamic/unicode-bidi-expected.txt: Added.
* fast/dynamic/unicode-bidi.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 23200c8b
2011-01-28 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
Changing unicode-bidi doesn’t force layout
https://bugs.webkit.org/show_bug.cgi?id=53311
* fast/dynamic/unicode-bidi-expected.checksum: Added.
* fast/dynamic/unicode-bidi-expected.png: Added.
* fast/dynamic/unicode-bidi-expected.txt: Added.
* fast/dynamic/unicode-bidi.html: Added.
2011-01-28 Jessie Berlin <jberlin@apple.com>
Add Windows expected (failing) results to get the bots green. Unreviewed.
9528d37c95c81e72cfeb81130fadc12d
\ No newline at end of file
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x600 layerType: background only
layer at (8,8) size 100x50
RenderBlock (positioned) zI: -1 {DIV} at (8,8) size 100x50 [color=#FF0000]
RenderInline {SPAN} at (0,0) size 50x50 [color=#008000]
RenderText {#text} at (0,0) size 50x50
text run at (0,0) width 50: "x"
RenderText zI: -1 {#text} at (50,0) size 50x50
text run at (50,0) width 50: "x"
layer at (0,0) size 800x600 layerType: foreground only
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderBlock {DIV} at (0,0) size 784x50 [color=#008000]
RenderText {#text} at (0,0) size 100x50
text run at (0,0) width 100 RTL override: "xp"
<div style="font: 50px ahem; -webkit-font-smoothing: none; direction: rtl; position: absolute; z-index: -1; color: red;"><span style="color: green;">x</span>x</div>
<div id="target" style="text-align: left; font: 50px ahem; -webkit-font-smoothing: none; direction: rtl; color: green;">xp</div>
<script>
document.body.offsetTop;
document.getElementById("target").style.unicodeBidi = "bidi-override";
</script>
2011-01-28 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
Changing unicode-bidi doesn’t force layout
https://bugs.webkit.org/show_bug.cgi?id=53311
Test: fast/dynamic/unicode-bidi.html
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff): Return a layout difference if unicode-bidi values differ.
2011-01-27 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
......@@ -462,7 +462,8 @@ StyleDifference RenderStyle::diff(const RenderStyle* other, unsigned& changedCon
inherited_flags._text_transform != other->inherited_flags._text_transform ||
inherited_flags._direction != other->inherited_flags._direction ||
inherited_flags._white_space != other->inherited_flags._white_space ||
noninherited_flags._clear != other->noninherited_flags._clear)
noninherited_flags._clear != other->noninherited_flags._clear ||
noninherited_flags._unicodeBidi != other->noninherited_flags._unicodeBidi)
return StyleDifferenceLayout;
// Check block flow direction.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment