Commit 36f3fe57 authored by ariya@webkit.org's avatar ariya@webkit.org

2009-05-13 Yael Aharon <yael.aharon@nokia.com>

        Reviewed by Ariya Hidayat.

        Move emitting the signal QWebFrame::urlChanged to FrameLoaderClientQt::dispatchDidCommitLoad().
        This is to ensure that urlChanged() is emitted even if the frame has no title.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
        (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 6d518789
2009-05-13 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Ariya Hidayat.
Move emitting the signal QWebFrame::urlChanged to FrameLoaderClientQt::dispatchDidCommitLoad().
This is to ensure that urlChanged() is emitted even if the frame has no title.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
2009-05-13 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Rubberstamped by Ariya Hidayat.
......
......@@ -338,10 +338,6 @@ void FrameLoaderClientQt::dispatchDidReceiveTitle(const String& title)
if (!m_webFrame)
return;
// ### hack
emit m_webFrame->urlChanged(m_webFrame->url());
emit titleChanged(title);
}
......@@ -354,6 +350,7 @@ void FrameLoaderClientQt::dispatchDidCommitLoad()
if (m_frame->tree()->parent() || !m_webFrame)
return;
emit m_webFrame->urlChanged(m_webFrame->url());
m_webFrame->page()->d->updateNavigationActions();
// We should assume first the frame has no title. If it has, then the above dispatchDidReceiveTitle()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment