From 34cd2f3130f967614f1572f0e854004ba92f55eb Mon Sep 17 00:00:00 2001
From: "eric@webkit.org" <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu, 1 Oct 2009 22:21:34 +0000
Subject: [PATCH] 2009-10-01  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Make it possible to override the list of feature defines when building
        downstream.

        https://bugs.webkit.org/show_bug.cgi?id=29979

        * chromium/features.gypi:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 WebKit/ChangeLog              | 11 +++++++
 WebKit/chromium/features.gypi | 61 ++++++++++++++++++++---------------
 2 files changed, 46 insertions(+), 26 deletions(-)

diff --git a/WebKit/ChangeLog b/WebKit/ChangeLog
index 012ca4af9f0..1c991b22112 100644
--- a/WebKit/ChangeLog
+++ b/WebKit/ChangeLog
@@ -1,3 +1,14 @@
+2009-10-01  Yaar Schnitman  <yaar@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Make it possible to override the list of feature defines when building
+        downstream.
+
+        https://bugs.webkit.org/show_bug.cgi?id=29979
+
+        * chromium/features.gypi:
+
 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
 
         Reviewed by Dimitri Glazkov.
diff --git a/WebKit/chromium/features.gypi b/WebKit/chromium/features.gypi
index adcb5274a6a..a559680a03f 100644
--- a/WebKit/chromium/features.gypi
+++ b/WebKit/chromium/features.gypi
@@ -29,32 +29,41 @@
 #
 
 {
-  # The following defines turn webkit features on or off. 
+  # The following defines turn webkit features on and off.
   'variables': {
-    'feature_defines': [
-      'ENABLE_3D_CANVAS=0',
-      'ENABLE_CHANNEL_MESSAGING=1',
-      'ENABLE_DATABASE=1',
-      'ENABLE_DATAGRID=0',
-      'ENABLE_OFFLINE_WEB_APPLICATIONS=1',
-      'ENABLE_DASHBOARD_SUPPORT=0',
-      'ENABLE_DOM_STORAGE=1',
-      'ENABLE_JAVASCRIPT_DEBUGGER=0',
-      'ENABLE_JSC_MULTIPLE_THREADS=0',
-      'ENABLE_ICONDATABASE=0',
-      'ENABLE_NOTIFICATIONS=0',
-      'ENABLE_ORIENTATION_EVENTS=0',
-      'ENABLE_XSLT=1',
-      'ENABLE_XPATH=1',
-      'ENABLE_SHARED_WORKERS=0',
-      'ENABLE_SVG=1',
-      'ENABLE_SVG_ANIMATION=1',
-      'ENABLE_SVG_AS_IMAGE=1',
-      'ENABLE_SVG_USE=1',
-      'ENABLE_SVG_FOREIGN_OBJECT=1',
-      'ENABLE_SVG_FONTS=1',
-      'ENABLE_VIDEO=1',
-      'ENABLE_WORKERS=1',
-    ],
+    'variables': {
+      # We have to nest variables inside variables as a hack for variables
+      # override.
+
+      # WARNING: build/features_override.gypi which is included in a full
+      # chromium build, overrides this list with its own values. See
+      # features_override.gypi inline documentation for more details.
+      'feature_defines%': [
+        'ENABLE_3D_CANVAS=0',
+        'ENABLE_CHANNEL_MESSAGING=1',
+        'ENABLE_DATABASE=1',
+        'ENABLE_DATAGRID=0',
+        'ENABLE_OFFLINE_WEB_APPLICATIONS=1',
+        'ENABLE_DASHBOARD_SUPPORT=0',
+        'ENABLE_DOM_STORAGE=1',
+        'ENABLE_JAVASCRIPT_DEBUGGER=0',
+        'ENABLE_JSC_MULTIPLE_THREADS=0',
+        'ENABLE_ICONDATABASE=0',
+        'ENABLE_NOTIFICATIONS=0',
+        'ENABLE_ORIENTATION_EVENTS=0',
+        'ENABLE_XSLT=1',
+        'ENABLE_XPATH=1',
+        'ENABLE_SHARED_WORKERS=0',
+        'ENABLE_SVG=1',
+        'ENABLE_SVG_ANIMATION=1',
+        'ENABLE_SVG_AS_IMAGE=1',
+        'ENABLE_SVG_USE=1',
+        'ENABLE_SVG_FOREIGN_OBJECT=1',
+        'ENABLE_SVG_FONTS=1',
+        'ENABLE_VIDEO=1',
+        'ENABLE_WORKERS=1',
+      ],
+    },
+    'feature_defines%': '<(feature_defines)',
   },
 }
-- 
GitLab