Commit 3296b190 authored by trey's avatar trey
Browse files

3135025 - Assertion failure in _transitionToCommitted on espn nba scoreboard

	For blank pages we decided that there would be no b/f entry.  This means that
	subframes within such pages (created via doc.write()), should not try to make
	WebHistoryItems, since they have no parent items to attach them to.

        Reviewed by Darin.

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted:]):  Don't make a history item for a subframe
	it the parent frame has no item.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 8e8091f7
2002-12-30 Trey Matteson <trey@apple.com>
3135025 - Assertion failure in _transitionToCommitted on espn nba scoreboard
For blank pages we decided that there would be no b/f entry. This means that
subframes within such pages (created via doc.write()), should not try to make
WebHistoryItems, since they have no parent items to attach them to.
Reviewed by Darin.
* WebView.subproj/WebFramePrivate.m:
(-[WebFrame _transitionToCommitted:]): Don't make a history item for a subframe
it the parent frame has no item.
2002-12-30 Trey Matteson <trey@apple.com>
3135779 - REGRESSION: reproducible assertion failure, going back from ~orubin to the main spies.com page
......
......@@ -597,8 +597,12 @@ - (void)_transitionToCommitted: (NSDictionary *)pageCache
case WebFrameLoadTypeInternal:
// Add an item to the item tree for this frame
ASSERT(![ds _isClientRedirect]);
ASSERT([[self parent]->_private currentItem]);
[[[self parent]->_private currentItem] addChildItem:[self _createItem]];
WebHistoryItem *parentItem = [[self parent]->_private currentItem];
// The only case where parentItem==nil should be when a parent frame loaded an
// empty URL, which doesn't set up a current item in that parent.
if (parentItem) {
[parentItem addChildItem:[self _createItem]];
}
[self _makeDocumentView];
break;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment