Commit 32371a87 authored by eric@webkit.org's avatar eric@webkit.org
Browse files

2009-12-02 Adam Barth <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] build-attachment shouldn't check whether the builders are red
        https://bugs.webkit.org/show_bug.cgi?id=32062

        build-attachment doesn't touch the remote repository, so there isn't a
        need to hold off when the builders are red.

        * Scripts/modules/commands/download.py:
        * Scripts/modules/landingsequence.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 437aabef
2009-12-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
[bzt] build-attachment shouldn't check whether the builders are red
https://bugs.webkit.org/show_bug.cgi?id=32062
build-attachment doesn't touch the remote repository, so there isn't a
need to hold off when the builders are red.
* Scripts/modules/commands/download.py:
* Scripts/modules/landingsequence.py:
2009-12-02 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
......
......@@ -129,6 +129,7 @@ class LandDiffSequence(ConditionalLandingSequence):
ConditionalLandingSequence.__init__(self, patch, options, tool)
def run(self):
self.check_builders()
self.build()
self.test()
commit_log = self.commit()
......
......@@ -51,6 +51,7 @@ class LandingSequence:
self.clean()
self.update()
self.apply_patch()
self.check_builders()
self.build()
self.test()
commit_log = self.commit()
......@@ -82,10 +83,10 @@ class LandingSequence:
log("Processing patch %s from bug %s." % (self._patch["id"], self._patch["bug_id"]))
self._tool.scm().apply_patch(self._patch, force=self._options.non_interactive)
def build(self):
# Make sure the tree is still green after updating, before building this patch.
# The first patch ends up checking tree status twice, but that's OK.
def check_builders(self):
self._tool.steps.ensure_builders_are_green(self._tool.buildbot, self._options)
def build(self):
self._tool.steps.build_webkit(quiet=self._options.quiet, port=self._port)
def test(self):
......@@ -120,6 +121,10 @@ class ConditionalLandingSequence(LandingSequence):
if self._options.update:
LandingSequence.update(self)
def check_builders(self):
if self._options.build:
LandingSequence.check_builders(self)
def build(self):
if self._options.build:
LandingSequence.build(self)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment