Commit 3015559a authored by rakuco@webkit.org's avatar rakuco@webkit.org

[EFL][WK2] REGRESSION(r132342): fast/events/frame-tab-focus.html fails

https://bugs.webkit.org/show_bug.cgi?id=100646

Reviewed by Kenneth Rohde Christiansen.

Tools: 

* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::focus): Improve the check we perform to
decide whether the focus should be taken out of the view before
focusing it again so that we do not unnecessarily unfocus it and
cause blur/focus events to be triggered. Instead of just verifying
if the Evas_Object representing the view has focus, use the WK C
API to check that the currently focused frame is not the main
frame.

LayoutTests: 

* platform/efl-wk2/TestExpectations: Unskip
fast/events/frame-tab-focus.html.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 187c9352
2012-10-29 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
[EFL][WK2] REGRESSION(r132342): fast/events/frame-tab-focus.html fails
https://bugs.webkit.org/show_bug.cgi?id=100646
Reviewed by Kenneth Rohde Christiansen.
* platform/efl-wk2/TestExpectations: Unskip
fast/events/frame-tab-focus.html.
2012-10-29 Michelangelo De Simone <michelangelo@webkit.org>
[CSS Shaders] Implement CustomFilterArrayParameter::blend
......@@ -275,6 +275,3 @@ webkit.org/b/96641 media/video-seek-past-end-playing.html [ Failure ]
webkit.org/b/91854 editing/spelling [ Skip ]
webkit.org/b/100248 fast/forms/select-multiple-elements-with-mouse-drag.html [ Failure ]
# Spurious output after fixing flakiness
webkit.org/b/100010 fast/events/frame-tab-focus.html [ Failure ]
2012-10-29 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
[EFL][WK2] REGRESSION(r132342): fast/events/frame-tab-focus.html fails
https://bugs.webkit.org/show_bug.cgi?id=100646
Reviewed by Kenneth Rohde Christiansen.
* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::focus): Improve the check we perform to
decide whether the focus should be taken out of the view before
focusing it again so that we do not unnecessarily unfocus it and
cause blur/focus events to be triggered. Instead of just verifying
if the Evas_Object representing the view has focus, use the WK C
API to check that the currently focused frame is not the main
frame.
2012-10-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r132782.
......
......@@ -69,10 +69,10 @@ WKPageRef PlatformWebView::page()
void PlatformWebView::focus()
{
// Force the view to receive focus even if Evas considers it to be focused; sometimes an iframe might receive
// focused via JavaScript and the main frame is considered unfocused, but that is not noticed by Evas.
// Perhaps WebCoreSupport::focusedFrameChanged() should emit some sort of notification?
if (evas_object_focus_get(m_view))
// In a few cases, an iframe might receive focus from JavaScript and Evas is not aware of it at all
// (WebCoreSupport::focusedFrameChanged() does not emit any notification). We then manually remove the
// focus from the view to make the call give focus to evas_object_focus_set(..., true) to be effectful.
if (WKPageGetFocusedFrame(page()) != WKPageGetMainFrame(page()))
evas_object_focus_set(m_view, false);
evas_object_focus_set(m_view, true);
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment