Commit 2f1fee03 authored by mitz@apple.com's avatar mitz@apple.com

WebCore:

        Reviewed by Oliver Hunt.

        - fix <rdar://problem/6525618> REGRESSION (r39566): NewsFire crashes in
          string hashing code when opening a Digg RSS article

        Test: fast/loader/null-request-after-willSendRequest.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadItem): Null-check the request returned from
        the client's willSendRequest method.

LayoutTests:

        Reviewed by Oliver Hunt.

        - test for <rdar://problem/6525618> REGRESSION (r39566): NewsFire crashes in
          string hashing code when opening a Digg RSS article

        * fast/loader/null-request-after-willSendRequest-expected.txt: Added.
        * fast/loader/null-request-after-willSendRequest.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent e007fb25
2009-01-25 Dan Bernstein <mitz@apple.com>
Reviewed by Oliver Hunt.
- test for <rdar://problem/6525618> REGRESSION (r39566): NewsFire crashes in
string hashing code when opening a Digg RSS article
* fast/loader/null-request-after-willSendRequest-expected.txt: Added.
* fast/loader/null-request-after-willSendRequest.html: Added.
2009-01-24 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
......
Blocked access to external URL http://10.0.0.1/
Test for rdar://problem/6525618 REGRESSION (r39566): NewsFire crashes in string hashing code when opening a Digg RSS article.
This test cannot be run in the browser. In DumpRenderTree it should report that access to http://10.0.0.1/ was blocked and not crash.
<p>
Test for <i><a href="rdar://problem/6525618">rdar://problem/6525618</a> REGRESSION (r39566): NewsFire crashes in string hashing code when opening a Digg RSS article</i>.
</p>
<p>
This test cannot be run in the browser. In DumpRenderTree it should report
that access to http://10.0.0.1/ was blocked and not crash.
</p>
<img src="http://10.0.0.1/">
<script>
if (window.layoutTestController)
layoutTestController.dumpAsText();
</script>
2009-01-25 Dan Bernstein <mitz@apple.com>
Reviewed by Oliver Hunt.
- fix <rdar://problem/6525618> REGRESSION (r39566): NewsFire crashes in
string hashing code when opening a Digg RSS article
Test: fast/loader/null-request-after-willSendRequest.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadItem): Null-check the request returned from
the client's willSendRequest method.
2009-01-25 David Hyatt <hyatt@apple.com>
Fix for <rdar://problem/6525392> REGRESSION (r40180): Scroll wheel events over text scroll the page
......@@ -5250,7 +5250,7 @@ void FrameLoader::dispatchWillSendRequest(DocumentLoader* loader, unsigned long
m_client->dispatchWillSendRequest(loader, identifier, request, redirectResponse);
// If the URL changed, then we want to put that new URL in the "did tell client" set too.
if (oldRequestURL != request.url().string().impl())
if (!request.isNull() && oldRequestURL != request.url().string().impl())
m_documentLoader->didTellClientAboutLoad(request.url());
if (Page* page = m_frame->page())
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment