Commit 2e76acd6 authored by ryuan.choi@samsung.com's avatar ryuan.choi@samsung.com
Browse files

[EFL][CoordinatedGraphics] Clear m_contentsSize when new contents are loaded

https://bugs.webkit.org/show_bug.cgi?id=125033

Reviewed by Gyuyoung Kim.

m_contentsSize should be cleared when new contents are loaded so that PageViewportController
would take care of newly loaded contents with same size as previous one.
It's because PageViewportController is cleared not to make wrong behaviour
while loading when new contents are committed.

* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
Improve tests to check contents,size,changed signal when loaded contents having
same size with previous one.
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::didCommitLoadForMainFrame): Cleared m_contentsSize.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 6a30a969
2013-12-01 Ryuan Choi <ryuan.choi@samsung.com>
[EFL][CoordinatedGraphics] Clear m_contentsSize when new contents are loaded
https://bugs.webkit.org/show_bug.cgi?id=125033
Reviewed by Gyuyoung Kim.
m_contentsSize should be cleared when new contents are loaded so that PageViewportController
would take care of newly loaded contents with same size as previous one.
It's because PageViewportController is cleared not to make wrong behaviour
while loading when new contents are committed.
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
Improve tests to check contents,size,changed signal when loaded contents having
same size with previous one.
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::didCommitLoadForMainFrame): Cleared m_contentsSize.
2013-12-01 Philippe Normand <pnormand@igalia.com>
Unreviewed GTK build fix after r159896.
......
......@@ -986,6 +986,13 @@ TEST_F(EWK2ViewTest, ewk_view_contents_size_changed)
sizeChanged = false;
while (!sizeChanged)
ecore_main_loop_iterate();
// Make sure we get signal after loaded the contents having same size with previous one.
sizeChanged = false;
ewk_view_html_string_load(webView(), contentsSizeHTMLPortrait, 0, 0);
while (!sizeChanged)
ecore_main_loop_iterate();
evas_object_smart_callback_del(webView(), "contents,size,changed", onContentsSizeChangedPortrait);
}
......
......@@ -373,7 +373,7 @@ void WebView::toolTipChanged(const String&, const String& newToolTip)
void WebView::didCommitLoadForMainFrame()
{
notImplemented();
m_contentsSize = IntSize();
}
void WebView::setCursor(const WebCore::Cursor&)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment