Commit 2d6e4328 authored by dbates@webkit.org's avatar dbates@webkit.org

2009-10-07 Daniel Bates <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=30188
        
        Fixes an issue where performing a non DHTML drag-and-drop operation 
        does not work as expected. For instance, dragging some selected text 
        to an external application, such as TextEdit.
        
        This issue was a regression that arose from patching bug #30107.
        
        This change is covered by the manual test: 
        drag-out-of-background-window.html

        * page/DragController.cpp:
        (WebCore::DragController::startDrag): When performing a non-DHTML drag 
        operation then default to drag operations DragOperationGeneric and 
        DragOperationCopy according to similar functionality removed when fixing
        bug #30107, see: 
        http://trac.webkit.org/browser/trunk/WebKit/mac/WebView/WebHTMLView.mm?rev=48526#L3430 


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent f7dd1609
2009-10-07 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=30188
Fixes an issue where performing a non DHTML drag-and-drop operation
does not work as expected. For instance, dragging some selected text
to an external application, such as TextEdit.
This issue was a regression that arose from patching bug #30107.
This change is covered by the manual test:
drag-out-of-background-window.html
* page/DragController.cpp:
(WebCore::DragController::startDrag): When performing a non-DHTML drag
operation then default to drag operations DragOperationGeneric and
DragOperationCopy according to similar functionality removed when fixing
bug #30107, see:
http://trac.webkit.org/browser/trunk/WebKit/mac/WebView/WebHTMLView.mm?rev=48526#L3430
2009-10-07 Xan Lopez <xlopez@igalia.com>
Fix more breakage in the GTK+ build.
......@@ -649,6 +649,12 @@ bool DragController::startDrag(Frame* src, Clipboard* clipboard, DragOperation s
if (isDHTMLDrag)
dragImage = clipboard->createDragImage(dragImageOffset);
else {
// This drag operation is not a DHTML drag and may go outside the WebView.
// We provide a default set of allowed drag operations that follows from:
// http://trac.webkit.org/browser/trunk/WebKit/mac/WebView/WebHTMLView.mm?rev=48526#L3430
m_sourceDragOperation = (DragOperation)(DragOperationGeneric | DragOperationCopy);
}
// We allow DHTML/JS to set the drag image, even if its a link, image or text we're dragging.
// This is in the spirit of the IE API, which allows overriding of pasteboard data and DragOp.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment