Commit 28e2b6e1 authored by eric@webkit.org's avatar eric@webkit.org

2009-10-02 Dave MacLachlan <dmaclach@gmail.com>

        Reviewed by David Levin.

        Clean up warnings in WebCore/bindings/v8/npruntime.cpp
        https://bugs.webkit.org/show_bug.cgi?id=29971

        Gets rid of warnings on gcc about using anonymous namespaces
          warning: 'StringKeyHashTraits' has a base
          'WTF::GenericHashTraits<<unnamed>::StringKey>'
          whose type uses the anonymous namespace
        and
          warning: 'WTF::PairHashTraits<StringKeyHashTraits,
          WTF::HashTraits<PrivateIdentifier*> >' has a base
          'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey,
          PrivateIdentifier*> >' whose type uses the anonymous namespace

        No tests required.

        * bindings/v8/npruntime.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@49011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent e71435ec
2009-10-02 Dave MacLachlan <dmaclach@gmail.com>
Reviewed by David Levin.
Clean up warnings in WebCore/bindings/v8/npruntime.cpp
https://bugs.webkit.org/show_bug.cgi?id=29971
Gets rid of warnings on gcc about using anonymous namespaces
warning: 'StringKeyHashTraits' has a base
'WTF::GenericHashTraits<<unnamed>::StringKey>'
whose type uses the anonymous namespace
and
warning: 'WTF::PairHashTraits<StringKeyHashTraits,
WTF::HashTraits<PrivateIdentifier*> >' has a base
'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey,
PrivateIdentifier*> >' whose type uses the anonymous namespace
No tests required.
* bindings/v8/npruntime.cpp:
2009-10-01 Mark Rowe <mrowe@apple.com> 2009-10-01 Mark Rowe <mrowe@apple.com>
Fix the Tiger build. Don't unconditionally enable 3D canvas as it is not supported on Tiger. Fix the Tiger build. Don't unconditionally enable 3D canvas as it is not supported on Tiger.
...@@ -39,7 +39,7 @@ ...@@ -39,7 +39,7 @@
// The static initializer here should work okay, but we want to avoid // The static initializer here should work okay, but we want to avoid
// static initialization in general. // static initialization in general.
namespace { namespace npruntime {
// We use StringKey here as the key-type to avoid a string copy to // We use StringKey here as the key-type to avoid a string copy to
// construct the map key and for faster comparisons than strcmp. // construct the map key and for faster comparisons than strcmp.
...@@ -112,7 +112,10 @@ struct StringKeyHash { ...@@ -112,7 +112,10 @@ struct StringKeyHash {
static const bool safeToCompareToEmptyOrDeleted = true; static const bool safeToCompareToEmptyOrDeleted = true;
}; };
} // namespace } // namespace npruntime
using npruntime::StringKey;
using npruntime::StringKeyHash;
// Implement HashTraits<StringKey> // Implement HashTraits<StringKey>
struct StringKeyHashTraits : WTF::GenericHashTraits<StringKey> { struct StringKeyHashTraits : WTF::GenericHashTraits<StringKey> {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment