Commit 27aeb88f authored by robert@webkit.org's avatar robert@webkit.org
Browse files

2010-09-06 Robert Hogan <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] utf8 encoding of console() messages

        Unskip:
        http/tests/security/xssAuditor/embed-tag-null-char.html
        http/tests/security/xssAuditor/object-embed-tag-null-char.html

        Both tests failed because Qt's implementation of String::format()
        is casting a utf8 result to String, which assumes latin1 in
        its constructor. So instead of casting a QString to a String, use
        StringImpl::create() instead. Unfortunately, this involves a lot
        of extra casts but the end result is correct.

        https://bugs.webkit.org/show_bug.cgi?id=45240

        * wtf/text/WTFString.cpp:
        (WTF::String::format):
2010-09-06  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] utf8 encoding of console() messages

        Unskip:
        http/tests/security/xssAuditor/embed-tag-null-char.html
        http/tests/security/xssAuditor/object-embed-tag-null-char.html

        Both tests failed because Qt's implementation of String::format()
        is casting a utf8 result to String, which assumes latin1 in
        its constructor. So instead of casting a QString to a String, use
        StringImpl::create() instead. Unfortunately, this involves a lot
        of extra casts but the end result is correct.

        https://bugs.webkit.org/show_bug.cgi?id=45240

        * platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 2bfe1fd5
2010-09-06 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] utf8 encoding of console() messages
Unskip:
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html
Both tests failed because Qt's implementation of String::format()
is casting a utf8 result to String, which assumes latin1 in
its constructor. So instead of casting a QString to a String, use
StringImpl::create() instead. Unfortunately, this involves a lot
of extra casts but the end result is correct.
https://bugs.webkit.org/show_bug.cgi?id=45240
* wtf/text/WTFString.cpp:
(WTF::String::format):
2010-09-03 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
......
......@@ -335,7 +335,7 @@ String String::format(const char *format, ...)
va_end(args);
return buffer;
return StringImpl::create(buffer.constData(), buffer.length());
#elif OS(WINCE)
va_list args;
......
2010-09-06 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] utf8 encoding of console() messages
Unskip:
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html
Both tests failed because Qt's implementation of String::format()
is casting a utf8 result to String, which assumes latin1 in
its constructor. So instead of casting a QString to a String, use
StringImpl::create() instead. Unfortunately, this involves a lot
of extra casts but the end result is correct.
https://bugs.webkit.org/show_bug.cgi?id=45240
* platform/qt/Skipped:
2010-09-06 Justin Schuh <jschuh@chromium.org>
 
Unreviewed. Build fix.
......@@ -181,11 +181,6 @@ http/tests/security/frameNavigation/not-opener.html
# missing origin header
http/tests/security/originHeader/origin-header-for-empty.html
# Possibly related to https://bugs.webkit.org/show_bug.cgi?id=35263
# are we utf-encoding a string twice over?
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html
# Disabled HTTP subdirs for now, needs investigation.
http/tests/media
http/tests/wml
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment