Commit 278aaeaf authored by mihaip@chromium.org's avatar mihaip@chromium.org

[Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime

https://bugs.webkit.org/show_bug.cgi?id=95865

Reviewed by Darin Fisher.

Source/WebCore:

r55549 made them be runtime-enabled (since the Chromium implementation
was not complete at the time), but they've been enabled by default
since http://crrev.com/41850

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
* page/History.idl:

Source/WebKit/chromium:

Make WebRuntimeFeatures::{enablePushState,isPushStateEnabled} into
no-ops.

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enablePushState):
(WebKit::WebRuntimeFeatures::isPushStateEnabled):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 69e4642f
2012-09-05 Mihai Parparita <mihaip@chromium.org>
[Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime
https://bugs.webkit.org/show_bug.cgi?id=95865
Reviewed by Darin Fisher.
r55549 made them be runtime-enabled (since the Chromium implementation
was not complete at the time), but they've been enabled by default
since http://crrev.com/41850
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
* page/History.idl:
2012-09-05 Joshua Bell <jsbell@chromium.org> 2012-09-05 Joshua Bell <jsbell@chromium.org>
IndexedDB: Integer version lost after first open/close/open cycle IndexedDB: Integer version lost after first open/close/open cycle
...@@ -50,7 +50,6 @@ bool RuntimeEnabledFeatures::isDataTransferItemsEnabled = true; ...@@ -50,7 +50,6 @@ bool RuntimeEnabledFeatures::isDataTransferItemsEnabled = true;
bool RuntimeEnabledFeatures::isGeolocationEnabled = true; bool RuntimeEnabledFeatures::isGeolocationEnabled = true;
bool RuntimeEnabledFeatures::isIndexedDBEnabled = false; bool RuntimeEnabledFeatures::isIndexedDBEnabled = false;
bool RuntimeEnabledFeatures::isWebAudioEnabled = false; bool RuntimeEnabledFeatures::isWebAudioEnabled = false;
bool RuntimeEnabledFeatures::isPushStateEnabled = false;
bool RuntimeEnabledFeatures::isTouchEnabled = true; bool RuntimeEnabledFeatures::isTouchEnabled = true;
bool RuntimeEnabledFeatures::isDeviceMotionEnabled = true; bool RuntimeEnabledFeatures::isDeviceMotionEnabled = true;
bool RuntimeEnabledFeatures::isDeviceOrientationEnabled = true; bool RuntimeEnabledFeatures::isDeviceOrientationEnabled = true;
......
...@@ -129,10 +129,6 @@ public: ...@@ -129,10 +129,6 @@ public:
static bool webkitAudioContextEnabled() { return isWebAudioEnabled; } static bool webkitAudioContextEnabled() { return isWebAudioEnabled; }
#endif #endif
static void setPushStateEnabled(bool isEnabled) { isPushStateEnabled = isEnabled; }
static bool pushStateEnabled() { return isPushStateEnabled; }
static bool replaceStateEnabled() { return isPushStateEnabled; }
#if ENABLE(TOUCH_EVENTS) #if ENABLE(TOUCH_EVENTS)
static bool touchEnabled() { return isTouchEnabled; } static bool touchEnabled() { return isTouchEnabled; }
static void setTouchEnabled(bool isEnabled) { isTouchEnabled = isEnabled; } static void setTouchEnabled(bool isEnabled) { isTouchEnabled = isEnabled; }
...@@ -276,7 +272,6 @@ private: ...@@ -276,7 +272,6 @@ private:
static bool isGeolocationEnabled; static bool isGeolocationEnabled;
static bool isIndexedDBEnabled; static bool isIndexedDBEnabled;
static bool isWebAudioEnabled; static bool isWebAudioEnabled;
static bool isPushStateEnabled;
static bool isTouchEnabled; static bool isTouchEnabled;
static bool isDeviceMotionEnabled; static bool isDeviceMotionEnabled;
static bool isDeviceOrientationEnabled; static bool isDeviceOrientationEnabled;
......
...@@ -20,7 +20,7 @@ ...@@ -20,7 +20,7 @@
* PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
* OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/ */
module window { module window {
...@@ -42,10 +42,10 @@ module window { ...@@ -42,10 +42,10 @@ module window {
[DoNotCheckSecurity, CallWith=ScriptExecutionContext] void back(); [DoNotCheckSecurity, CallWith=ScriptExecutionContext] void back();
[DoNotCheckSecurity, CallWith=ScriptExecutionContext] void forward(); [DoNotCheckSecurity, CallWith=ScriptExecutionContext] void forward();
[DoNotCheckSecurity, CallWith=ScriptExecutionContext] void go(in [Optional=DefaultIsUndefined] long distance); [DoNotCheckSecurity, CallWith=ScriptExecutionContext] void go(in [Optional=DefaultIsUndefined] long distance);
[Custom, V8EnabledAtRuntime] void pushState(in any data, in DOMString title, in [Optional] DOMString url) [Custom] void pushState(in any data, in DOMString title, in [Optional] DOMString url)
raises(DOMException); raises(DOMException);
[Custom, V8EnabledAtRuntime] void replaceState(in any data, in DOMString title, in [Optional] DOMString url) [Custom] void replaceState(in any data, in DOMString title, in [Optional] DOMString url)
raises(DOMException); raises(DOMException);
}; };
......
2012-09-05 Mihai Parparita <mihaip@chromium.org>
[Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime
https://bugs.webkit.org/show_bug.cgi?id=95865
Reviewed by Darin Fisher.
Make WebRuntimeFeatures::{enablePushState,isPushStateEnabled} into
no-ops.
* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enablePushState):
(WebKit::WebRuntimeFeatures::isPushStateEnabled):
2012-09-05 Mark Pilgrim <pilgrim@chromium.org> 2012-09-05 Mark Pilgrim <pilgrim@chromium.org>
[Chromium] Remove getRenderStyleForStrike from PlatformSupport [Chromium] Remove getRenderStyleForStrike from PlatformSupport
......
...@@ -63,7 +63,7 @@ public: ...@@ -63,7 +63,7 @@ public:
WEBKIT_EXPORT static void enableApplicationCache(bool); WEBKIT_EXPORT static void enableApplicationCache(bool);
WEBKIT_EXPORT static bool isApplicationCacheEnabled(); WEBKIT_EXPORT static bool isApplicationCacheEnabled();
WEBKIT_EXPORT static void enableDataTransferItems(bool); WEBKIT_EXPORT static void enableDataTransferItems(bool);
WEBKIT_EXPORT static bool isDataTransferItemsEnabled(); WEBKIT_EXPORT static bool isDataTransferItemsEnabled();
...@@ -76,6 +76,7 @@ public: ...@@ -76,6 +76,7 @@ public:
WEBKIT_EXPORT static void enableWebAudio(bool); WEBKIT_EXPORT static void enableWebAudio(bool);
WEBKIT_EXPORT static bool isWebAudioEnabled(); WEBKIT_EXPORT static bool isWebAudioEnabled();
// TODO: Remove these (since they're no-ops) once Chromium code stops calling them.
WEBKIT_EXPORT static void enablePushState(bool); WEBKIT_EXPORT static void enablePushState(bool);
WEBKIT_EXPORT static bool isPushStateEnabled(bool); WEBKIT_EXPORT static bool isPushStateEnabled(bool);
...@@ -99,7 +100,7 @@ public: ...@@ -99,7 +100,7 @@ public:
WEBKIT_EXPORT static void enableFileSystem(bool); WEBKIT_EXPORT static void enableFileSystem(bool);
WEBKIT_EXPORT static bool isFileSystemEnabled(); WEBKIT_EXPORT static bool isFileSystemEnabled();
WEBKIT_EXPORT static void enableJavaScriptI18NAPI(bool); WEBKIT_EXPORT static void enableJavaScriptI18NAPI(bool);
WEBKIT_EXPORT static bool isJavaScriptI18NAPIEnabled(); WEBKIT_EXPORT static bool isJavaScriptI18NAPIEnabled();
......
...@@ -204,14 +204,13 @@ bool WebRuntimeFeatures::isWebAudioEnabled() ...@@ -204,14 +204,13 @@ bool WebRuntimeFeatures::isWebAudioEnabled()
#endif #endif
} }
void WebRuntimeFeatures::enablePushState(bool enable) void WebRuntimeFeatures::enablePushState(bool)
{ {
RuntimeEnabledFeatures::setPushStateEnabled(enable);
} }
bool WebRuntimeFeatures::isPushStateEnabled(bool enable) bool WebRuntimeFeatures::isPushStateEnabled(bool enable)
{ {
return RuntimeEnabledFeatures::pushStateEnabled(); return true;
} }
void WebRuntimeFeatures::enableTouch(bool enable) void WebRuntimeFeatures::enableTouch(bool enable)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment