Commit 26df767f authored by alex@webkit.org's avatar alex@webkit.org

2010-12-09 Alejandro G. Castro <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add hasSpellingMarker support to the DRT
        https://bugs.webkit.org/show_bug.cgi?id=50739

        Added a new private API function to support the spelling marker
        tests in the DRT.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

2010-12-10  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add hasSpellingMarker support to the DRT
        https://bugs.webkit.org/show_bug.cgi?id=50739

        Implemented the hasSpellingMarker to support spelling tests.

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::hasSpellingMarker):

2010-12-10  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add hasSpellingMarker support to the DRT
        https://bugs.webkit.org/show_bug.cgi?id=50739

        Unskipped spelling tests and added a bug for the one failing,
        added results for a new ones also.

        * platform/gtk/Skipped:
        * platform/gtk/editing/spelling/inline_spelling_markers-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 45662cb0
2010-12-10 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add hasSpellingMarker support to the DRT
https://bugs.webkit.org/show_bug.cgi?id=50739
Unskipped spelling tests and added a bug for the one failing,
added results for a new ones also.
* platform/gtk/Skipped:
* platform/gtk/editing/spelling/inline_spelling_markers-expected.txt: Added.
2010-12-10 Joone Hur <joone@kldp.org>
Reviewed by Xan Lopez.
......
......@@ -964,13 +964,6 @@ editing/selection/unrendered-004.html
editing/selection/unrendered-005.html
editing/selection/unrendered-space.html
editing/selection/word-granularity.html
editing/spelling/inline_spelling_markers.html
editing/spelling/spellcheck-attribute.html
editing/spelling/spelling-hasspellingmarker.html
editing/spelling/spelling-backspace-between-lines.html
editing/spelling/spelling-linebreak.html
editing/spelling/spelling-attribute-change.html
editing/spelling/spelling-attribute-at-child.html
editing/style/5065910.html
editing/style/apple-style-editable-mix.html
editing/style/block-style-001.html
......@@ -5572,3 +5565,6 @@ media/controls-without-preload.html
fast/history/history-back-initial-vs-final-url.html
http/tests/navigation/post-frames-goback1.html
http/tests/navigation/postredirect-frames-goback1.html
# https://bugs.webkit.org/show_bug.cgi?id=50740
editing/spelling/spelling-backspace-between-lines.html
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderBlock {P} at (0,0) size 784x38
RenderText {#text} at (0,0) size 494x19
text run at (0,0) width 494: "This tests the correct placement of inline spelling and grammar markers in text."
RenderBR {BR} at (494,15) size 0x0
RenderText {#text} at (0,19) size 477x19
text run at (0,19) width 477: "Spelling markers should line up exactly under misspelled words in all cases."
RenderBlock (anonymous) at (0,54) size 784x19
RenderText {#text} at (0,0) size 31x19
text run at (0,0) width 31: "LTR"
RenderBlock (anonymous) at (0,95) size 784x19
RenderText {#text} at (0,0) size 31x19
text run at (0,0) width 31: "RTL"
RenderBlock (anonymous) at (0,136) size 784x19
RenderText {#text} at (0,0) size 184x19
text run at (0,0) width 184: "LTR (text-overflow:ellipses):"
RenderBlock (anonymous) at (0,177) size 784x19
RenderText {#text} at (0,0) size 184x19
text run at (0,0) width 184: "RTL (text-overflow:ellipses):"
layer at (8,81) size 202x22 clip at (9,82) size 200x20 scrollWidth 221
RenderBlock {DIV} at (0,73) size 202x22 [border: (1px solid #000000)]
RenderText {#text} at (1,1) size 220x19
text run at (1,1) width 220: "the the adlj adaasj sdklj. there there"
layer at (8,122) size 202x22 clip at (9,123) size 200x20 scrollX 20 scrollWidth 220
RenderBlock {DIV} at (0,114) size 202x22 [border: (1px solid #000000)]
RenderText {#text} at (-19,1) size 220x19
text run at (-19,1) width 220 RTL override: "the the adlj adaasj sdklj. there there"
layer at (8,163) size 202x22 clip at (9,164) size 200x20 scrollWidth 221
RenderBlock {DIV} at (0,155) size 202x22 [border: (1px solid #000000)]
RenderText {#text} at (1,1) size 220x19
text run at (1,1) width 220: "the the adlj adaasj sdklj. there there"
layer at (8,204) size 202x22 clip at (9,205) size 200x20 scrollX 20 scrollWidth 220
RenderBlock {DIV} at (0,196) size 202x22 [border: (1px solid #000000)]
RenderText {#text} at (-19,1) size 220x19
text run at (-19,1) width 220 RTL override: "the the adlj adaasj sdklj. there there"
2010-12-09 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add hasSpellingMarker support to the DRT
https://bugs.webkit.org/show_bug.cgi?id=50739
Added a new private API function to support the spelling marker
tests in the DRT.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
2010-12-10 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
......
......@@ -515,3 +515,10 @@ unsigned int DumpRenderTreeSupportGtk::workerThreadCount()
return 0;
#endif
}
bool DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker(WebKitWebFrame *frame, gint from, gint length)
{
g_return_val_if_fail(WEBKIT_IS_WEB_FRAME(frame), FALSE);
return core(frame)->editor()->selectionStartHasSpellingMarkerFor(from, length);
}
......@@ -78,6 +78,7 @@ public:
static void whiteListAccessFromOrigin(const gchar* sourceOrigin, const gchar* destinationProtocol, const gchar* destinationHost, bool allowDestinationSubdomains);
static void resetOriginAccessWhiteLists();
static unsigned int workerThreadCount();
static bool webkitWebFrameSelectionHasSpellingMarker(WebKitWebFrame*, gint from, gint length);
private:
static bool s_drtRun;
......
2010-12-10 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add hasSpellingMarker support to the DRT
https://bugs.webkit.org/show_bug.cgi?id=50739
Implemented the hasSpellingMarker to support spelling tests.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::hasSpellingMarker):
2010-12-10 Eric Seidel <eric@webkit.org>
Reviewed by Ojan Vafai.
......
......@@ -816,10 +816,9 @@ void LayoutTestController::abortModal()
{
}
bool LayoutTestController::hasSpellingMarker(int, int)
bool LayoutTestController::hasSpellingMarker(int from, int length)
{
// FIXME: Implement this.
return false;
return DumpRenderTreeSupportGtk::webkitWebFrameSelectionHasSpellingMarker(mainFrame, from, length);
}
void LayoutTestController::dumpConfigurationForViewport(int availableWidth, int availableHeight)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment