2011-01-28 Tom Sepez <tsepez@chromium.org>

        Reviewed by Eric Seidel.

        NULL pointer crash in TextIterator::handleTextBox()
        https://bugs.webkit.org/show_bug.cgi?id=53267

        * fast/css/rtl-nth-child-first-letter-crash-expected.txt: Added.
        * fast/css/rtl-nth-child-first-letter-crash.html: Added.
2011-01-28  Tom Sepez  <tsepez@chromium.org>

        Reviewed by Eric Seidel.

        NULL pointer crash in TextIterator::handleTextBox()
        https://bugs.webkit.org/show_bug.cgi?id=53267

        Test: fast/css/rtl-nth-child-first-letter-crash.html

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::handleTextBox):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 6eac3bbe
2011-01-28 Tom Sepez <tsepez@chromium.org>
Reviewed by Eric Seidel.
NULL pointer crash in TextIterator::handleTextBox()
https://bugs.webkit.org/show_bug.cgi?id=53267
* fast/css/rtl-nth-child-first-letter-crash-expected.txt: Added.
* fast/css/rtl-nth-child-first-letter-crash.html: Added.
2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>
Skip webkitAudioPannerNode from the test. It's not yet implemented across
}
NULL pointer crash in TextIterator::handleTextBox() when using RTL text. If there is no crash, then the test passes.
If you can see this, then the test passes.
}
<style>
*:nth-child(2):first-letter {float: left;direction: rtl;
</style>
<p>NULL pointer crash in TextIterator::handleTextBox() when using RTL text.
If there is no crash, then the test passes.</p>
<script>
if (window.layoutTestController)
layoutTestController.dumpAsText();
</script>
<p>If you can see this, then the test passes.</p>
2011-01-28 Tom Sepez <tsepez@chromium.org>
Reviewed by Eric Seidel.
NULL pointer crash in TextIterator::handleTextBox()
https://bugs.webkit.org/show_bug.cgi?id=53267
Test: fast/css/rtl-nth-child-first-letter-crash.html
* editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextBox):
2011-01-28 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
......@@ -543,7 +543,7 @@ void TextIterator::handleTextBox()
unsigned runStart = max(textBoxStart, start);
// Check for collapsed space at the start of this run.
InlineTextBox* firstTextBox = renderer->containsReversedText() ? m_sortedTextBoxes[0] : renderer->firstTextBox();
InlineTextBox* firstTextBox = renderer->containsReversedText() ? (m_sortedTextBoxes.isEmpty() ? 0 : m_sortedTextBoxes[0]) : renderer->firstTextBox();
bool needSpace = m_lastTextNodeEndedWithCollapsedSpace
|| (m_textBox == firstTextBox && textBoxStart == runStart && runStart > 0);
if (needSpace && !isCollapsibleWhitespace(m_lastCharacter) && m_lastCharacter) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment