Commit 20a2a355 authored by ojan@chromium.org's avatar ojan@chromium.org

2010-08-19 Ojan Vafai <ojan@chromium.org>

        Reviewed by Adam Barth.

        add --webkit_patch_id to reitveld uploads
        https://bugs.webkit.org/show_bug.cgi?id=44289

        This is the first step in having rietveld store which
        patches have been uploaded and getting rid of the
        in-rietveld flag.

        * Scripts/webkitpy/common/net/rietveld.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/postcodereview.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent de39621b
2010-08-19 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
add --webkit_patch_id to reitveld uploads
https://bugs.webkit.org/show_bug.cgi?id=44289
This is the first step in having rietveld store which
patches have been uploaded and getting rid of the
in-rietveld flag.
* Scripts/webkitpy/common/net/rietveld.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/postcodereview.py:
2010-08-19 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
......
......@@ -47,7 +47,7 @@ class Rietveld(object):
return None
return "%s%s" % (config.codereview_server_url, codereview_issue)
def post(self, diff, message=None, codereview_issue=None, cc=None):
def post(self, diff, patch_id, codereview_issue, message=None, cc=None):
if not message:
raise ScriptError("Rietveld requires a message.")
......@@ -61,6 +61,7 @@ class Rietveld(object):
"--assume_yes",
"--server=%s" % config.codereview_server_host,
"--message=%s" % message,
"--webkit_patch_id=%s" % patch_id,
]
if codereview_issue:
args.append("--issue=%s" % codereview_issue)
......
......@@ -551,7 +551,7 @@ class MockRietveld():
def __init__(self, executive, dryrun=False):
pass
def post(self, diff, message=None, codereview_issue=None, cc=None):
def post(self, diff, patch_id, codereview_issue, message=None, cc=None):
log("MOCK: Uploading patch to rietveld")
......
......@@ -64,6 +64,7 @@ class PostCodeReview(AbstractStep):
created_issue = self._tool.codereview.post(diff=self.cached_lookup(state, "diff"),
message=message,
codereview_issue=bug_id,
cc=self._options.cc)
cc=self._options.cc,
patch_id=patch.id())
self._tool.bugs.set_flag_on_attachment(patch.id(), 'in-rietveld', '+')
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment