Commit 207a9d7d authored by agl@chromium.org's avatar agl@chromium.org

2010-05-20 Adam Langley <agl@chromium.org>

        Reviewed by David Levin.

        [chromium] Avoid crash when msttcorefonts aren't provided

        https://bugs.webkit.org/show_bug.cgi?id=39015
        http://code.google.com/p/chromium/issues/detail?id=43831

        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::createFontPlatformData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59835 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent aef21388
2010-05-20 Adam Langley <agl@chromium.org>
Reviewed by David Levin.
[chromium] Add test which previously crashed on Linux.
https://bugs.webkit.org/show_bug.cgi?id=39015
http://code.google.com/p/chromium/issues/detail?id=43831
* fast/text/chromium-linux-fallback-crash-expected.txt: Added.
* fast/text/chromium-linux-fallback-crash.html: Added.
2010-05-20 Herczeg Zoltan <zherczeg@webkit.org>
Unreviewed. Update Qt specific expected file.
Previously this would crash Chromium Linux by triggering a NULL pointer dereference in the font fallback code.
Foo
<html>
<script>
if (window.layoutTestController)
layoutTestController.dumpAsText();
</script>
<body>
<p>Previously this would crash Chromium Linux by triggering a NULL pointer dereference in the font fallback code.</p>
<span style="font-family: -webkit-family-will-not-be-found;">Foo</span>
</body>
</html>
2010-05-20 Adam Langley <agl@chromium.org>
Reviewed by David Levin.
[chromium] Avoid crash when msttcorefonts aren't provided
https://bugs.webkit.org/show_bug.cgi?id=39015
http://code.google.com/p/chromium/issues/detail?id=43831
* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::createFontPlatformData):
2010-05-20 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Dirk Schulze.
......@@ -128,9 +128,10 @@ FontPlatformData* FontCache::createFontPlatformData(const FontDescription& fontD
break;
}
}
// if we fall out of the loop, it's ok for name to still be 0
}
else { // convert the name to utf8
if (!name)
name = "";
} else {
// convert the name to utf8
s = family.string().utf8();
name = s.data();
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment