Commit 20042ea6 authored by mrobinson@webkit.org's avatar mrobinson@webkit.org

2011-01-24 Martin Robinson <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Many DOM XHTML tests time out
        https://bugs.webkit.org/show_bug.cgi?id=52553

        * platform/gtk/Skipped: Unskip tests which are no longer timing out.
2011-01-24  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Many DOM XHTML tests time out
        https://bugs.webkit.org/show_bug.cgi?id=52553

        Properly handle the situation where a synchronous load fails before the inner
        event loop has started. In this case, we simply do not run the inner event loop,
        or else it will block indefinitely (since no GIO or libsoup callbacks will fire).

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::loadResourceSynchronously): Bail out of a synchronous
        load if it fails up front.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 82cb49a6
2011-01-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Many DOM XHTML tests time out
https://bugs.webkit.org/show_bug.cgi?id=52553
* platform/gtk/Skipped: Unskip tests which are no longer timing out.
2011-01-24 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium test expectation update for r76548.
......
......@@ -30,23 +30,7 @@
# The group of tests below are timing out. As we go through them
# and get more detailed information, we should attach bugs to them.
dom/xhtml/level3/core/entitygetinputencoding03.xhtml
dom/xhtml/level3/core/entitygetinputencoding04.xhtml
dom/xhtml/level3/core/entitygetxmlencoding02.xhtml
dom/xhtml/level3/core/entitygetxmlencoding03.xhtml
dom/xhtml/level3/core/entitygetxmlencoding04.xhtml
dom/xhtml/level3/core/entitygetxmlversion03.xhtml
dom/xhtml/level3/core/entitygetxmlversion04.xhtml
dom/xhtml/level3/core/nodegetbaseuri16.xhtml
dom/xhtml/level3/core/nodegetbaseuri19.xhtml
dom/xhtml/level3/core/nodegetbaseuri20.xhtml
http/tests/xmlhttprequest/XMLHttpRequestException.html
http/tests/xmlhttprequest/connection-error-sync.html
fast/xmlhttprequest/null-document-xmlhttprequest-open.html
http/tests/misc/favicon-as-image.html
media/unsupported-rtsp.html
security/autocomplete-cleared-on-back.html
http/tests/security/frameNavigation/cross-origin-opener.html
# Intermittently timing out on Gtk Debug Bot:
# https://bugs.webkit.org/show_bug.cgi?id=33445
......
2011-01-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Many DOM XHTML tests time out
https://bugs.webkit.org/show_bug.cgi?id=52553
Properly handle the situation where a synchronous load fails before the inner
event loop has started. In this case, we simply do not run the inner event loop,
or else it will block indefinitely (since no GIO or libsoup callbacks will fire).
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously): Bail out of a synchronous
load if it fails up front.
2011-01-24 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Adler.
......@@ -801,6 +801,10 @@ void ResourceHandle::loadResourceSynchronously(NetworkingContext* context, const
RefPtr<ResourceHandle> handle = adoptRef(new ResourceHandle(request, &syncLoader, false /*defersLoading*/, false /*shouldContentSniff*/));
handle->start(context);
// If the request has already failed, do not run the main loop, or else we'll block indefinitely.
if (handle->d->m_scheduledFailureType != NoFailure)
return;
syncLoader.run();
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment