Commit 1ff04429 authored by hyatt@apple.com's avatar hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49228

        
Reviewed by Simon Fraser.

REGRESSION: caret too short when a positive line height is specified.  Now that lineTop no longer
accidentally incorporates the top leading, we need to use selectionTop/Bottom for the caret rect.

* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent c76b40b9
2010-11-08 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=49228
REGRESSION: caret too short when a positive line height is specified. Now that lineTop no longer
accidentally incorporates the top leading, we need to use selectionTop/Bottom for the caret rect.
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
2010-11-08 Pierre-Antoine LaFayette <pierre.lafayette@gmail.com>
Reviewed by Darin Fisher.
......@@ -484,8 +484,8 @@ IntRect RenderText::localCaretRect(InlineBox* inlineBox, int caretOffset, int* e
InlineTextBox* box = static_cast<InlineTextBox*>(inlineBox);
int height = box->root()->lineBottom() - box->root()->lineTop();
int top = box->root()->lineTop();
int height = box->root()->selectionHeight();
int top = box->root()->selectionTop();
int left = box->positionForOffset(caretOffset);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment